linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/3] arm64: dts: imx8mq-librem5: correct GPIO hog property
@ 2020-09-20 19:57 Krzysztof Kozlowski
  2020-09-20 19:57 ` [PATCH v3 2/3] arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-20 19:57 UTC (permalink / raw)
  To: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, Martin Kepplinger,
	Angus Ainslie (Purism),
	Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-kernel

Correct the name of property for GPIO specifier in GPIO hog.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v2:
1. None, split from previous patchset using common GPIO schema
---
 arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 56295dd2fa8f..e4dedcb58f76 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -251,7 +251,7 @@
 
 	pmic-5v {
 		gpio-hog;
-		gpio = <&gpio1 1 GPIO_ACTIVE_HIGH>;
+		gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>;
 		input;
 	};
 };
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v3 2/3] arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema
  2020-09-20 19:57 [PATCH v3 1/3] arm64: dts: imx8mq-librem5: correct GPIO hog property Krzysztof Kozlowski
@ 2020-09-20 19:57 ` Krzysztof Kozlowski
  2020-09-22  6:51   ` Shawn Guo
  2020-10-26  7:34   ` Shawn Guo
  2020-09-20 19:57 ` [PATCH v3 3/3] ARM: dts: imx: " Krzysztof Kozlowski
  2020-09-22  6:50 ` [PATCH v3 1/3] arm64: dts: imx8mq-librem5: correct GPIO hog property Shawn Guo
  2 siblings, 2 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-20 19:57 UTC (permalink / raw)
  To: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, Martin Kepplinger,
	Angus Ainslie (Purism),
	Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-kernel

dtschema expects GPIO hogs to end with 'hog' suffix.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v2:
1. None, split from previous patchset using common GPIO schema
---
 arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index e4dedcb58f76..6cbcee2fb938 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -249,7 +249,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pmic_5v>;
 
-	pmic-5v {
+	pmic-5v-hog {
 		gpio-hog;
 		gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>;
 		input;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH v3 3/3] ARM: dts: imx: align GPIO hog names with dtschema
  2020-09-20 19:57 [PATCH v3 1/3] arm64: dts: imx8mq-librem5: correct GPIO hog property Krzysztof Kozlowski
  2020-09-20 19:57 ` [PATCH v3 2/3] arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema Krzysztof Kozlowski
@ 2020-09-20 19:57 ` Krzysztof Kozlowski
  2020-10-26  7:35   ` Shawn Guo
  2020-09-22  6:50 ` [PATCH v3 1/3] arm64: dts: imx8mq-librem5: correct GPIO hog property Shawn Guo
  2 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-20 19:57 UTC (permalink / raw)
  To: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, Martin Kepplinger,
	Angus Ainslie (Purism),
	Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-kernel

dtschema for GPIO controllers expects GPIO hogs to end with 'hog'
suffix.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v2:
1. None, split from previous patchset using common GPIO schema
---
 arch/arm/boot/dts/imx51-zii-rdu1.dts        | 2 +-
 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi     | 8 ++++----
 arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
index e559ab0c3645..ec8ca3ac2c1c 100644
--- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
+++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
@@ -451,7 +451,7 @@
 			  "", "", "", "",
 			  "", "", "", "";
 
-	unused-sd3-wp-gpio {
+	unused-sd3-wp-hog {
 		/*
 		 * See pinctrl_esdhc1 below for more details on this
 		 */
diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 66b15748e287..c0a76202e16b 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -330,28 +330,28 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_gpio3_hog>;
 
-	usb-emulation {
+	usb-emulation-hog {
 		gpio-hog;
 		gpios = <19 GPIO_ACTIVE_HIGH>;
 		output-low;
 		line-name = "usb-emulation";
 	};
 
-	usb-mode1 {
+	usb-mode1-hog {
 		gpio-hog;
 		gpios = <20 GPIO_ACTIVE_HIGH>;
 		output-high;
 		line-name = "usb-mode1";
 	};
 
-	usb-pwr {
+	usb-pwr-hog {
 		gpio-hog;
 		gpios = <22 GPIO_ACTIVE_LOW>;
 		output-high;
 		line-name = "usb-pwr-ctrl-en-n";
 	};
 
-	usb-mode2 {
+	usb-mode2-hog {
 		gpio-hog;
 		gpios = <23 GPIO_ACTIVE_HIGH>;
 		output-high;
diff --git a/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts b/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts
index a0bbec57ddc7..3ec042bfccba 100644
--- a/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts
+++ b/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts
@@ -110,7 +110,7 @@
 };
 
 &gpio5 {
-	emmc-usd-mux {
+	emmc-usd-mux-hog {
 		gpio-hog;
 		gpios = <1 GPIO_ACTIVE_LOW>;
 		output-high;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 1/3] arm64: dts: imx8mq-librem5: correct GPIO hog property
  2020-09-20 19:57 [PATCH v3 1/3] arm64: dts: imx8mq-librem5: correct GPIO hog property Krzysztof Kozlowski
  2020-09-20 19:57 ` [PATCH v3 2/3] arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema Krzysztof Kozlowski
  2020-09-20 19:57 ` [PATCH v3 3/3] ARM: dts: imx: " Krzysztof Kozlowski
@ 2020-09-22  6:50 ` Shawn Guo
  2 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2020-09-22  6:50 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, Martin Kepplinger,
	Angus Ainslie (Purism),
	devicetree, linux-arm-kernel, linux-kernel

On Sun, Sep 20, 2020 at 09:57:47PM +0200, Krzysztof Kozlowski wrote:
> Correct the name of property for GPIO specifier in GPIO hog.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Applied, thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 2/3] arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema
  2020-09-20 19:57 ` [PATCH v3 2/3] arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema Krzysztof Kozlowski
@ 2020-09-22  6:51   ` Shawn Guo
  2020-09-22 14:24     ` Krzysztof Kozlowski
  2020-10-26  7:34   ` Shawn Guo
  1 sibling, 1 reply; 9+ messages in thread
From: Shawn Guo @ 2020-09-22  6:51 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, Martin Kepplinger,
	Angus Ainslie (Purism),
	devicetree, linux-arm-kernel, linux-kernel

On Sun, Sep 20, 2020 at 09:57:48PM +0200, Krzysztof Kozlowski wrote:
> dtschema expects GPIO hogs to end with 'hog' suffix.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Ping me after dtschema gets accepted.

Shawn

> 
> ---
> 
> Changes since v2:
> 1. None, split from previous patchset using common GPIO schema
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index e4dedcb58f76..6cbcee2fb938 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -249,7 +249,7 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_pmic_5v>;
>  
> -	pmic-5v {
> +	pmic-5v-hog {
>  		gpio-hog;
>  		gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>;
>  		input;
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 2/3] arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema
  2020-09-22  6:51   ` Shawn Guo
@ 2020-09-22 14:24     ` Krzysztof Kozlowski
  2020-10-13 16:31       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-22 14:24 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, Martin Kepplinger,
	Angus Ainslie (Purism),
	devicetree, linux-arm-kernel, linux-kernel

On Tue, 22 Sep 2020 at 08:52, Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Sun, Sep 20, 2020 at 09:57:48PM +0200, Krzysztof Kozlowski wrote:
> > dtschema expects GPIO hogs to end with 'hog' suffix.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Ping me after dtschema gets accepted.

Hi Shawn,

Happened just now, in dt-schema repo:
https://github.com/devicetree-org/dt-schema/pull/47

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 2/3] arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema
  2020-09-22 14:24     ` Krzysztof Kozlowski
@ 2020-10-13 16:31       ` Krzysztof Kozlowski
  0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-13 16:31 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, Martin Kepplinger,
	Angus Ainslie (Purism),
	devicetree, linux-arm-kernel, linux-kernel

On Tue, 22 Sep 2020 at 16:24, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Tue, 22 Sep 2020 at 08:52, Shawn Guo <shawnguo@kernel.org> wrote:
> >
> > On Sun, Sep 20, 2020 at 09:57:48PM +0200, Krzysztof Kozlowski wrote:
> > > dtschema expects GPIO hogs to end with 'hog' suffix.
> > >
> > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >
> > Ping me after dtschema gets accepted.
>
> Hi Shawn,
>
> Happened just now, in dt-schema repo:
> https://github.com/devicetree-org/dt-schema/pull/47

The dtschema was accepted in September. Can you pick up this patch?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 2/3] arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema
  2020-09-20 19:57 ` [PATCH v3 2/3] arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema Krzysztof Kozlowski
  2020-09-22  6:51   ` Shawn Guo
@ 2020-10-26  7:34   ` Shawn Guo
  1 sibling, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2020-10-26  7:34 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, Martin Kepplinger,
	Angus Ainslie (Purism),
	devicetree, linux-arm-kernel, linux-kernel

On Sun, Sep 20, 2020 at 09:57:48PM +0200, Krzysztof Kozlowski wrote:
> dtschema expects GPIO hogs to end with 'hog' suffix.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Applied, thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v3 3/3] ARM: dts: imx: align GPIO hog names with dtschema
  2020-09-20 19:57 ` [PATCH v3 3/3] ARM: dts: imx: " Krzysztof Kozlowski
@ 2020-10-26  7:35   ` Shawn Guo
  0 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2020-10-26  7:35 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, Martin Kepplinger,
	Angus Ainslie (Purism),
	devicetree, linux-arm-kernel, linux-kernel

On Sun, Sep 20, 2020 at 09:57:49PM +0200, Krzysztof Kozlowski wrote:
> dtschema for GPIO controllers expects GPIO hogs to end with 'hog'
> suffix.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Applied, thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-10-26  7:35 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-20 19:57 [PATCH v3 1/3] arm64: dts: imx8mq-librem5: correct GPIO hog property Krzysztof Kozlowski
2020-09-20 19:57 ` [PATCH v3 2/3] arm64: dts: imx8mq-librem5: align GPIO hog names with dtschema Krzysztof Kozlowski
2020-09-22  6:51   ` Shawn Guo
2020-09-22 14:24     ` Krzysztof Kozlowski
2020-10-13 16:31       ` Krzysztof Kozlowski
2020-10-26  7:34   ` Shawn Guo
2020-09-20 19:57 ` [PATCH v3 3/3] ARM: dts: imx: " Krzysztof Kozlowski
2020-10-26  7:35   ` Shawn Guo
2020-09-22  6:50 ` [PATCH v3 1/3] arm64: dts: imx8mq-librem5: correct GPIO hog property Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).