* [PATCH net-next v2] net: microchip: Make `lan743x_pm_suspend` function return right value
@ 2020-09-23 3:21 Zheng Yongjun
2020-09-23 18:46 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2020-09-23 3:21 UTC (permalink / raw)
To: bryan.whitehead, UNGLinuxDriver, davem, kuba, netdev, linux-kernel
Cc: Zheng Yongjun
drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend:
`ret` is set but not used. In fact, `pci_prepare_to_sleep` function value should
be the right value of `lan743x_pm_suspend` function, therefore, fix it.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/net/ethernet/microchip/lan743x_main.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
index de93cc6ebc1a..7e236c9ee4b1 100644
--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -3038,7 +3038,6 @@ static int lan743x_pm_suspend(struct device *dev)
struct pci_dev *pdev = to_pci_dev(dev);
struct net_device *netdev = pci_get_drvdata(pdev);
struct lan743x_adapter *adapter = netdev_priv(netdev);
- int ret;
lan743x_pcidev_shutdown(pdev);
@@ -3051,9 +3050,7 @@ static int lan743x_pm_suspend(struct device *dev)
lan743x_pm_set_wol(adapter);
/* Host sets PME_En, put D3hot */
- ret = pci_prepare_to_sleep(pdev);
-
- return 0;
+ return pci_prepare_to_sleep(pdev);;
}
static int lan743x_pm_resume(struct device *dev)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v2] net: microchip: Make `lan743x_pm_suspend` function return right value
2020-09-23 3:21 [PATCH net-next v2] net: microchip: Make `lan743x_pm_suspend` function return right value Zheng Yongjun
@ 2020-09-23 18:46 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-09-23 18:46 UTC (permalink / raw)
To: zhengyongjun3; +Cc: bryan.whitehead, UNGLinuxDriver, kuba, netdev, linux-kernel
From: Zheng Yongjun <zhengyongjun3@huawei.com>
Date: Wed, 23 Sep 2020 11:21:40 +0800
> drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend:
>
> `ret` is set but not used. In fact, `pci_prepare_to_sleep` function value should
> be the right value of `lan743x_pm_suspend` function, therefore, fix it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-23 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 3:21 [PATCH net-next v2] net: microchip: Make `lan743x_pm_suspend` function return right value Zheng Yongjun
2020-09-23 18:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).