* [PATCH v2] drm/msm/a6xx: Fix a size determination in a6xx_get_indexed_registers()
@ 2020-09-14 2:29 Zhenzhong Duan
2020-09-23 15:06 ` Jordan Crouse
0 siblings, 1 reply; 2+ messages in thread
From: Zhenzhong Duan @ 2020-09-14 2:29 UTC (permalink / raw)
To: linux-kernel
Cc: robdclark, sean, airlied, daniel, smasetty, jcrouse, jonathan,
linux-arm-msm, dri-devel, freedreno, Markus.Elfring,
Zhenzhong Duan
It's allocating an array of a6xx_gpu_state_obj structure rather than
its pointers.
Fixes: d6852b4b2d01 ("drm/msm/a6xx: Track and manage a6xx state memory")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
---
v2: Update commit message per Markus, thanks
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
index b12f5b4..e9ede19 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
@@ -875,7 +875,7 @@ static void a6xx_get_indexed_registers(struct msm_gpu *gpu,
int i;
a6xx_state->indexed_regs = state_kcalloc(a6xx_state, count,
- sizeof(a6xx_state->indexed_regs));
+ sizeof(*a6xx_state->indexed_regs));
if (!a6xx_state->indexed_regs)
return;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drm/msm/a6xx: Fix a size determination in a6xx_get_indexed_registers()
2020-09-14 2:29 [PATCH v2] drm/msm/a6xx: Fix a size determination in a6xx_get_indexed_registers() Zhenzhong Duan
@ 2020-09-23 15:06 ` Jordan Crouse
0 siblings, 0 replies; 2+ messages in thread
From: Jordan Crouse @ 2020-09-23 15:06 UTC (permalink / raw)
To: Zhenzhong Duan
Cc: linux-kernel, robdclark, sean, airlied, daniel, smasetty,
jonathan, linux-arm-msm, dri-devel, freedreno, Markus.Elfring
On Mon, Sep 14, 2020 at 10:29:49AM +0800, Zhenzhong Duan wrote:
> It's allocating an array of a6xx_gpu_state_obj structure rather than
> its pointers.
>
> Fixes: d6852b4b2d01 ("drm/msm/a6xx: Track and manage a6xx state memory")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
> ---
> v2: Update commit message per Markus, thanks
>
> drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
> index b12f5b4..e9ede19 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
> @@ -875,7 +875,7 @@ static void a6xx_get_indexed_registers(struct msm_gpu *gpu,
> int i;
>
> a6xx_state->indexed_regs = state_kcalloc(a6xx_state, count,
> - sizeof(a6xx_state->indexed_regs));
> + sizeof(*a6xx_state->indexed_regs));
> if (!a6xx_state->indexed_regs)
> return;
>
> --
> 1.8.3.1
>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-23 15:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14 2:29 [PATCH v2] drm/msm/a6xx: Fix a size determination in a6xx_get_indexed_registers() Zhenzhong Duan
2020-09-23 15:06 ` Jordan Crouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).