* Re: [PATCH -next] crypto: qat - remove unnecessary mutex_init()
[not found] <ee44c6c05720495d8bb72ae9ad7094e8@irsmsx602.ger.corp.intel.com>
@ 2020-09-24 5:03 ` Giovanni Cabiddu
0 siblings, 0 replies; 3+ messages in thread
From: Giovanni Cabiddu @ 2020-09-24 5:03 UTC (permalink / raw)
To: Qinglang Miao
Cc: Herbert Xu, David S. Miller, qat-linux, linux-crypto, linux-kernel
On Wed, Sep 16, 2020 at 07:21:21AM +0100, Qinglang Miao wrote:
> The mutex adf_ctl_lock is initialized statically. It is
> unnecessary to initialize by mutex_init().
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
> drivers/crypto/qat/qat_common/adf_ctl_drv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/crypto/qat/qat_common/adf_ctl_drv.c b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
> index 71d0c44aa..eb9b3be9d 100644
> --- a/drivers/crypto/qat/qat_common/adf_ctl_drv.c
> +++ b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
> @@ -416,8 +416,6 @@ static long adf_ctl_ioctl(struct file *fp, unsigned int cmd, unsigned long arg)
>
> static int __init adf_register_ctl_device_driver(void)
> {
> - mutex_init(&adf_ctl_lock);
> -
> if (adf_chr_drv_create())
> goto err_chr_dev;
>
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] crypto: qat - remove unnecessary mutex_init()
2020-09-16 6:21 Qinglang Miao
@ 2020-09-25 8:11 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-09-25 8:11 UTC (permalink / raw)
To: Qinglang Miao
Cc: Giovanni Cabiddu, David S. Miller, qat-linux, linux-crypto, linux-kernel
On Wed, Sep 16, 2020 at 02:21:21PM +0800, Qinglang Miao wrote:
> The mutex adf_ctl_lock is initialized statically. It is
> unnecessary to initialize by mutex_init().
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> drivers/crypto/qat/qat_common/adf_ctl_drv.c | 2 --
> 1 file changed, 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH -next] crypto: qat - remove unnecessary mutex_init()
@ 2020-09-16 6:21 Qinglang Miao
2020-09-25 8:11 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Qinglang Miao @ 2020-09-16 6:21 UTC (permalink / raw)
To: Giovanni Cabiddu, Herbert Xu, David S. Miller
Cc: qat-linux, linux-crypto, linux-kernel, Qinglang Miao
The mutex adf_ctl_lock is initialized statically. It is
unnecessary to initialize by mutex_init().
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
drivers/crypto/qat/qat_common/adf_ctl_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/crypto/qat/qat_common/adf_ctl_drv.c b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
index 71d0c44aa..eb9b3be9d 100644
--- a/drivers/crypto/qat/qat_common/adf_ctl_drv.c
+++ b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
@@ -416,8 +416,6 @@ static long adf_ctl_ioctl(struct file *fp, unsigned int cmd, unsigned long arg)
static int __init adf_register_ctl_device_driver(void)
{
- mutex_init(&adf_ctl_lock);
-
if (adf_chr_drv_create())
goto err_chr_dev;
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-25 8:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <ee44c6c05720495d8bb72ae9ad7094e8@irsmsx602.ger.corp.intel.com>
2020-09-24 5:03 ` [PATCH -next] crypto: qat - remove unnecessary mutex_init() Giovanni Cabiddu
2020-09-16 6:21 Qinglang Miao
2020-09-25 8:11 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).