linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi: bfa: fix error return in bfad_pci_init()
@ 2020-09-25  6:24 Jing Xiangfeng
  2020-10-08  2:45 ` Martin K. Petersen
  2020-10-13 22:42 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Jing Xiangfeng @ 2020-09-25  6:24 UTC (permalink / raw)
  To: anil.gurumurthy, sudarsana.kalluru, jejb, martin.petersen, emilne, hare
  Cc: linux-scsi, linux-kernel, jingxiangfeng

Fix to return error code -ENODEV from the error handling case instead
of 0.

Fixes: 11ea3824140c ("scsi: bfa: fix calls to dma_set_mask_and_coherent()")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
 drivers/scsi/bfa/bfad.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c
index bc5d84f87d8f..440ef32be048 100644
--- a/drivers/scsi/bfa/bfad.c
+++ b/drivers/scsi/bfa/bfad.c
@@ -749,6 +749,7 @@ bfad_pci_init(struct pci_dev *pdev, struct bfad_s *bfad)
 
 	if (bfad->pci_bar0_kva == NULL) {
 		printk(KERN_ERR "Fail to map bar0\n");
+		rc = -ENODEV;
 		goto out_release_region;
 	}
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: bfa: fix error return in bfad_pci_init()
  2020-09-25  6:24 [PATCH] scsi: bfa: fix error return in bfad_pci_init() Jing Xiangfeng
@ 2020-10-08  2:45 ` Martin K. Petersen
  2020-10-13 22:42 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-08  2:45 UTC (permalink / raw)
  To: Jing Xiangfeng
  Cc: anil.gurumurthy, sudarsana.kalluru, jejb, martin.petersen,
	emilne, hare, linux-scsi, linux-kernel


Jing,

> Fix to return error code -ENODEV from the error handling case instead
> of 0.

Applied to 5.10/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: bfa: fix error return in bfad_pci_init()
  2020-09-25  6:24 [PATCH] scsi: bfa: fix error return in bfad_pci_init() Jing Xiangfeng
  2020-10-08  2:45 ` Martin K. Petersen
@ 2020-10-13 22:42 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-13 22:42 UTC (permalink / raw)
  To: emilne, hare, Jing Xiangfeng, jejb, anil.gurumurthy, sudarsana.kalluru
  Cc: Martin K . Petersen, linux-kernel, linux-scsi

On Fri, 25 Sep 2020 14:24:23 +0800, Jing Xiangfeng wrote:

> Fix to return error code -ENODEV from the error handling case instead
> of 0.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: bfa: Fix error return in bfad_pci_init()
      https://git.kernel.org/mkp/scsi/c/f0f6c3a4fcb8

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-13 22:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-25  6:24 [PATCH] scsi: bfa: fix error return in bfad_pci_init() Jing Xiangfeng
2020-10-08  2:45 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).