* [PATCH v2] usb: bdc: Fix the return value and remove duplicate error message
@ 2020-09-28 12:00 Tang Bin
0 siblings, 0 replies; only message in thread
From: Tang Bin @ 2020-09-28 12:00 UTC (permalink / raw)
To: f.fainelli, balbi, gregkh, chunfeng.yun
Cc: linux-usb, linux-kernel, Tang Bin, Zhang Shengju
When call function devm_platform_ioremap_resource(), we should use
IS_ERR() to check the return value and return PTR_ERR() if failed,
and it can print an error message itself if failed. So remove the
redundant dev_err() in this place.
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
Changes from v1
- fix the subject and commit message
- fix the code of right return if failed
---
drivers/usb/gadget/udc/bdc/bdc_core.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
index 02a3a7746..70ff31bc8 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_core.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
@@ -508,10 +508,9 @@ static int bdc_probe(struct platform_device *pdev)
bdc->clk = clk;
bdc->regs = devm_platform_ioremap_resource(pdev, 0);
- if (IS_ERR(bdc->regs)) {
- dev_err(dev, "ioremap error\n");
- return -ENOMEM;
- }
+ if (IS_ERR(bdc->regs))
+ return PTR_ERR(bdc->regs);
+
irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-28 12:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28 12:00 [PATCH v2] usb: bdc: Fix the return value and remove duplicate error message Tang Bin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).