[PATCH] kvfree_rcu(): fix ifnullfree.cocci warnings

[PATCH] kvfree_rcu(): fix ifnullfree.cocci warnings

[Julia Lawall]

From: kernel test robot <lkp@intel.com>

NULL check before kfree is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes: e9bed2a1239b ("kvfree_rcu(): Switch to kmalloc() and kfree() for allocations")
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git urezki-pcount.2020.09.26a
head:   1a8eee1cc5b0e59c17f5d94c5871e6c70c4a43a1
commit: e9bed2a1239b017d78cec5de66adce0560f6d077 [17/18] kvfree_rcu(): Switch to kmalloc() and kfree() for allocations
:::::: branch date: 4 hours ago
:::::: commit date: 15 hours ago

 tree.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3165,8 +3165,7 @@ static void kfree_rcu_work(struct work_s
 				bkvhead[i] = NULL;
 			krc_this_cpu_unlock(krcp, flags);

-			if (bkvhead[i])
-				kfree(bkvhead[i]);
+			kfree(bkvhead[i]);

 			cond_resched_tasks_rcu_qs();
 		}

Re: [PATCH] kvfree_rcu(): fix ifnullfree.cocci warnings

[Joel Fernandes]

On Sun, Sep 27, 2020 at 03:00:29PM +0200, Julia Lawall wrote:
> From: kernel test robot <lkp@intel.com>
> 
> NULL check before kfree is not needed.
> 
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
> 
> Fixes: e9bed2a1239b ("kvfree_rcu(): Switch to kmalloc() and kfree() for allocations")
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git urezki-pcount.2020.09.26a
> head:   1a8eee1cc5b0e59c17f5d94c5871e6c70c4a43a1
> commit: e9bed2a1239b017d78cec5de66adce0560f6d077 [17/18] kvfree_rcu(): Switch to kmalloc() and kfree() for allocations
> :::::: branch date: 4 hours ago
> :::::: commit date: 15 hours ago
> 
>  tree.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -3165,8 +3165,7 @@ static void kfree_rcu_work(struct work_s
>  				bkvhead[i] = NULL;
>  			krc_this_cpu_unlock(krcp, flags);
> 
> -			if (bkvhead[i])
> -				kfree(bkvhead[i]);
> +			kfree(bkvhead[i]);
> 

Acked-by: Joel Fernandes (Google) <joel@joelfernandes.org>

thanks,

 - Joel

>  			cond_resched_tasks_rcu_qs();
>  		}

Re: [PATCH] kvfree_rcu(): fix ifnullfree.cocci warnings

[Paul E. McKenney]

On Sun, Sep 27, 2020 at 06:55:19PM -0400, Joel Fernandes wrote:
> On Sun, Sep 27, 2020 at 03:00:29PM +0200, Julia Lawall wrote:
> > From: kernel test robot <lkp@intel.com>
> > 
> > NULL check before kfree is not needed.
> > 
> > Generated by: scripts/coccinelle/free/ifnullfree.cocci
> > 
> > Fixes: e9bed2a1239b ("kvfree_rcu(): Switch to kmalloc() and kfree() for allocations")
> > Signed-off-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> > ---
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git urezki-pcount.2020.09.26a
> > head:   1a8eee1cc5b0e59c17f5d94c5871e6c70c4a43a1
> > commit: e9bed2a1239b017d78cec5de66adce0560f6d077 [17/18] kvfree_rcu(): Switch to kmalloc() and kfree() for allocations
> > :::::: branch date: 4 hours ago
> > :::::: commit date: 15 hours ago
> > 
> >  tree.c |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > --- a/kernel/rcu/tree.c
> > +++ b/kernel/rcu/tree.c
> > @@ -3165,8 +3165,7 @@ static void kfree_rcu_work(struct work_s
> >  				bkvhead[i] = NULL;
> >  			krc_this_cpu_unlock(krcp, flags);
> > 
> > -			if (bkvhead[i])
> > -				kfree(bkvhead[i]);
> > +			kfree(bkvhead[i]);
> > 
> 
> Acked-by: Joel Fernandes (Google) <joel@joelfernandes.org>

Applied and pushed, thank you both!

							Thanx, Paul

> thanks,
> 
>  - Joel
> 
> >  			cond_resched_tasks_rcu_qs();
> >  		}