* [PATCH] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1
@ 2020-09-28 15:00 Clément Péron
2020-09-30 10:27 ` Maxime Ripard
0 siblings, 1 reply; 3+ messages in thread
From: Clément Péron @ 2020-09-28 15:00 UTC (permalink / raw)
To: Maxime Ripard
Cc: Clément Péron, Rob Herring, Chen-Yu Tsai, devicetree,
linux-arm-kernel, linux-kernel
VQMMC supply is connected to BLDO2 which provides 1.8V.
Let's reflect this in the device-tree.
Fixes: 089bee8dd119 ("arm64: dts: allwinner: h6: Introduce Beelink GS1 board")
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
index 049c21718846..3f20d2c9bbbb 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
@@ -145,6 +145,7 @@ &mmc2 {
vqmmc-supply = <®_bldo2>;
non-removable;
cap-mmc-hw-reset;
+ mmc-hs200-1_8v;
bus-width = <8>;
status = "okay";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1
2020-09-28 15:00 [PATCH] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1 Clément Péron
@ 2020-09-30 10:27 ` Maxime Ripard
2020-10-02 15:40 ` Clément Péron
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2020-09-30 10:27 UTC (permalink / raw)
To: Clément Péron
Cc: Rob Herring, Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
Hi,
On Mon, Sep 28, 2020 at 05:00:37PM +0200, Clément Péron wrote:
> VQMMC supply is connected to BLDO2 which provides 1.8V.
>
> Let's reflect this in the device-tree.
This commit log doesn't really explain what is going on though?
> Fixes: 089bee8dd119 ("arm64: dts: allwinner: h6: Introduce Beelink GS1 board")
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> index 049c21718846..3f20d2c9bbbb 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> @@ -145,6 +145,7 @@ &mmc2 {
> vqmmc-supply = <®_bldo2>;
The Device Tree already expresses that the vqmmc supply is connected to
BLDO2 which provides 1.8V here (together with the reg_bldo2 node).
> non-removable;
> cap-mmc-hw-reset;
> + mmc-hs200-1_8v;
Whereas this indicates that the eMMC supports the HS200 MMC mode at 1.8V
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1
2020-09-30 10:27 ` Maxime Ripard
@ 2020-10-02 15:40 ` Clément Péron
0 siblings, 0 replies; 3+ messages in thread
From: Clément Péron @ 2020-10-02 15:40 UTC (permalink / raw)
To: Maxime Ripard
Cc: Rob Herring, Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel
Hi Maxime,
On Wed, 30 Sep 2020 at 12:27, Maxime Ripard <maxime@cerno.tech> wrote:
>
> Hi,
>
> On Mon, Sep 28, 2020 at 05:00:37PM +0200, Clément Péron wrote:
> > VQMMC supply is connected to BLDO2 which provides 1.8V.
> >
> > Let's reflect this in the device-tree.
>
> This commit log doesn't really explain what is going on though?
>
> > Fixes: 089bee8dd119 ("arm64: dts: allwinner: h6: Introduce Beelink GS1 board")
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > index 049c21718846..3f20d2c9bbbb 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > @@ -145,6 +145,7 @@ &mmc2 {
> > vqmmc-supply = <®_bldo2>;
>
> The Device Tree already expresses that the vqmmc supply is connected to
> BLDO2 which provides 1.8V here (together with the reg_bldo2 node).
>
> > non-removable;
> > cap-mmc-hw-reset;
> > + mmc-hs200-1_8v;
>
> Whereas this indicates that the eMMC supports the HS200 MMC mode at 1.8V
What about a comment like this:
Sunxi mmc driver can't distinguish at runtime what's the I/O voltage
for HS200 mode.
Add a property in the device-tree to notify mmc core about this configuration.
Regards,
Clement
>
> Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-02 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28 15:00 [PATCH] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1 Clément Péron
2020-09-30 10:27 ` Maxime Ripard
2020-10-02 15:40 ` Clément Péron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).