* [PATCH] MAINTAINERS: exclude char maintainers from things they do not maintain @ 2020-09-30 12:10 Greg Kroah-Hartman 2020-09-30 13:19 ` Arnd Bergmann 2020-09-30 13:36 ` Corey Minyard 0 siblings, 2 replies; 9+ messages in thread From: Greg Kroah-Hartman @ 2020-09-30 12:10 UTC (permalink / raw) To: linux-kernel; +Cc: Arnd Bergmann There are a number of subdirectories and files in drivers/char/ that have their own maintainers and developers and ways of getting patches to Linus. This includes random.c, IPMI, hardware random drivers, TPM drivers, and agp drivers. Instead of sending those patches to Arnd and myself, who can't do anything with them, send them to the proper developers instead. Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> diff --git a/MAINTAINERS b/MAINTAINERS index d6b9445649e5..a6f0a3ec0047 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4101,6 +4101,11 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git F: drivers/char/ F: drivers/misc/ F: include/linux/miscdevice.h +X: drivers/char/agp/ +X: drivers/char/hw_random/ +X: drivers/char/ipmi/ +X: drivers/char/random.c +X: drivers/char/tpm/ CHECKPATCH M: Andy Whitcroft <apw@canonical.com> ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: exclude char maintainers from things they do not maintain 2020-09-30 12:10 [PATCH] MAINTAINERS: exclude char maintainers from things they do not maintain Greg Kroah-Hartman @ 2020-09-30 13:19 ` Arnd Bergmann 2020-09-30 16:28 ` Greg Kroah-Hartman 2020-09-30 13:36 ` Corey Minyard 1 sibling, 1 reply; 9+ messages in thread From: Arnd Bergmann @ 2020-09-30 13:19 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: linux-kernel On Wed, Sep 30, 2020 at 2:10 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > There are a number of subdirectories and files in drivers/char/ that > have their own maintainers and developers and ways of getting patches to > Linus. This includes random.c, IPMI, hardware random drivers, TPM > drivers, and agp drivers. Instead of sending those patches to Arnd and > myself, who can't do anything with them, send them to the proper > developers instead. > > Cc: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Good idea, Acked-by: Arnd Bergmann <arnd@arndb.de> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: exclude char maintainers from things they do not maintain 2020-09-30 13:19 ` Arnd Bergmann @ 2020-09-30 16:28 ` Greg Kroah-Hartman 0 siblings, 0 replies; 9+ messages in thread From: Greg Kroah-Hartman @ 2020-09-30 16:28 UTC (permalink / raw) To: Arnd Bergmann; +Cc: linux-kernel On Wed, Sep 30, 2020 at 03:19:09PM +0200, Arnd Bergmann wrote: > On Wed, Sep 30, 2020 at 2:10 PM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > There are a number of subdirectories and files in drivers/char/ that > > have their own maintainers and developers and ways of getting patches to > > Linus. This includes random.c, IPMI, hardware random drivers, TPM > > drivers, and agp drivers. Instead of sending those patches to Arnd and > > myself, who can't do anything with them, send them to the proper > > developers instead. > > > > Cc: Arnd Bergmann <arnd@arndb.de> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Good idea, > > Acked-by: Arnd Bergmann <arnd@arndb.de> Now our inboxes will be a tiny bit smaller :) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: exclude char maintainers from things they do not maintain 2020-09-30 12:10 [PATCH] MAINTAINERS: exclude char maintainers from things they do not maintain Greg Kroah-Hartman 2020-09-30 13:19 ` Arnd Bergmann @ 2020-09-30 13:36 ` Corey Minyard 2020-09-30 16:28 ` Greg Kroah-Hartman 1 sibling, 1 reply; 9+ messages in thread From: Corey Minyard @ 2020-09-30 13:36 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: linux-kernel, Arnd Bergmann On Wed, Sep 30, 2020 at 02:10:07PM +0200, Greg Kroah-Hartman wrote: > There are a number of subdirectories and files in drivers/char/ that > have their own maintainers and developers and ways of getting patches to > Linus. This includes random.c, IPMI, hardware random drivers, TPM > drivers, and agp drivers. Instead of sending those patches to Arnd and > myself, who can't do anything with them, send them to the proper > developers instead. > > Cc: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Yes, please do. No reason for you to get all the noise from these. Acked-by: Corey Minyard <cminyard@mvista.com> > > diff --git a/MAINTAINERS b/MAINTAINERS > index d6b9445649e5..a6f0a3ec0047 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4101,6 +4101,11 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > F: drivers/char/ > F: drivers/misc/ > F: include/linux/miscdevice.h > +X: drivers/char/agp/ > +X: drivers/char/hw_random/ > +X: drivers/char/ipmi/ > +X: drivers/char/random.c > +X: drivers/char/tpm/ > > CHECKPATCH > M: Andy Whitcroft <apw@canonical.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: exclude char maintainers from things they do not maintain 2020-09-30 13:36 ` Corey Minyard @ 2020-09-30 16:28 ` Greg Kroah-Hartman 2020-09-30 20:02 ` Joe Perches 0 siblings, 1 reply; 9+ messages in thread From: Greg Kroah-Hartman @ 2020-09-30 16:28 UTC (permalink / raw) To: Corey Minyard; +Cc: linux-kernel, Arnd Bergmann On Wed, Sep 30, 2020 at 08:36:56AM -0500, Corey Minyard wrote: > On Wed, Sep 30, 2020 at 02:10:07PM +0200, Greg Kroah-Hartman wrote: > > There are a number of subdirectories and files in drivers/char/ that > > have their own maintainers and developers and ways of getting patches to > > Linus. This includes random.c, IPMI, hardware random drivers, TPM > > drivers, and agp drivers. Instead of sending those patches to Arnd and > > myself, who can't do anything with them, send them to the proper > > developers instead. > > > > Cc: Arnd Bergmann <arnd@arndb.de> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Yes, please do. No reason for you to get all the noise from these. > > Acked-by: Corey Minyard <cminyard@mvista.com> Thanks! greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: exclude char maintainers from things they do not maintain 2020-09-30 16:28 ` Greg Kroah-Hartman @ 2020-09-30 20:02 ` Joe Perches 2020-10-01 6:29 ` Greg Kroah-Hartman 0 siblings, 1 reply; 9+ messages in thread From: Joe Perches @ 2020-09-30 20:02 UTC (permalink / raw) To: Greg Kroah-Hartman, Corey Minyard; +Cc: linux-kernel, Arnd Bergmann On Wed, 2020-09-30 at 18:28 +0200, Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 08:36:56AM -0500, Corey Minyard wrote: > > On Wed, Sep 30, 2020 at 02:10:07PM +0200, Greg Kroah-Hartman wrote: > > > There are a number of subdirectories and files in drivers/char/ that > > > have their own maintainers and developers and ways of getting patches to > > > Linus. This includes random.c, IPMI, hardware random drivers, TPM > > > drivers, and agp drivers. Instead of sending those patches to Arnd and > > > myself, who can't do anything with them, send them to the proper > > > developers instead. > > > > > > Cc: Arnd Bergmann <arnd@arndb.de> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > Yes, please do. No reason for you to get all the noise from these. > > > > Acked-by: Corey Minyard <cminyard@mvista.com> > > Thanks! > > greg k-h Your exclusion list is: +X: drivers/char/agp/ +X: drivers/char/hw_random/ +X: drivers/char/ipmi/ +X: drivers/char/random.c +X: drivers/char/tpm/ But the current subdirectories of drivers/char are: drivers/char/agp drivers/char/hw_random drivers/char/ipmi drivers/char/mwave drivers/char/pcmcia drivers/char/tpm drivers/char/tpm/eventlog drivers/char/tpm/st33zp24 drivers/char/xilinx_hwicap drivers/char/xillybus do you want to specifically maintain any of them? Wouldn't it be easier to add a single subdirectory exclusion and add specific inclusions for subdirectories you actually do want to maintain> X: drivers/char/*/ F: drivers/char/<whatever> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: exclude char maintainers from things they do not maintain 2020-09-30 20:02 ` Joe Perches @ 2020-10-01 6:29 ` Greg Kroah-Hartman 2020-10-01 6:41 ` Joe Perches 0 siblings, 1 reply; 9+ messages in thread From: Greg Kroah-Hartman @ 2020-10-01 6:29 UTC (permalink / raw) To: Joe Perches; +Cc: Corey Minyard, linux-kernel, Arnd Bergmann On Wed, Sep 30, 2020 at 01:02:46PM -0700, Joe Perches wrote: > On Wed, 2020-09-30 at 18:28 +0200, Greg Kroah-Hartman wrote: > > On Wed, Sep 30, 2020 at 08:36:56AM -0500, Corey Minyard wrote: > > > On Wed, Sep 30, 2020 at 02:10:07PM +0200, Greg Kroah-Hartman wrote: > > > > There are a number of subdirectories and files in drivers/char/ that > > > > have their own maintainers and developers and ways of getting patches to > > > > Linus. This includes random.c, IPMI, hardware random drivers, TPM > > > > drivers, and agp drivers. Instead of sending those patches to Arnd and > > > > myself, who can't do anything with them, send them to the proper > > > > developers instead. > > > > > > > > Cc: Arnd Bergmann <arnd@arndb.de> > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > > Yes, please do. No reason for you to get all the noise from these. > > > > > > Acked-by: Corey Minyard <cminyard@mvista.com> > > > > Thanks! > > > > greg k-h > > Your exclusion list is: > > +X: drivers/char/agp/ > +X: drivers/char/hw_random/ > +X: drivers/char/ipmi/ > +X: drivers/char/random.c > +X: drivers/char/tpm/ > > But the current subdirectories of drivers/char are: > > drivers/char/agp > drivers/char/hw_random > drivers/char/ipmi > drivers/char/mwave > drivers/char/pcmcia > drivers/char/tpm > drivers/char/tpm/eventlog > drivers/char/tpm/st33zp24 > drivers/char/xilinx_hwicap > drivers/char/xillybus > > do you want to specifically maintain any of them? Yes, the other ones we do maintain. > Wouldn't it be easier to add a single subdirectory exclusion > and add specific inclusions for subdirectories you actually > do want to maintain> > > > X: drivers/char/*/ > F: drivers/char/<whatever> If we do that, it will be one extra line in the MAINTAINERS file, as we are dealing with 4 we want, and 4 we don't :) I like being explicit as to what we do NOT want to review, it's easier to see when glancing at the file. thanks, greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: exclude char maintainers from things they do not maintain 2020-10-01 6:29 ` Greg Kroah-Hartman @ 2020-10-01 6:41 ` Joe Perches 2020-10-01 11:38 ` Greg Kroah-Hartman 0 siblings, 1 reply; 9+ messages in thread From: Joe Perches @ 2020-10-01 6:41 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Corey Minyard, linux-kernel, Arnd Bergmann On Thu, 2020-10-01 at 08:29 +0200, Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 01:02:46PM -0700, Joe Perches wrote: > > On Wed, 2020-09-30 at 18:28 +0200, Greg Kroah-Hartman wrote: > > > On Wed, Sep 30, 2020 at 08:36:56AM -0500, Corey Minyard wrote: > > > > On Wed, Sep 30, 2020 at 02:10:07PM +0200, Greg Kroah-Hartman wrote: > > > > > There are a number of subdirectories and files in drivers/char/ that > > > > > have their own maintainers and developers and ways of getting patches to > > > > > Linus. This includes random.c, IPMI, hardware random drivers, TPM > > > > > drivers, and agp drivers. Instead of sending those patches to Arnd and > > > > > myself, who can't do anything with them, send them to the proper > > > > > developers instead. [] > > Your exclusion list is: > > > > +X: drivers/char/agp/ > > +X: drivers/char/hw_random/ > > +X: drivers/char/ipmi/ > > +X: drivers/char/random.c > > +X: drivers/char/tpm/ > > > > But the current subdirectories of drivers/char are: > > > > drivers/char/agp > > drivers/char/hw_random > > drivers/char/ipmi > > drivers/char/mwave > > drivers/char/pcmcia > > drivers/char/tpm > > drivers/char/tpm/eventlog > > drivers/char/tpm/st33zp24 > > drivers/char/xilinx_hwicap > > drivers/char/xillybus > > > > do you want to specifically maintain any of them? > > Yes, the other ones we do maintain. > > > Wouldn't it be easier to add a single subdirectory exclusion > > and add specific inclusions for subdirectories you actually > > do want to maintain> > > > > > > X: drivers/char/*/ > > F: drivers/char/<whatever> > > If we do that, it will be one extra line in the MAINTAINERS file, as we > are dealing with 4 we want, and 4 we don't :) > > I like being explicit as to what we do NOT want to review, it's easier > to see when glancing at the file. No worries, it just wasn't obvious that all the other directories were ones you actually want to maintain. btw: xillybus nominally has its own maintainer too. XILLYBUS DRIVER M: Eli Billauer <eli.billauer@gmail.com> L: linux-kernel@vger.kernel.org S: Supported F: drivers/char/xillybus/ cheers, Joe ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: exclude char maintainers from things they do not maintain 2020-10-01 6:41 ` Joe Perches @ 2020-10-01 11:38 ` Greg Kroah-Hartman 0 siblings, 0 replies; 9+ messages in thread From: Greg Kroah-Hartman @ 2020-10-01 11:38 UTC (permalink / raw) To: Joe Perches; +Cc: Corey Minyard, linux-kernel, Arnd Bergmann On Wed, Sep 30, 2020 at 11:41:10PM -0700, Joe Perches wrote: > On Thu, 2020-10-01 at 08:29 +0200, Greg Kroah-Hartman wrote: > > On Wed, Sep 30, 2020 at 01:02:46PM -0700, Joe Perches wrote: > > > On Wed, 2020-09-30 at 18:28 +0200, Greg Kroah-Hartman wrote: > > > > On Wed, Sep 30, 2020 at 08:36:56AM -0500, Corey Minyard wrote: > > > > > On Wed, Sep 30, 2020 at 02:10:07PM +0200, Greg Kroah-Hartman wrote: > > > > > > There are a number of subdirectories and files in drivers/char/ that > > > > > > have their own maintainers and developers and ways of getting patches to > > > > > > Linus. This includes random.c, IPMI, hardware random drivers, TPM > > > > > > drivers, and agp drivers. Instead of sending those patches to Arnd and > > > > > > myself, who can't do anything with them, send them to the proper > > > > > > developers instead. > [] > > > Your exclusion list is: > > > > > > +X: drivers/char/agp/ > > > +X: drivers/char/hw_random/ > > > +X: drivers/char/ipmi/ > > > +X: drivers/char/random.c > > > +X: drivers/char/tpm/ > > > > > > But the current subdirectories of drivers/char are: > > > > > > drivers/char/agp > > > drivers/char/hw_random > > > drivers/char/ipmi > > > drivers/char/mwave > > > drivers/char/pcmcia > > > drivers/char/tpm > > > drivers/char/tpm/eventlog > > > drivers/char/tpm/st33zp24 > > > drivers/char/xilinx_hwicap > > > drivers/char/xillybus > > > > > > do you want to specifically maintain any of them? > > > > Yes, the other ones we do maintain. > > > > > Wouldn't it be easier to add a single subdirectory exclusion > > > and add specific inclusions for subdirectories you actually > > > do want to maintain> > > > > > > > > > X: drivers/char/*/ > > > F: drivers/char/<whatever> > > > > If we do that, it will be one extra line in the MAINTAINERS file, as we > > are dealing with 4 we want, and 4 we don't :) > > > > I like being explicit as to what we do NOT want to review, it's easier > > to see when glancing at the file. > > No worries, it just wasn't obvious that all the other > directories were ones you actually want to maintain. Someone has to :) > btw: xillybus nominally has its own maintainer too. > > XILLYBUS DRIVER > M: Eli Billauer <eli.billauer@gmail.com> > L: linux-kernel@vger.kernel.org > S: Supported > F: drivers/char/xillybus/ I end up usually taking the patches from here so leaving it as part of the "umbrella" for char/misc patches is fine. thanks, greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-10-01 11:38 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-09-30 12:10 [PATCH] MAINTAINERS: exclude char maintainers from things they do not maintain Greg Kroah-Hartman 2020-09-30 13:19 ` Arnd Bergmann 2020-09-30 16:28 ` Greg Kroah-Hartman 2020-09-30 13:36 ` Corey Minyard 2020-09-30 16:28 ` Greg Kroah-Hartman 2020-09-30 20:02 ` Joe Perches 2020-10-01 6:29 ` Greg Kroah-Hartman 2020-10-01 6:41 ` Joe Perches 2020-10-01 11:38 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).