* [RESEND PATCH v3] arm64: dts: renesas: align GPIO hog names with dtschema
@ 2020-10-02 16:39 Krzysztof Kozlowski
2020-10-05 7:53 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-02 16:39 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring, linux-renesas-soc,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The convention for node names is to use hyphens, not underscores.
dtschema for pca95xx expects GPIO hogs to end with 'hog' suffix.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
.../boot/dts/renesas/r8a77951-salvator-xs.dts | 2 +-
.../boot/dts/renesas/r8a77965-salvator-xs.dts | 2 +-
arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 14 +++++++-------
3 files changed, 9 insertions(+), 9 deletions(-)
The dt-schema changes were applied.
diff --git a/arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dts
index cef9da4376a3..e5922329a4b8 100644
--- a/arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dts
@@ -118,7 +118,7 @@
};
&pca9654 {
- pcie_sata_switch {
+ pcie-sata-switch-hog {
gpio-hog;
gpios = <7 GPIO_ACTIVE_HIGH>;
output-low; /* enable SATA by default */
diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
index 5cef64605464..d7e621101af7 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
@@ -55,7 +55,7 @@
};
&pca9654 {
- pcie_sata_switch {
+ pcie-sata-switch-hog {
gpio-hog;
gpios = <7 GPIO_ACTIVE_HIGH>;
output-low; /* enable SATA by default */
diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 202177706cde..e9ed2597f1c2 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -143,49 +143,49 @@
interrupt-parent = <&gpio6>;
interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
- audio_out_off {
+ audio-out-off-hog {
gpio-hog;
gpios = <0 GPIO_ACTIVE_HIGH>; /* P00 */
output-high;
line-name = "Audio_Out_OFF";
};
- hub_pwen {
+ hub-pwen-hog {
gpio-hog;
gpios = <6 GPIO_ACTIVE_HIGH>;
output-high;
line-name = "HUB pwen";
};
- hub_rst {
+ hub-rst-hog {
gpio-hog;
gpios = <7 GPIO_ACTIVE_HIGH>;
output-high;
line-name = "HUB rst";
};
- otg_extlpn {
+ otg-extlpn-hog {
gpio-hog;
gpios = <9 GPIO_ACTIVE_HIGH>;
output-high;
line-name = "OTG EXTLPn";
};
- otg_offvbusn {
+ otg-offvbusn-hog {
gpio-hog;
gpios = <8 GPIO_ACTIVE_HIGH>;
output-low;
line-name = "OTG OFFVBUSn";
};
- sd-wifi-mux {
+ sd-wifi-mux-hog {
gpio-hog;
gpios = <5 GPIO_ACTIVE_HIGH>;
output-low; /* Connect WL1837 */
line-name = "SD WiFi mux";
};
- snd_rst {
+ snd-rst-hog {
gpio-hog;
gpios = <15 GPIO_ACTIVE_HIGH>; /* P17 */
output-high;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH v3] arm64: dts: renesas: align GPIO hog names with dtschema
2020-10-02 16:39 [RESEND PATCH v3] arm64: dts: renesas: align GPIO hog names with dtschema Krzysztof Kozlowski
@ 2020-10-05 7:53 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-10-05 7:53 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Magnus Damm, Rob Herring, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
On Fri, Oct 2, 2020 at 6:39 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> The convention for node names is to use hyphens, not underscores.
> dtschema for pca95xx expects GPIO hogs to end with 'hog' suffix.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> .../boot/dts/renesas/r8a77951-salvator-xs.dts | 2 +-
> .../boot/dts/renesas/r8a77965-salvator-xs.dts | 2 +-
> arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 14 +++++++-------
> 3 files changed, 9 insertions(+), 9 deletions(-)
>
> The dt-schema changes were applied.
Thanks for notifying me!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.11.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-05 7:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02 16:39 [RESEND PATCH v3] arm64: dts: renesas: align GPIO hog names with dtschema Krzysztof Kozlowski
2020-10-05 7:53 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).