From: David Miller <davem@davemloft.net>
To: weifeng.voon@intel.com
Cc: mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, joabreu@synopsys.com,
peppe.cavallaro@st.com, andrew@lunn.ch, alexandre.torgue@st.com,
boon.leong.ong@intel.com, chen.yong.seow@intel.com,
mgross@linux.intel.com, vee.khee.wong@intel.com
Subject: Re: [PATCH v2 net] net: stmmac: Modify configuration method of EEE timers
Date: Sat, 03 Oct 2020 16:42:40 -0700 (PDT) [thread overview]
Message-ID: <20201003.164240.1313265831717025751.davem@davemloft.net> (raw)
In-Reply-To: <20201001155609.5372-1-weifeng.voon@intel.com>
From: Voon Weifeng <weifeng.voon@intel.com>
Date: Thu, 1 Oct 2020 23:56:09 +0800
> From: "Vineetha G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com>
>
> Ethtool manual stated that the tx-timer is the "the amount of time the
> device should stay in idle mode prior to asserting its Tx LPI". The
> previous implementation for "ethtool --set-eee tx-timer" sets the LPI TW
> timer duration which is not correct. Hence, this patch fixes the
> "ethtool --set-eee tx-timer" to configure the EEE LPI timer.
>
> The LPI TW Timer will be using the defined default value instead of
> "ethtool --set-eee tx-timer" which follows the EEE LS timer implementation.
>
> Fixes: d765955d2ae0 ("stmmac: add the Energy Efficient Ethernet support")
> Signed-off-by: Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@intel.com>
> Signed-off-by: Voon Weifeng <weifeng.voon@intel.com>
>
> Changelog V2
> *Not removing/modifying the eee_timer.
> *EEE LPI timer can be configured through ethtool and also the eee_timer
> module param.
> *EEE TW Timer will be configured with default value only, not able to be
> configured through ethtool or module param. This follows the implementation
> of the EEE LS Timer.
Please put the Changelog above the various signoffs and other tags, as those
should be at the end of the commit log message.
Just out of curiousity, where did you see put the changelog after the
tags, and thus caused you to use this layout? If you decided that on
your own, this is pretty much always a bad idea. Look to other
patches which have been accepted as a guide for how to format your commit
log message.
Applied, thank you.
prev parent reply other threads:[~2020-10-03 23:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 15:56 [PATCH v2 net] net: stmmac: Modify configuration method of EEE timers Voon Weifeng
2020-10-03 23:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201003.164240.1313265831717025751.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=chen.yong.seow@intel.com \
--cc=joabreu@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mgross@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vee.khee.wong@intel.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).