* [PATCH] FIX the comment of struct jbd2_journal_handle
@ 2020-09-22 17:12 Hui Su
2020-09-23 10:35 ` Jan Kara
2020-10-03 4:59 ` Theodore Y. Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Hui Su @ 2020-09-22 17:12 UTC (permalink / raw)
To: tytso, jack, linux-ext4, linux-kernel
the struct name was modified long ago, but the comment still
use struct handle_s.
Signed-off-by: Hui Su <sh_def@163.com>
---
include/linux/jbd2.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index 08f904943ab2..a1ef05412acf 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -452,8 +452,8 @@ struct jbd2_inode {
struct jbd2_revoke_table_s;
/**
- * struct handle_s - The handle_s type is the concrete type associated with
- * handle_t.
+ * struct jbd2_journal_handle - The jbd2_journal_handle type is the concrete
+ * type associated with handle_t.
* @h_transaction: Which compound transaction is this update a part of?
* @h_journal: Which journal handle belongs to - used iff h_reserved set.
* @h_rsv_handle: Handle reserved for finishing the logical operation.
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] FIX the comment of struct jbd2_journal_handle
2020-09-22 17:12 [PATCH] FIX the comment of struct jbd2_journal_handle Hui Su
@ 2020-09-23 10:35 ` Jan Kara
2020-10-03 4:59 ` Theodore Y. Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2020-09-23 10:35 UTC (permalink / raw)
To: Hui Su; +Cc: tytso, jack, linux-ext4, linux-kernel
On Wed 23-09-20 01:12:31, Hui Su wrote:
> the struct name was modified long ago, but the comment still
> use struct handle_s.
>
> Signed-off-by: Hui Su <sh_def@163.com>
Thanks for the patch. It looks good to me. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> include/linux/jbd2.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 08f904943ab2..a1ef05412acf 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -452,8 +452,8 @@ struct jbd2_inode {
> struct jbd2_revoke_table_s;
>
> /**
> - * struct handle_s - The handle_s type is the concrete type associated with
> - * handle_t.
> + * struct jbd2_journal_handle - The jbd2_journal_handle type is the concrete
> + * type associated with handle_t.
> * @h_transaction: Which compound transaction is this update a part of?
> * @h_journal: Which journal handle belongs to - used iff h_reserved set.
> * @h_rsv_handle: Handle reserved for finishing the logical operation.
> --
> 2.25.1
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] FIX the comment of struct jbd2_journal_handle
2020-09-22 17:12 [PATCH] FIX the comment of struct jbd2_journal_handle Hui Su
2020-09-23 10:35 ` Jan Kara
@ 2020-10-03 4:59 ` Theodore Y. Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Y. Ts'o @ 2020-10-03 4:59 UTC (permalink / raw)
To: Hui Su; +Cc: jack, linux-ext4, linux-kernel
On Wed, Sep 23, 2020 at 01:12:31AM +0800, Hui Su wrote:
> the struct name was modified long ago, but the comment still
> use struct handle_s.
>
> Signed-off-by: Hui Su <sh_def@163.com>
Tnanks, applied. I updated the commit summary to be:
jbd2: fix the comment of struct jbd2_journal_handle
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-03 4:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22 17:12 [PATCH] FIX the comment of struct jbd2_journal_handle Hui Su
2020-09-23 10:35 ` Jan Kara
2020-10-03 4:59 ` Theodore Y. Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).