[PATCH v2] USB: serial: option: Add Telit FT980-KS composition

[PATCH v2] USB: serial: option: Add Telit FT980-KS composition

[Leonid Bloch]

This commit adds the following Telit FT980-KS composition:

0x1054: rndis, diag, adb, nmea, modem, modem, aux

AT commands can be sent to /dev/ttyUSB2.

Signed-off-by: Leonid Bloch <lb.workbox@gmail.com>
---

The full composition is not tested, and it is the default one according
to Telit support. What is tested, is that this commit makes
/dev/ttyUSB{0..4} appear upon connecting the FT980-KS, and allows
sending AT commands to /dev/ttyUSB2.

Changes since v1:

* Interface #3 (ADB) is blacklisted.
* NCTRL flag is set to the diag interface.

These changes (relative to v1) also allow ModemManager to recognize the
device.

 drivers/usb/serial/option.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 0c6f160a214a..fe76710167f8 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1186,6 +1186,8 @@ static const struct usb_device_id option_ids[] = {
 	  .driver_info = NCTRL(2) | RSVD(3) },
 	{ USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1053, 0xff),	/* Telit FN980 (ECM) */
 	  .driver_info = NCTRL(0) | RSVD(1) },
+	{ USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1054, 0xff),	/* Telit FT980-KS */
+	  .driver_info = NCTRL(2) | RSVD(3) },
 	{ USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_ME910),
 	  .driver_info = NCTRL(0) | RSVD(1) | RSVD(3) },
 	{ USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_ME910_DUAL_MODEM),
-- 
2.28.0

Re: [PATCH v2] USB: serial: option: Add Telit FT980-KS composition

[Johan Hovold]

On Sun, Oct 04, 2020 at 06:58:13PM +0300, Leonid Bloch wrote:
> This commit adds the following Telit FT980-KS composition:
> 
> 0x1054: rndis, diag, adb, nmea, modem, modem, aux
> 
> AT commands can be sent to /dev/ttyUSB2.
> 
> Signed-off-by: Leonid Bloch <lb.workbox@gmail.com>
> ---
> 
> The full composition is not tested, and it is the default one according
> to Telit support. What is tested, is that this commit makes
> /dev/ttyUSB{0..4} appear upon connecting the FT980-KS, and allows
> sending AT commands to /dev/ttyUSB2.
> 
> Changes since v1:
> 
> * Interface #3 (ADB) is blacklisted.
> * NCTRL flag is set to the diag interface.
> 
> These changes (relative to v1) also allow ModemManager to recognize the
> device.

Now applied.

And thanks for reviewing, Lars.

Johan