From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Łukasz Stelmach" <l.stelmach@samsung.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Kukjin Kim" <kgene@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Andrew Lunn" <andrew@lunn.ch>,
jim.cromie@gmail.com, linux-arm-kernel@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
"Bartłomiej Żolnierkiewicz" <b.zolnierkie@samsung.com>,
"Marek Szyprowski" <m.szyprowski@samsung.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter
Date: Mon, 5 Oct 2020 09:03:59 -0500 [thread overview]
Message-ID: <20201005140359.GB92530@bogus> (raw)
In-Reply-To: <CAJKOXPeLiKQLSud4f9zxqBdR9a1sk04K56_=jtQr1FGxyDmDuQ@mail.gmail.com>
On Sat, Oct 03, 2020 at 12:09:55PM +0200, Krzysztof Kozlowski wrote:
> On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach <l.stelmach@samsung.com> wrote:
> >
> > Add bindings for AX88796C SPI Ethernet Adapter.
> >
> > Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> > ---
> > .../bindings/net/asix,ax88796c-spi.yaml | 76 +++++++++++++++++++
> > .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> > 2 files changed, 78 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c-spi.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/net/asix,ax88796c-spi.yaml b/Documentation/devicetree/bindings/net/asix,ax88796c-spi.yaml
> > new file mode 100644
> > index 000000000000..50a488d59dbf
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/asix,ax88796c-spi.yaml
> > @@ -0,0 +1,76 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/asix,ax88796c-spi.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ASIX AX88796C SPI Ethernet Adapter
> > +
> > +allOf:
> > + - $ref: ethernet-controller.yaml#
>
> Order of top-level entries please:
> 1. id, schema
> 2. title
> 3. maintainers
> 4. description
> and then allOf. See example-schema.yaml.
>
> > +
> > +description: |
> > + ASIX AX88796C is an Ethernet controller with a built in PHY. This
> > + describes SPI mode of the chip.
> > +
> > + The node for this driver must be a child node of a SPI controller, hence
> > + all mandatory properties described in ../spi/spi-bus.txt must be specified.
Did you read spi-bus.txt?
> > +
> > +maintainers:
> > + - Łukasz Stelmach <l.stelmach@samsung.com>
> > +
> > +properties:
> > + compatible:
> > + const: asix,ax99796c-spi
'spi' is implied by the bus the device is on, so drop.
> > +
> > + reg:
> > + description:
> > + SPI device address.
>
> Skip description, it's trivial.
>
> > + maxItems: 1
> > +
> > + spi-max-frequency:
> > + maximum: 40000000
> > +
> > + interrupts:
> > + description:
> > + GPIO interrupt to which the chip is connected.
>
> Skip the description. It's trivial and might be not accurate (does not
> have to be a GPIO).
>
> > + maxItems: 1
> > +
> > + interrupt-parrent:
Typo. But you don't need to list interrupt-parent.
> > + description:
> > + A phandle of an interrupt controller.
>
> Skip description.
>
> > + maxItems: 1
> > +
> > + reset-gpios:
> > + description:
> > + A GPIO line handling reset of the chip. As the line is active low,
> > + it should be marked GPIO_ACTIVE_LOW.
> > + maxItems: 1
> > +
> > + local-mac-address: true
> > +
> > + mac-address: true
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - spi-max-frequency
> > + - interrupts
> > + - interrupt-parrent
> > + - reset-gpios
>
> Additional properties false.
>
> > +
> > +examples:
> > + # Artik5 eval board
> > + - |
> > + ax88796c@0 {
ethernet@0
> > + compatible = "asix,ax88796c";
> > + local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
> > + interrupt-parent = <&gpx2>;
> > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> > + spi-max-frequency = <40000000>;
> > + reg = <0x0>;
> > + reset-gpios = <&gpe0 2 GPIO_ACTIVE_LOW>;
> > + controller-data {
Not documented.
> > + samsung,spi-feedback-delay = <2>;
> > + };
> > + };
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index 2baee2c817c1..5ce5c4a43735 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -117,6 +117,8 @@ patternProperties:
> > description: Asahi Kasei Corp.
> > "^asc,.*":
> > description: All Sensors Corporation
> > + "^asix,.*":
> > + description: ASIX Electronics Corporation
>
> Separate patch please.
>
> Best regards,
> Krzysztof
>
> > "^aspeed,.*":
> > description: ASPEED Technology Inc.
> > "^asus,.*":
> > --
> > 2.26.2
> >
next prev parent reply other threads:[~2020-10-05 14:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201002192215eucas1p2c8f4a4bf8e411ed8ba75383fd58e85ac@eucas1p2.samsung.com>
2020-10-02 19:22 ` [PATCH v2 0/4] AX88796C SPI Ethernet Adapter Łukasz Stelmach
[not found] ` <CGME20201002192215eucas1p2c1d2baebfe2a9caa11d88175a2899fea@eucas1p2.samsung.com>
2020-10-02 19:22 ` [PATCH v2 1/4] dt-bindings: net: Add bindings for " Łukasz Stelmach
2020-10-03 10:09 ` Krzysztof Kozlowski
2020-10-05 14:03 ` Rob Herring [this message]
2020-10-05 13:59 ` Rob Herring
2020-10-05 14:01 ` Krzysztof Kozlowski
[not found] ` <CGME20201002192216eucas1p16f54584cf50fff56edc278102a66509e@eucas1p1.samsung.com>
2020-10-02 19:22 ` [PATCH v2 2/4] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver Łukasz Stelmach
2020-10-02 20:36 ` Andrew Lunn
[not found] ` <CGME20201013200453eucas1p1b77c93275b518422429ff1481f88a4be@eucas1p1.samsung.com>
2020-10-13 20:04 ` Lukasz Stelmach
2020-10-16 18:01 ` Andrew Lunn
[not found] ` <CGME20201016191905eucas1p235fb430a8f330a39e64f4fd6b81decb2@eucas1p2.samsung.com>
2020-10-16 19:18 ` Lukasz Stelmach
[not found] ` <CGME20201019125624eucas1p257a76c307adfb27202332658f93c9aba@eucas1p2.samsung.com>
2020-10-19 12:56 ` Lukasz Stelmach
2020-10-19 13:02 ` Andrew Lunn
2020-10-03 12:59 ` Heiner Kallweit
[not found] ` <CGME20201013200250eucas1p2445005531b86f246d7a14b7fc8016e80@eucas1p2.samsung.com>
2020-10-13 20:02 ` Lukasz Stelmach
[not found] ` <CGME20201002192216eucas1p16933608dcb0fb8ceee21caa3455cbaf1@eucas1p1.samsung.com>
2020-10-02 19:22 ` [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board Łukasz Stelmach
2020-10-03 10:13 ` Krzysztof Kozlowski
[not found] ` <CGME20201006100556eucas1p2b69f76968a7a5901b5e9c66338c388d4@eucas1p2.samsung.com>
2020-10-06 10:05 ` Lukasz Stelmach
2020-10-06 10:17 ` Krzysztof Kozlowski
[not found] ` <CGME20201006140300eucas1p2006a96630d4a825500e5fc72016cf9d7@eucas1p2.samsung.com>
2020-10-06 14:02 ` Lukasz Stelmach
[not found] ` <CGME20201002192217eucas1p2357f80b100fb130d1ef1ac281042ff7c@eucas1p2.samsung.com>
2020-10-02 19:22 ` [PATCH v2 4/4] ARM: defconfig: Enable ax88796c driver Łukasz Stelmach
2020-10-02 19:45 ` [PATCH v2 0/4] AX88796C SPI Ethernet Adapter Andrew Lunn
[not found] ` <CGME20201006083749eucas1p160a3bed4cdb67cc8e05ca4a57d8907ca@eucas1p1.samsung.com>
2020-10-06 8:37 ` Lukasz Stelmach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005140359.GB92530@bogus \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jim.cromie@gmail.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).