Re: [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board

From: Lukasz Stelmach <l.stelmach@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Kukjin Kim" <kgene@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Russell King" <linux@armlinux.org.uk>,
	"Andrew Lunn" <andrew@lunn.ch>,
	jim.cromie@gmail.com, linux-arm-kernel@lists.infradead.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	"Bartłomiej Żolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>
Subject: Re: [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board
Date: Tue, 06 Oct 2020 16:02:50 +0200	[thread overview]
Message-ID: <dleftjtuv7cv05.fsf%l.stelmach@samsung.com> (raw)
In-Reply-To: <CAJKOXPePumx3-v7Odp8Fv65gzXFZw+EkZCaX-YE-CYrrmyr-8g@mail.gmail.com> (Krzysztof Kozlowski's message of "Tue, 6 Oct 2020 12:17:02 +0200")

[-- Attachment #1: Type: text/plain, Size: 2319 bytes --]

It was <2020-10-06 wto 12:17>, when Krzysztof Kozlowski wrote:
> On Tue, 6 Oct 2020 at 12:06, Lukasz Stelmach <l.stelmach@samsung.com> wrote:
>> It was <2020-10-03 sob 12:13>, when Krzysztof Kozlowski wrote:
>>> On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach <l.stelmach@samsung.com> wrote:
>>>>
>>>> Add node for ax88796c ethernet chip.
>>>>
>>>> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
>>>> ---
>>>>  arch/arm/boot/dts/exynos3250-artik5-eval.dts | 21 ++++++++++++++++++++
>>>>  1 file changed, 21 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos3250-artik5-eval.dts b/arch/arm/boot/dts/exynos3250-artik5-eval.dts
>>>> index 20446a846a98..7f115c348a2a 100644
>>>> --- a/arch/arm/boot/dts/exynos3250-artik5-eval.dts
>>>> +++ b/arch/arm/boot/dts/exynos3250-artik5-eval.dts
>>>> @@ -37,3 +37,24 @@ &mshc_2 {
>>>>  &serial_2 {
>>>>         status = "okay";
>>>>  };
>>>> +
>>>> +&spi_0 {
>>>> +       status = "okay";
>>>> +       cs-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>, <0>;
>>>> +
>>>> +       assigned-clocks        = <&cmu CLK_MOUT_MPLL>, <&cmu CLK_DIV_MPLL_PRE>, <&cmu CLK_MOUT_SPI0>,    <&cmu CLK_DIV_SPI0>,  <&cmu CLK_DIV_SPI0_PRE>, <&cmu CLK_SCLK_SPI0>;
>>>
>>> No spaces before or after '='.
>>>
>>
>> You mean " = ", don't you?
>
> Ah, of course.
>
>>>> + assigned-clock-parents = <&cmu CLK_FOUT_MPLL>, <&cmu
>>>> CLK_MOUT_MPLL>, <&cmu CLK_DIV_MPLL_PRE>, <&cmu CLK_MOUT_SPI0>, <&cmu
>>>> CLK_DIV_SPI0>, <&cmu CLK_DIV_SPI0_PRE>;
>>>
>>> This line is still too long. Please wrap it at 80. Checkpatch should
>>> complain about it... so it seems you did not run it. Please fix all
>>> checkpatch issues.
>>
>> My idea was too keep assigned-clocks and assigned-clock-parrent lines
>> aligned, so it is clearly visible which parrent applies to which
>> clock. Is it inappropriate?
>
> The line gets too long and in the existing DTSes we wrapped item by
> item. Solution could be to add comments, e.g.:
> assigned-clock-parents = <&cmu CLK_FOUT_MPLL>,
>            <&cmu CLK_DIV_MPLL_PRE>, /* for: CLK_DIV_MPLL_PRE */
>            <&cmu CLK_MOUT_SPI0>, /* for: CLK_MOUT_SPI0 */
>
> but I am not sure if dtc allows such comments.

make dbts works fine. Changed.

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]