* [PATCH] kernel/sysctl.c: drop unneeded assignment in proc_do_large_bitmap()
@ 2020-10-05 20:37 Sudip Mukherjee
2020-10-05 21:05 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2020-10-05 20:37 UTC (permalink / raw)
To: Luis Chamberlain, Kees Cook, Iurii Zaikin
Cc: linux-kernel, linux-safety, linux-fsdevel, Sudip Mukherjee
The variable 'first' is assigned 0 inside the while loop in the if block
but it is not used in the if block and is only used in the else block.
So, remove the unneeded assignment.
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
---
The resultant binary stayed same after this change. Verified with
md5sum which remained same with and without this change.
$ md5sum kernel/sysctl.o
e9e97adbfd3f0b32f83dd35d100c0e4e kernel/sysctl.o
kernel/sysctl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index ce75c67572b9..b51ebfd1ba6e 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -1508,7 +1508,6 @@ int proc_do_large_bitmap(struct ctl_table *table, int write,
}
bitmap_set(tmp_bitmap, val_a, val_b - val_a + 1);
- first = 0;
proc_skip_char(&p, &left, '\n');
}
left += skipped;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kernel/sysctl.c: drop unneeded assignment in proc_do_large_bitmap()
2020-10-05 20:37 [PATCH] kernel/sysctl.c: drop unneeded assignment in proc_do_large_bitmap() Sudip Mukherjee
@ 2020-10-05 21:05 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2020-10-05 21:05 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Luis Chamberlain, Iurii Zaikin, linux-kernel, linux-safety,
linux-fsdevel
On Mon, Oct 05, 2020 at 09:37:49PM +0100, Sudip Mukherjee wrote:
> The variable 'first' is assigned 0 inside the while loop in the if block
> but it is not used in the if block and is only used in the else block.
> So, remove the unneeded assignment.
True, but in this case, please move the definition of "first" into the
else block so it in only in scope there.
Thanks!
-Kees
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
>
> The resultant binary stayed same after this change. Verified with
> md5sum which remained same with and without this change.
>
> $ md5sum kernel/sysctl.o
> e9e97adbfd3f0b32f83dd35d100c0e4e kernel/sysctl.o
>
> kernel/sysctl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index ce75c67572b9..b51ebfd1ba6e 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -1508,7 +1508,6 @@ int proc_do_large_bitmap(struct ctl_table *table, int write,
> }
>
> bitmap_set(tmp_bitmap, val_a, val_b - val_a + 1);
> - first = 0;
> proc_skip_char(&p, &left, '\n');
> }
> left += skipped;
> --
> 2.11.0
>
--
Kees Cook
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-05 21:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 20:37 [PATCH] kernel/sysctl.c: drop unneeded assignment in proc_do_large_bitmap() Sudip Mukherjee
2020-10-05 21:05 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).