linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pinctrl: visconti: PINCTRL_TMPV7700 should depend on ARCH_VISCONTI
@ 2020-10-05 12:50 Geert Uytterhoeven
  2020-10-05 21:39 ` Nobuhiro Iwamatsu
  2020-10-07  9:49 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-10-05 12:50 UTC (permalink / raw)
  To: Nobuhiro Iwamatsu, Linus Walleij
  Cc: Punit Agrawal, linux-gpio, linux-kernel, Geert Uytterhoeven

The Toshiba Visconti TMPV7700 series pin controller is only present on
Visconti SoCs.  Hence add a dependency on ARCH_VISCONTI, to prevent
asking the user about this driver when configuring a kernel without
Visconti platform support.

Fixes: a68a7844264e4fb9 ("pinctrl: visconti: Add Toshiba Visconti SoCs pinctrl support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/pinctrl/visconti/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/visconti/Kconfig b/drivers/pinctrl/visconti/Kconfig
index 198ec33189cc4706..42653fc60413d203 100644
--- a/drivers/pinctrl/visconti/Kconfig
+++ b/drivers/pinctrl/visconti/Kconfig
@@ -9,6 +9,6 @@ config PINCTRL_VISCONTI
 config PINCTRL_TMPV7700
 	bool "Toshiba Visconti TMPV7700 series pinctrl driver"
 	depends on OF
-	depends on ARM64 || COMPILE_TEST
+	depends on ARCH_VISCONTI || COMPILE_TEST
 	select PINCTRL_VISCONTI
-	default ARM64 && ARCH_VISCONTI
+	default ARCH_VISCONTI
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: visconti: PINCTRL_TMPV7700 should depend on ARCH_VISCONTI
  2020-10-05 12:50 [PATCH] pinctrl: visconti: PINCTRL_TMPV7700 should depend on ARCH_VISCONTI Geert Uytterhoeven
@ 2020-10-05 21:39 ` Nobuhiro Iwamatsu
  2020-10-07  9:49 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Nobuhiro Iwamatsu @ 2020-10-05 21:39 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Linus Walleij, Punit Agrawal, linux-gpio, linux-kernel

Hi Geert,

On Mon, Oct 05, 2020 at 02:50:49PM +0200, Geert Uytterhoeven wrote:
> The Toshiba Visconti TMPV7700 series pin controller is only present on
> Visconti SoCs.  Hence add a dependency on ARCH_VISCONTI, to prevent
> asking the user about this driver when configuring a kernel without
> Visconti platform support.
> 
> Fixes: a68a7844264e4fb9 ("pinctrl: visconti: Add Toshiba Visconti SoCs pinctrl support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks for your fixing.

Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Best regards,
  Nobuhiro

> ---
>  drivers/pinctrl/visconti/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/visconti/Kconfig b/drivers/pinctrl/visconti/Kconfig
> index 198ec33189cc4706..42653fc60413d203 100644
> --- a/drivers/pinctrl/visconti/Kconfig
> +++ b/drivers/pinctrl/visconti/Kconfig
> @@ -9,6 +9,6 @@ config PINCTRL_VISCONTI
>  config PINCTRL_TMPV7700
>  	bool "Toshiba Visconti TMPV7700 series pinctrl driver"
>  	depends on OF
> -	depends on ARM64 || COMPILE_TEST
> +	depends on ARCH_VISCONTI || COMPILE_TEST
>  	select PINCTRL_VISCONTI
> -	default ARM64 && ARCH_VISCONTI
> +	default ARCH_VISCONTI
> -- 
> 2.17.1
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: visconti: PINCTRL_TMPV7700 should depend on ARCH_VISCONTI
  2020-10-05 12:50 [PATCH] pinctrl: visconti: PINCTRL_TMPV7700 should depend on ARCH_VISCONTI Geert Uytterhoeven
  2020-10-05 21:39 ` Nobuhiro Iwamatsu
@ 2020-10-07  9:49 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-10-07  9:49 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Nobuhiro Iwamatsu, Punit Agrawal, open list:GPIO SUBSYSTEM, linux-kernel

On Mon, Oct 5, 2020 at 2:50 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:

> The Toshiba Visconti TMPV7700 series pin controller is only present on
> Visconti SoCs.  Hence add a dependency on ARCH_VISCONTI, to prevent
> asking the user about this driver when configuring a kernel without
> Visconti platform support.
>
> Fixes: a68a7844264e4fb9 ("pinctrl: visconti: Add Toshiba Visconti SoCs pinctrl support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Patch applied!

Thanks for fixing this Geert.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-07  9:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 12:50 [PATCH] pinctrl: visconti: PINCTRL_TMPV7700 should depend on ARCH_VISCONTI Geert Uytterhoeven
2020-10-05 21:39 ` Nobuhiro Iwamatsu
2020-10-07  9:49 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).