From: Christoph Hellwig <hch@lst.de>
To: David Miller <davem@davemloft.net>
Cc: hch@lst.de, viro@zeniv.linux.org.uk, kuba@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] fs: remove ->sendpage
Date: Tue, 6 Oct 2020 09:07:49 +0200 [thread overview]
Message-ID: <20201006070749.GA7713@lst.de> (raw)
In-Reply-To: <20200928.151734.25122613961401605.davem@davemloft.net>
On Mon, Sep 28, 2020 at 03:17:34PM -0700, David Miller wrote:
> From: Christoph Hellwig <hch@lst.de>
> Date: Sat, 26 Sep 2020 09:00:49 +0200
>
> > ->sendpage is only called from generic_splice_sendpage. The only user of
> > generic_splice_sendpage is socket_file_ops, which is also the only
> > instance that actually implements ->sendpage. Remove the ->sendpage file
> > operation and just open code the logic in the socket code.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Acked-by: David S. Miller <davem@davemloft.net>
Al, can you pick this up? Or give your ACK so that Dave can pick it up?
prev parent reply other threads:[~2020-10-06 7:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 7:00 [PATCH] fs: remove ->sendpage Christoph Hellwig
2020-09-28 22:17 ` David Miller
2020-10-06 7:07 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006070749.GA7713@lst.de \
--to=hch@lst.de \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).