* [PATCH] arm64: random: Remove no longer needed prototypes
@ 2020-10-06 19:44 Andre Przywara
2020-10-06 19:48 ` Mark Brown
2020-10-07 13:48 ` Will Deacon
0 siblings, 2 replies; 3+ messages in thread
From: Andre Przywara @ 2020-10-06 19:44 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: Mark Rutland, Mark Brown, Ard Biesheuvel, Richard Henderson,
linux-arm-kernel, linux-kernel, Guenter Roeck
Commit 9bceb80b3cc4 ("arm64: kaslr: Use standard early random
function") removed the direct calls of the __arm64_rndr() and
__early_cpu_has_rndr() functions, but left the dummy prototypes in the
#else branch of the #ifdef CONFIG_ARCH_RANDOM guard.
Remove the redundant prototypes, as they have no users outside of
this header file.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
arch/arm64/include/asm/archrandom.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm64/include/asm/archrandom.h b/arch/arm64/include/asm/archrandom.h
index 44209f6146aa..ffb1a40d5475 100644
--- a/arch/arm64/include/asm/archrandom.h
+++ b/arch/arm64/include/asm/archrandom.h
@@ -79,10 +79,5 @@ arch_get_random_seed_long_early(unsigned long *v)
}
#define arch_get_random_seed_long_early arch_get_random_seed_long_early
-#else
-
-static inline bool __arm64_rndr(unsigned long *v) { return false; }
-static inline bool __init __early_cpu_has_rndr(void) { return false; }
-
#endif /* CONFIG_ARCH_RANDOM */
#endif /* _ASM_ARCHRANDOM_H */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: random: Remove no longer needed prototypes
2020-10-06 19:44 [PATCH] arm64: random: Remove no longer needed prototypes Andre Przywara
@ 2020-10-06 19:48 ` Mark Brown
2020-10-07 13:48 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-10-06 19:48 UTC (permalink / raw)
To: Andre Przywara
Cc: Catalin Marinas, Will Deacon, Mark Rutland, Ard Biesheuvel,
Richard Henderson, linux-arm-kernel, linux-kernel, Guenter Roeck
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
On Tue, Oct 06, 2020 at 08:44:53PM +0100, Andre Przywara wrote:
> Commit 9bceb80b3cc4 ("arm64: kaslr: Use standard early random
> function") removed the direct calls of the __arm64_rndr() and
> __early_cpu_has_rndr() functions, but left the dummy prototypes in the
> #else branch of the #ifdef CONFIG_ARCH_RANDOM guard.
> Remove the redundant prototypes, as they have no users outside of
> this header file.
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: random: Remove no longer needed prototypes
2020-10-06 19:44 [PATCH] arm64: random: Remove no longer needed prototypes Andre Przywara
2020-10-06 19:48 ` Mark Brown
@ 2020-10-07 13:48 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2020-10-07 13:48 UTC (permalink / raw)
To: Andre Przywara, Catalin Marinas
Cc: kernel-team, Will Deacon, Guenter Roeck, Ard Biesheuvel,
Richard Henderson, linux-arm-kernel, linux-kernel, Mark Rutland,
Mark Brown
On Tue, 6 Oct 2020 20:44:53 +0100, Andre Przywara wrote:
> Commit 9bceb80b3cc4 ("arm64: kaslr: Use standard early random
> function") removed the direct calls of the __arm64_rndr() and
> __early_cpu_has_rndr() functions, but left the dummy prototypes in the
> #else branch of the #ifdef CONFIG_ARCH_RANDOM guard.
>
> Remove the redundant prototypes, as they have no users outside of
> this header file.
Applied to arm64 (for-next/late-arrivals), thanks!
[1/1] arm64: random: Remove no longer needed prototypes
https://git.kernel.org/arm64/c/d433ab42fdc2
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-07 13:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-06 19:44 [PATCH] arm64: random: Remove no longer needed prototypes Andre Przywara
2020-10-06 19:48 ` Mark Brown
2020-10-07 13:48 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).