* [PATCH] mm: fix some comments in page_alloc.c and mempolicy.c
@ 2020-09-25 16:06 Hui Su
2020-10-01 12:27 ` David Hildenbrand
0 siblings, 1 reply; 4+ messages in thread
From: Hui Su @ 2020-09-25 16:06 UTC (permalink / raw)
To: lizefan, tj, hannes, akpm, cgroups, linux-kernel, linux-mm
1. the cpuset.c has been moved from kernel/cpuset.c to
kernel/cgroup/cpuset.c long time ago, but the comment is stale,
so we update it.
2. get_page_from_freelist() may alloc many pages according to
order, we may use pages for better.
Signed-off-by: Hui Su <sh_def@163.com>
---
kernel/cgroup/cpuset.c | 2 +-
mm/mempolicy.c | 2 +-
mm/page_alloc.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 642415b8c3c9..1d3011c1aab6 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -1,5 +1,5 @@
/*
- * kernel/cpuset.c
+ * kernel/cgroup/cpuset.c
*
* Processor and Memory placement constraints for sets of tasks.
*
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index eddbe4e56c73..ac59b049b16c 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -2295,7 +2295,7 @@ int vma_dup_policy(struct vm_area_struct *src, struct vm_area_struct *dst)
* rebinds the mempolicy its copying by calling mpol_rebind_policy()
* with the mems_allowed returned by cpuset_mems_allowed(). This
* keeps mempolicies cpuset relative after its cpuset moves. See
- * further kernel/cpuset.c update_nodemask().
+ * further kernel/cgroup/cpuset.c update_nodemask().
*
* current's mempolicy may be rebinded by the other task(the task that changes
* cpuset's mems), so we needn't do rebind work for current task.
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index fab5e97dc9ca..1e3c7493e1cb 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3709,7 +3709,7 @@ static inline unsigned int current_alloc_flags(gfp_t gfp_mask,
/*
* get_page_from_freelist goes through the zonelist trying to allocate
- * a page.
+ * pages.
*/
static struct page *
get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
@@ -3723,7 +3723,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
retry:
/*
* Scan zonelist, looking for a zone with enough free.
- * See also __cpuset_node_allowed() comment in kernel/cpuset.c.
+ * See also __cpuset_node_allowed() comment in kernel/cgroup/cpuset.c.
*/
no_fallback = alloc_flags & ALLOC_NOFRAGMENT;
z = ac->preferred_zoneref;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: fix some comments in page_alloc.c and mempolicy.c
2020-09-25 16:06 [PATCH] mm: fix some comments in page_alloc.c and mempolicy.c Hui Su
@ 2020-10-01 12:27 ` David Hildenbrand
2020-10-01 16:17 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: David Hildenbrand @ 2020-10-01 12:27 UTC (permalink / raw)
To: Hui Su, lizefan, tj, hannes, akpm, cgroups, linux-kernel, linux-mm
On 25.09.20 18:06, Hui Su wrote:
> 1. the cpuset.c has been moved from kernel/cpuset.c to
> kernel/cgroup/cpuset.c long time ago, but the comment is stale,
> so we update it.
> 2. get_page_from_freelist() may alloc many pages according to
> order, we may use pages for better.
>
> Signed-off-by: Hui Su <sh_def@163.com>
> ---
> kernel/cgroup/cpuset.c | 2 +-
> mm/mempolicy.c | 2 +-
> mm/page_alloc.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index 642415b8c3c9..1d3011c1aab6 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -1,5 +1,5 @@
> /*
> - * kernel/cpuset.c
> + * kernel/cgroup/cpuset.c
> *
> * Processor and Memory placement constraints for sets of tasks.
> *
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index eddbe4e56c73..ac59b049b16c 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -2295,7 +2295,7 @@ int vma_dup_policy(struct vm_area_struct *src, struct vm_area_struct *dst)
> * rebinds the mempolicy its copying by calling mpol_rebind_policy()
> * with the mems_allowed returned by cpuset_mems_allowed(). This
> * keeps mempolicies cpuset relative after its cpuset moves. See
> - * further kernel/cpuset.c update_nodemask().
> + * further kernel/cgroup/cpuset.c update_nodemask().
> *
> * current's mempolicy may be rebinded by the other task(the task that changes
> * cpuset's mems), so we needn't do rebind work for current task.
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index fab5e97dc9ca..1e3c7493e1cb 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3709,7 +3709,7 @@ static inline unsigned int current_alloc_flags(gfp_t gfp_mask,
>
> /*
> * get_page_from_freelist goes through the zonelist trying to allocate
> - * a page.
> + * pages.
"a page" is correct here - it's a single page of the given order (which
might be composed out of various order-0 pages, but that's not the point).
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: fix some comments in page_alloc.c and mempolicy.c
2020-10-01 12:27 ` David Hildenbrand
@ 2020-10-01 16:17 ` Joe Perches
2020-10-08 12:33 ` Hui Su
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2020-10-01 16:17 UTC (permalink / raw)
To: David Hildenbrand, Hui Su, lizefan, tj, hannes, akpm, cgroups,
linux-kernel, linux-mm
On Thu, 2020-10-01 at 14:27 +0200, David Hildenbrand wrote:
> On 25.09.20 18:06, Hui Su wrote:
> > 1. the cpuset.c has been moved from kernel/cpuset.c to
> > kernel/cgroup/cpuset.c long time ago, but the comment is stale,
> > so we update it.
[]
> > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
[]
> > @@ -1,5 +1,5 @@
> > /*
> > - * kernel/cpuset.c
> > + * kernel/cgroup/cpuset.c
It's probably better to remove this altogether instead.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: fix some comments in page_alloc.c and mempolicy.c
2020-10-01 16:17 ` Joe Perches
@ 2020-10-08 12:33 ` Hui Su
0 siblings, 0 replies; 4+ messages in thread
From: Hui Su @ 2020-10-08 12:33 UTC (permalink / raw)
To: Joe Perches; +Cc: akpm, cgroups, linux-kernel, linux-mm
On Thu, Oct 01, 2020 at 09:17:29AM -0700, Joe Perches wrote:
> On Thu, 2020-10-01 at 14:27 +0200, David Hildenbrand wrote:
> > On 25.09.20 18:06, Hui Su wrote:
> > > 1. the cpuset.c has been moved from kernel/cpuset.c to
> > > kernel/cgroup/cpuset.c long time ago, but the comment is stale,
> > > so we update it.
> []
> > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> []
> > > @@ -1,5 +1,5 @@
> > > /*
> > > - * kernel/cpuset.c
> > > + * kernel/cgroup/cpuset.c
>
> It's probably better to remove this altogether instead.
Please ignore this change, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-08 12:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-25 16:06 [PATCH] mm: fix some comments in page_alloc.c and mempolicy.c Hui Su
2020-10-01 12:27 ` David Hildenbrand
2020-10-01 16:17 ` Joe Perches
2020-10-08 12:33 ` Hui Su
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).