* [for-next][PATCH] tracing: Fix synthetic print fmt check for use of __get_str()
@ 2020-10-08 19:18 Steven Rostedt
0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2020-10-08 19:18 UTC (permalink / raw)
To: LKML; +Cc: Ingo Molnar, Tom Zanussi, Colin Ian King
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
for-next
Head SHA1: 9d8739bc05f6d0f3ad21dc5d56f1edfbb9aa7585
Steven Rostedt (VMware) (1):
tracing: Fix synthetic print fmt check for use of __get_str()
----
kernel/trace/trace_events_synth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---------------------------
commit 9d8739bc05f6d0f3ad21dc5d56f1edfbb9aa7585
Author: Steven Rostedt (VMware) <rostedt@goodmis.org>
Date: Wed Oct 7 10:34:34 2020 -0400
tracing: Fix synthetic print fmt check for use of __get_str()
A cut and paste error had the check to use __get_str() test "is_dynamic"
twice, instead of checking "is_string && is_dynamic".
Link: https://lore.kernel.org/r/d34dccd5-96ba-a2d9-46ea-de8807525deb@canonical.com
Reported-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Tom Zanussi <zanussi@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c
index 742ce5f62d6d..3b2dcc42b8ee 100644
--- a/kernel/trace/trace_events_synth.c
+++ b/kernel/trace/trace_events_synth.c
@@ -491,7 +491,7 @@ static int __set_synth_event_print_fmt(struct synth_event *event,
pos += snprintf(buf + pos, LEN_OR_ZERO, "\"");
for (i = 0; i < event->n_fields; i++) {
- if (event->fields[i]->is_dynamic &&
+ if (event->fields[i]->is_string &&
event->fields[i]->is_dynamic)
pos += snprintf(buf + pos, LEN_OR_ZERO,
", __get_str(%s)", event->fields[i]->name);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-08 19:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-08 19:18 [for-next][PATCH] tracing: Fix synthetic print fmt check for use of __get_str() Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).