[PATCH] perf c2c: Update usage for showing memory events

[PATCH] perf c2c: Update usage for showing memory events

[Leo Yan]

Since commit b027cc6fdf1b ("perf c2c: Fix 'perf c2c record -e list' to
show the default events used"), "perf c2c" tool can show the memory
events properly, it's no reason to still suggest user to use the
command "perf mem record -e list" for showing events.

This patch updates the usage for showing memory events with command
"perf c2c record -e list".

Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
 tools/perf/builtin-c2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 5938b100eaf4..57bb6cce43e3 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -2916,7 +2916,7 @@ static int perf_c2c__record(int argc, const char **argv)
 	bool event_set = false;
 	struct option options[] = {
 	OPT_CALLBACK('e', "event", &event_set, "event",
-		     "event selector. Use 'perf mem record -e list' to list available events",
+		     "event selector. Use 'perf c2c record -e list' to list available events",
 		     parse_record_events),
 	OPT_BOOLEAN('u', "all-user", &all_user, "collect only user level data"),
 	OPT_BOOLEAN('k', "all-kernel", &all_kernel, "collect only kernel level data"),
-- 
2.17.1

Re: [PATCH] perf c2c: Update usage for showing memory events

[Jiri Olsa]

On Sun, Oct 11, 2020 at 08:10:22PM +0800, Leo Yan wrote:
> Since commit b027cc6fdf1b ("perf c2c: Fix 'perf c2c record -e list' to
> show the default events used"), "perf c2c" tool can show the memory
> events properly, it's no reason to still suggest user to use the
> command "perf mem record -e list" for showing events.
> 
> This patch updates the usage for showing memory events with command
> "perf c2c record -e list".
> 
> Signed-off-by: Leo Yan <leo.yan@linaro.org>

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

> ---
>  tools/perf/builtin-c2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 5938b100eaf4..57bb6cce43e3 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -2916,7 +2916,7 @@ static int perf_c2c__record(int argc, const char **argv)
>  	bool event_set = false;
>  	struct option options[] = {
>  	OPT_CALLBACK('e', "event", &event_set, "event",
> -		     "event selector. Use 'perf mem record -e list' to list available events",
> +		     "event selector. Use 'perf c2c record -e list' to list available events",
>  		     parse_record_events),
>  	OPT_BOOLEAN('u', "all-user", &all_user, "collect only user level data"),
>  	OPT_BOOLEAN('k', "all-kernel", &all_kernel, "collect only kernel level data"),
> -- 
> 2.17.1
> 

Re: [PATCH] perf c2c: Update usage for showing memory events

[Ian Rogers]

On Mon, Oct 12, 2020 at 2:13 AM Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Sun, Oct 11, 2020 at 08:10:22PM +0800, Leo Yan wrote:
> > Since commit b027cc6fdf1b ("perf c2c: Fix 'perf c2c record -e list' to
> > show the default events used"), "perf c2c" tool can show the memory
> > events properly, it's no reason to still suggest user to use the
> > command "perf mem record -e list" for showing events.
> >
> > This patch updates the usage for showing memory events with command
> > "perf c2c record -e list".
> >
> > Signed-off-by: Leo Yan <leo.yan@linaro.org>
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
>
> thanks,
> jirka

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> > ---
> >  tools/perf/builtin-c2c.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> > index 5938b100eaf4..57bb6cce43e3 100644
> > --- a/tools/perf/builtin-c2c.c
> > +++ b/tools/perf/builtin-c2c.c
> > @@ -2916,7 +2916,7 @@ static int perf_c2c__record(int argc, const char **argv)
> >       bool event_set = false;
> >       struct option options[] = {
> >       OPT_CALLBACK('e', "event", &event_set, "event",
> > -                  "event selector. Use 'perf mem record -e list' to list available events",
> > +                  "event selector. Use 'perf c2c record -e list' to list available events",
> >                    parse_record_events),
> >       OPT_BOOLEAN('u', "all-user", &all_user, "collect only user level data"),
> >       OPT_BOOLEAN('k', "all-kernel", &all_kernel, "collect only kernel level data"),
> > --
> > 2.17.1
> >
>

Re: [PATCH] perf c2c: Update usage for showing memory events

[Arnaldo Carvalho de Melo]

Em Mon, Oct 12, 2020 at 08:25:42AM -0700, Ian Rogers escreveu:
> On Mon, Oct 12, 2020 at 2:13 AM Jiri Olsa <jolsa@redhat.com> wrote:
> >
> > On Sun, Oct 11, 2020 at 08:10:22PM +0800, Leo Yan wrote:
> > > Since commit b027cc6fdf1b ("perf c2c: Fix 'perf c2c record -e list' to
> > > show the default events used"), "perf c2c" tool can show the memory
> > > events properly, it's no reason to still suggest user to use the
> > > command "perf mem record -e list" for showing events.
> > >
> > > This patch updates the usage for showing memory events with command
> > > "perf c2c record -e list".
> > >
> > > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> >
> > Acked-by: Jiri Olsa <jolsa@redhat.com>
> >
> > thanks,
> > jirka
> 
> Acked-by: Ian Rogers <irogers@google.com>


Thanks, applied.

- Arnaldo