From: kernel test robot <lkp@intel.com>
To: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
linux-kernel-mentees@lists.linuxfoundation.org,
Anant Thazhemadam <anant.thazhemadam@gmail.com>,
Oliver Neukum <oneukum@suse.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API
Date: Tue, 13 Oct 2020 08:14:46 +0800 [thread overview]
Message-ID: <202010130801.u1kkLpVa-lkp@intel.com> (raw)
In-Reply-To: <20201010065623.10189-1-anant.thazhemadam@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3599 bytes --]
Hi Anant,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.9 next-20201012]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Anant-Thazhemadam/net-usb-usbnet-update-__usbnet_-read-write-_cmd-to-use-new-API/20201010-145950
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 6f2f486d57c4d562cdf4932320b66fbb878ab1c4
config: x86_64-randconfig-a005-20201012 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 9e72d3eaf38f217698f72cb8fdc969a6e72dad3a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/77da62a1a1fcc73c3d8309c273dfd4d497918c6e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Anant-Thazhemadam/net-usb-usbnet-update-__usbnet_-read-write-_cmd-to-use-new-API/20201010-145950
git checkout 77da62a1a1fcc73c3d8309c273dfd4d497918c6e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/net/usb/usbnet.c:1990:9: error: implicit declaration of function 'usb_control_msg_recv' [-Werror,-Wimplicit-function-declaration]
return usb_control_msg_recv(dev->udev, 0,
^
drivers/net/usb/usbnet.c:1990:9: note: did you mean 'usb_control_msg'?
include/linux/usb.h:1794:12: note: 'usb_control_msg' declared here
extern int usb_control_msg(struct usb_device *dev, unsigned int pipe,
^
drivers/net/usb/usbnet.c:2008:9: error: implicit declaration of function 'usb_control_msg_send' [-Werror,-Wimplicit-function-declaration]
return usb_control_msg_send(dev->udev, 0,
^
drivers/net/usb/usbnet.c:2008:9: note: did you mean 'usb_control_msg'?
include/linux/usb.h:1794:12: note: 'usb_control_msg' declared here
extern int usb_control_msg(struct usb_device *dev, unsigned int pipe,
^
>> drivers/net/usb/usbnet.c:2010:26: error: use of undeclared identifier 'GPF_KERNEL'
USB_CTRL_SET_TIMEOUT, GPF_KERNEL);
^
3 errors generated.
vim +/GPF_KERNEL +2010 drivers/net/usb/usbnet.c
1994
1995 static int __usbnet_write_cmd(struct usbnet *dev, u8 cmd, u8 reqtype,
1996 u16 value, u16 index, const void *data,
1997 u16 size)
1998 {
1999 netdev_dbg(dev->net, "usbnet_write_cmd cmd=0x%02x reqtype=%02x"
2000 " value=0x%04x index=0x%04x size=%d\n",
2001 cmd, reqtype, value, index, size);
2002
2003 if (size && !data) {
2004 WARN_ON_ONCE(1);
2005 return -EINVAL;
2006 }
2007
2008 return usb_control_msg_send(dev->udev, 0,
2009 cmd, reqtype, value, index, data, size,
> 2010 USB_CTRL_SET_TIMEOUT, GPF_KERNEL);
2011 }
2012
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37241 bytes --]
next prev parent reply other threads:[~2020-10-13 2:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 6:56 [PATCH] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API Anant Thazhemadam
2020-10-10 17:03 ` Jakub Kicinski
2020-10-10 17:48 ` Anant Thazhemadam
2020-10-13 0:14 ` kernel test robot [this message]
2020-10-29 13:22 ` [PATCH v2] " Anant Thazhemadam
2020-10-29 15:16 ` Anant Thazhemadam
2020-10-29 16:30 ` Alan Stern
2020-10-31 21:11 ` Jakub Kicinski
2020-10-31 21:31 ` Anant Thazhemadam
2020-10-31 21:35 ` [PATCH v3] " Anant Thazhemadam
2020-11-02 9:40 ` Oliver Neukum
2020-11-02 16:40 ` Anant Thazhemadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010130801.u1kkLpVa-lkp@intel.com \
--to=lkp@intel.com \
--cc=anant.thazhemadam@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).