From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
Oliver Neukum <oneukum@suse.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API
Date: Sat, 10 Oct 2020 23:18:11 +0530 [thread overview]
Message-ID: <c7a7c934-1971-612e-a783-997a36bb69a3@gmail.com> (raw)
In-Reply-To: <20201010100346.158cbf62@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 10/10/20 10:33 pm, Jakub Kicinski wrote:
> On Sat, 10 Oct 2020 12:26:23 +0530 Anant Thazhemadam wrote:
>> GPF_KERNEL
> You haven't even built this, let alone tested :/
I'm really sorry about this.
Turns out, my .config wasn't set generated by make allyesconfig, and thus
this regression went undetected.
I can submit a v2 that doesn't break the build, and which is build tested
properly.
However, I'm not clear on how else I could locally run unit tests pertaining to this
patch. I understand the critical requirement for testing changes and would really
appreciate it if someone could direct me towards some resource or another that
could help me figure that out too.
Once again, I'm really sorry for this oversight.
Thank you for your time.
Thanks,
Anant
next prev parent reply other threads:[~2020-10-10 22:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 6:56 [PATCH] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API Anant Thazhemadam
2020-10-10 17:03 ` Jakub Kicinski
2020-10-10 17:48 ` Anant Thazhemadam [this message]
2020-10-13 0:14 ` kernel test robot
2020-10-29 13:22 ` [PATCH v2] " Anant Thazhemadam
2020-10-29 15:16 ` Anant Thazhemadam
2020-10-29 16:30 ` Alan Stern
2020-10-31 21:11 ` Jakub Kicinski
2020-10-31 21:31 ` Anant Thazhemadam
2020-10-31 21:35 ` [PATCH v3] " Anant Thazhemadam
2020-11-02 9:40 ` Oliver Neukum
2020-11-02 16:40 ` Anant Thazhemadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7a7c934-1971-612e-a783-997a36bb69a3@gmail.com \
--to=anant.thazhemadam@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).