[PATCH v2 0/4] ARM: stm32: add DT properties for remote proc synchronisation

[PATCH v2 0/4] ARM: stm32: add DT properties for remote proc synchronisation

[Arnaud Pouliquen]

This series implements the DT part associated to the commit 9276536f455b3
("remoteproc: stm32: Parse syscon that will manage M4 synchronisation")

Delta vs V1 [1]
- add Rob acked-by on patch 1/4
- simplify yaml descriptions and align other syscon descriptions

[1]https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=339339

Arnaud Pouliquen (4):
  dt-bindings: arm: stm32: Add compatible for syscon tamp node
  dt-bindings: remoteproc: stm32_rproc: update for firmware
    synchronization
  dt-bindings: remoteproc: stm32_rproc: update syscon descriptions
  ARM: dts: stm32: update stm32mp151 for remote proc synchronization
    support

 .../bindings/arm/stm32/st,stm32-syscon.yaml   |  1 +
 .../bindings/remoteproc/st,stm32-rproc.yaml   | 21 +++++++++++++------
 arch/arm/boot/dts/stm32mp151.dtsi             |  7 +++++++
 3 files changed, 23 insertions(+), 6 deletions(-)

-- 
2.17.1

[PATCH v2 1/4] dt-bindings: arm: stm32: Add compatible for syscon tamp node

[Arnaud Pouliquen]

Since commit ad440432d1f9 ("dt-bindings: mfd: Ensure 'syscon' has a
more specific compatible")
It is required to provide at least 2 compatibles string for syscon node.
This patch documents the new compatible for stm32 SoC to support
TAMP registers access.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
index 6f1cd0103c74..6634b3e0853e 100644
--- a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
@@ -19,6 +19,7 @@ properties:
               - st,stm32mp151-pwr-mcu
               - st,stm32-syscfg
               - st,stm32-power-config
+              - st,stm32-tamp
           - const: syscon
 
   reg:
-- 
2.17.1

[PATCH v2 2/4] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization

[Arnaud Pouliquen]

Add new properties description used to attach to a pre-loaded
firmware according to the commit 9276536f455b3
("remoteproc: stm32: Parse syscon that will manage M4 synchronisation")
which updates the driver part.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
---
 .../bindings/remoteproc/st,stm32-rproc.yaml       | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
index 4ffa25268fcc..3207942d51bf 100644
--- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
@@ -96,6 +96,19 @@ properties:
         3rd cell: register bitmask for the deep sleep bit
     maxItems: 1
 
+  st,syscfg-m4-state:
+    $ref: "/schemas/types.yaml#/definitions/phandle-array"
+    description: |
+      Reference to the tamp register which exposes the Cortex-M4 state.
+    maxItems: 1
+
+  st,syscfg-rsc-tbl:
+    $ref: "/schemas/types.yaml#/definitions/phandle-array"
+    description: |
+      Reference to the tamp register which references the Cortex-M4
+      resource table address.
+    maxItems: 1
+
   st,auto-boot:
     $ref: /schemas/types.yaml#/definitions/flag
     description:
@@ -122,6 +135,8 @@ examples:
       resets = <&rcc MCU_R>;
       st,syscfg-holdboot = <&rcc 0x10C 0x1>;
       st,syscfg-tz = <&rcc 0x000 0x1>;
+      st,syscfg-rsc-tbl = <&tamp 0x144 0xFFFFFFFF>;
+      st,syscfg-m4-state = <&tamp 0x148 0xFFFFFFFF>;
     };
 
 ...
-- 
2.17.1

Re: [PATCH v2 2/4] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization

[Rob Herring]

On Wed, 14 Oct 2020 14:54:39 +0200, Arnaud Pouliquen wrote:
> Add new properties description used to attach to a pre-loaded
> firmware according to the commit 9276536f455b3
> ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation")
> which updates the driver part.
> 
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> ---
>  .../bindings/remoteproc/st,stm32-rproc.yaml       | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

[PATCH v2 3/4] dt-bindings: remoteproc: stm32_rproc: update syscon descriptions

[Arnaud Pouliquen]

Align other syscon descriptions with st,syscfg-m4-state and
st,syscfg-rsc-tbl descriptions by suppressing the cells
description.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
---
 .../devicetree/bindings/remoteproc/st,stm32-rproc.yaml      | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
index 3207942d51bf..a1171dfba024 100644
--- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
@@ -38,9 +38,6 @@ properties:
   st,syscfg-tz:
     description:
       Reference to the system configuration which holds the RCC trust zone mode
-      - Phandle of syscon block.
-      - The offset of the RCC trust zone mode register.
-      - The field mask of the RCC trust zone mode.
     $ref: "/schemas/types.yaml#/definitions/phandle-array"
     maxItems: 1
 
@@ -91,9 +88,6 @@ properties:
     $ref: "/schemas/types.yaml#/definitions/phandle-array"
     description: |
       Reference to the system configuration which holds the remote
-        1st cell: phandle to syscon block
-        2nd cell: register offset containing the deep sleep setting
-        3rd cell: register bitmask for the deep sleep bit
     maxItems: 1
 
   st,syscfg-m4-state:
-- 
2.17.1

Re: [PATCH v2 3/4] dt-bindings: remoteproc: stm32_rproc: update syscon descriptions

[Rob Herring]

On Wed, 14 Oct 2020 14:54:40 +0200, Arnaud Pouliquen wrote:
> Align other syscon descriptions with st,syscfg-m4-state and
> st,syscfg-rsc-tbl descriptions by suppressing the cells
> description.
> 
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> ---
>  .../devicetree/bindings/remoteproc/st,stm32-rproc.yaml      | 6 ------
>  1 file changed, 6 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

[PATCH v2 4/4] ARM: dts: stm32: update stm32mp151 for remote proc synchronization support

[Arnaud Pouliquen]

Two backup registers are used to store the Cortex-M4 state and the resource
table address.
Declare the tamp node and add associated properties in m4_rproc node
to allow Linux to attach to a firmware loaded by the first boot stages.

Associated driver implementation is available in commit 9276536f455b3
("remoteproc: stm32: Parse syscon that will manage M4 synchronisation").

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
---
 arch/arm/boot/dts/stm32mp151.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
index bfe29023fbd5..842ecffae73a 100644
--- a/arch/arm/boot/dts/stm32mp151.dtsi
+++ b/arch/arm/boot/dts/stm32mp151.dtsi
@@ -1541,6 +1541,11 @@
 			status = "disabled";
 		};
 
+		tamp: tamp@5c00a000 {
+			compatible = "st,stm32-tamp", "syscon";
+			reg = <0x5c00a000 0x400>;
+		};
+
 		/*
 		 * Break node order to solve dependency probe issue between
 		 * pinctrl and exti.
@@ -1717,6 +1722,8 @@
 			st,syscfg-holdboot = <&rcc 0x10C 0x1>;
 			st,syscfg-tz = <&rcc 0x000 0x1>;
 			st,syscfg-pdds = <&pwr_mcu 0x0 0x1>;
+			st,syscfg-rsc-tbl = <&tamp 0x144 0xFFFFFFFF>;
+			st,syscfg-m4-state = <&tamp 0x148 0xFFFFFFFF>;
 			status = "disabled";
 		};
 	};
-- 
2.17.1

Re: [PATCH v2 4/4] ARM: dts: stm32: update stm32mp151 for remote proc synchronization support

[Mathieu Poirier]

On Wed, Oct 14, 2020 at 02:54:41PM +0200, Arnaud Pouliquen wrote:
> Two backup registers are used to store the Cortex-M4 state and the resource
> table address.
> Declare the tamp node and add associated properties in m4_rproc node
> to allow Linux to attach to a firmware loaded by the first boot stages.
> 
> Associated driver implementation is available in commit 9276536f455b3
> ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation").
> 
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> ---
>  arch/arm/boot/dts/stm32mp151.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
> index bfe29023fbd5..842ecffae73a 100644
> --- a/arch/arm/boot/dts/stm32mp151.dtsi
> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
> @@ -1541,6 +1541,11 @@
>  			status = "disabled";
>  		};
>  
> +		tamp: tamp@5c00a000 {
> +			compatible = "st,stm32-tamp", "syscon";
> +			reg = <0x5c00a000 0x400>;
> +		};
> +
>  		/*
>  		 * Break node order to solve dependency probe issue between
>  		 * pinctrl and exti.
> @@ -1717,6 +1722,8 @@
>  			st,syscfg-holdboot = <&rcc 0x10C 0x1>;
>  			st,syscfg-tz = <&rcc 0x000 0x1>;
>  			st,syscfg-pdds = <&pwr_mcu 0x0 0x1>;
> +			st,syscfg-rsc-tbl = <&tamp 0x144 0xFFFFFFFF>;
> +			st,syscfg-m4-state = <&tamp 0x148 0xFFFFFFFF>;

Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>

>  			status = "disabled";
>  		};
>  	};
> -- 
> 2.17.1
> 

Re: [PATCH v2 0/4] ARM: stm32: add DT properties for remote proc synchronisation

[Bjorn Andersson]

On Wed 14 Oct 07:54 CDT 2020, Arnaud Pouliquen wrote:

> This series implements the DT part associated to the commit 9276536f455b3
> ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation")
> 
> Delta vs V1 [1]
> - add Rob acked-by on patch 1/4
> - simplify yaml descriptions and align other syscon descriptions
> 
> [1]https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=339339
> 
> Arnaud Pouliquen (4):
>   dt-bindings: arm: stm32: Add compatible for syscon tamp node
>   dt-bindings: remoteproc: stm32_rproc: update for firmware
>     synchronization
>   dt-bindings: remoteproc: stm32_rproc: update syscon descriptions

Applied the dt-bindings updates, expecting the dts change to go throught
he ST soc tree.

Thank you,
Bjorn

>   ARM: dts: stm32: update stm32mp151 for remote proc synchronization
>     support
> 
>  .../bindings/arm/stm32/st,stm32-syscon.yaml   |  1 +
>  .../bindings/remoteproc/st,stm32-rproc.yaml   | 21 +++++++++++++------
>  arch/arm/boot/dts/stm32mp151.dtsi             |  7 +++++++
>  3 files changed, 23 insertions(+), 6 deletions(-)
> 
> -- 
> 2.17.1
> 

Re: [PATCH v2 0/4] ARM: stm32: add DT properties for remote proc synchronisation

[Alexandre Torgue]

Hi Arnaud

On 10/14/20 2:54 PM, Arnaud Pouliquen wrote:
> This series implements the DT part associated to the commit 9276536f455b3
> ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation")
> 
> Delta vs V1 [1]
> - add Rob acked-by on patch 1/4
> - simplify yaml descriptions and align other syscon descriptions
> 
> [1]https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=339339
> 
> Arnaud Pouliquen (4):
>    dt-bindings: arm: stm32: Add compatible for syscon tamp node
>    dt-bindings: remoteproc: stm32_rproc: update for firmware
>      synchronization
>    dt-bindings: remoteproc: stm32_rproc: update syscon descriptions
>    ARM: dts: stm32: update stm32mp151 for remote proc synchronization
>      support
> 
>   .../bindings/arm/stm32/st,stm32-syscon.yaml   |  1 +
>   .../bindings/remoteproc/st,stm32-rproc.yaml   | 21 +++++++++++++------
>   arch/arm/boot/dts/stm32mp151.dtsi             |  7 +++++++
>   3 files changed, 23 insertions(+), 6 deletions(-)
> 

DT patch applied on stm32-next.

regards
Alex