From: Peter Zijlstra <peterz@infradead.org>
To: qianjun.kernel@gmail.com
Cc: mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, linux-kernel@vger.kernel.org,
Yafang Shao <laoar.shao@gmail.com>
Subject: Re: [PATCH 1/1] Sched/fair: Improve the accuracy of sched_stat_wait statistics
Date: Thu, 15 Oct 2020 13:02:39 +0200 [thread overview]
Message-ID: <20201015110239.GD2611@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20201015064846.19809-1-qianjun.kernel@gmail.com>
On Thu, Oct 15, 2020 at 02:48:46PM +0800, qianjun.kernel@gmail.com wrote:
> From: jun qian <qianjun.kernel@gmail.com>
>
> When the sched_schedstat changes from 0 to 1, some sched se maybe
> already in the runqueue, the se->statistics.wait_start will be 0.
> So it will let the (rq_of(cfs_rq)) - se->statistics.wait_start)
> wrong. We need to avoid this scenario.
>
> Signed-off-by: jun qian <qianjun.kernel@gmail.com>
> Reviewed-by: Yafang Shao <laoar.shao@gmail.com>
Thanks!
next prev parent reply other threads:[~2020-10-15 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 6:48 [PATCH 1/1] Sched/fair: Improve the accuracy of sched_stat_wait statistics qianjun.kernel
2020-10-15 11:02 ` Peter Zijlstra [this message]
2020-10-29 10:51 ` [tip: sched/core] sched/fair: " tip-bot2 for jun qian
-- strict thread matches above, loose matches on Subject: below --
2020-10-09 9:25 [PATCH 1/1] Sched/fair: " qianjun.kernel
2020-10-14 13:19 ` Peter Zijlstra
2020-10-15 6:06 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015110239.GD2611@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=juri.lelli@redhat.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=qianjun.kernel@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).