From: Yafang Shao <laoar.shao@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: jun qian <qianjun.kernel@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
juri.lelli@redhat.com,
Vincent Guittot <vincent.guittot@linaro.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] Sched/fair: Improve the accuracy of sched_stat_wait statistics
Date: Thu, 15 Oct 2020 14:06:42 +0800 [thread overview]
Message-ID: <CALOAHbCD+E9doVCZEvuuMdDJBbCkBwPNiUo786k19jb82q_8Lw@mail.gmail.com> (raw)
In-Reply-To: <20201014131910.GG2628@hirez.programming.kicks-ass.net>
On Wed, Oct 14, 2020 at 9:19 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Fri, Oct 09, 2020 at 05:25:30PM +0800, qianjun.kernel@gmail.com wrote:
> > From: jun qian <qianjun.kernel@gmail.com>
> >
> > When the sched_schedstat changes from 0 to 1, some sched se maybe
> > already in the runqueue, the se->statistics.wait_start will be 0.
> > So it will let the (rq_of(cfs_rq)) - se->statistics.wait_start)
> > wrong. We need to avoid this scenario.
> >
> > Signed-off-by: jun qian <qianjun.kernel@gmail.com>
> > Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
>
> This SoB chain isn't valid. Did Yafang's tag need to a reviewed-by or
> something?
>
This patch improves the behavior when sched_schedstat is changed from
0 to 1, so it looks good to me.
Reviewed-by: Yafang Shao <laoar.shao@gmail.com>
> > ---
> > kernel/sched/fair.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> > index 1a68a05..6f8ca0c 100644
> > --- a/kernel/sched/fair.c
> > +++ b/kernel/sched/fair.c
> > @@ -906,6 +906,15 @@ static void update_curr_fair(struct rq *rq)
> > if (!schedstat_enabled())
> > return;
> >
> > + /*
> > + * When the sched_schedstat changes from 0 to 1, some sched se
> > + * maybe already in the runqueue, the se->statistics.wait_start
> > + * will be 0.So it will let the delta wrong. We need to avoid this
> > + * scenario.
> > + */
> > + if (unlikely(!schedstat_val(se->statistics.wait_start)))
> > + return;
> > +
> > delta = rq_clock(rq_of(cfs_rq)) - schedstat_val(se->statistics.wait_start);
> >
> > if (entity_is_task(se)) {
> > --
> > 1.8.3.1
> >
--
Thanks
Yafang
next prev parent reply other threads:[~2020-10-15 6:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 9:25 [PATCH 1/1] Sched/fair: Improve the accuracy of sched_stat_wait statistics qianjun.kernel
2020-10-14 13:19 ` Peter Zijlstra
2020-10-15 6:06 ` Yafang Shao [this message]
2020-10-15 6:48 qianjun.kernel
2020-10-15 11:02 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALOAHbCD+E9doVCZEvuuMdDJBbCkBwPNiUo786k19jb82q_8Lw@mail.gmail.com \
--to=laoar.shao@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qianjun.kernel@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).