* [PATCHv4] selftests: rtnetlink: load fou module for kci_test_encap_fou() test
@ 2020-10-16 4:12 Po-Hsu Lin
2020-10-16 23:32 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Po-Hsu Lin @ 2020-10-16 4:12 UTC (permalink / raw)
To: kuba, davem, skhan; +Cc: po-hsu.lin, linux-kernel, netdev, linux-kselftest
The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh
needs the fou module to work. Otherwise it will fail with:
$ ip netns exec "$testns" ip fou add port 7777 ipproto 47
RTNETLINK answers: No such file or directory
Error talking to the kernel
Add the CONFIG_NET_FOU into the config file as well. Which needs at
least to be set as a loadable module.
Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
---
tools/testing/selftests/net/config | 1 +
tools/testing/selftests/net/rtnetlink.sh | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config
index 3b42c06b..c5e50ab 100644
--- a/tools/testing/selftests/net/config
+++ b/tools/testing/selftests/net/config
@@ -31,3 +31,4 @@ CONFIG_NET_SCH_ETF=m
CONFIG_NET_SCH_NETEM=y
CONFIG_TEST_BLACKHOLE_DEV=m
CONFIG_KALLSYMS=y
+CONFIG_NET_FOU=m
diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
index 7c38a90..6f8f159 100755
--- a/tools/testing/selftests/net/rtnetlink.sh
+++ b/tools/testing/selftests/net/rtnetlink.sh
@@ -520,6 +520,11 @@ kci_test_encap_fou()
return $ksft_skip
fi
+ if ! /sbin/modprobe -q -n fou; then
+ echo "SKIP: module fou is not found"
+ return $ksft_skip
+ fi
+ /sbin/modprobe -q fou
ip -netns "$testns" fou add port 7777 ipproto 47 2>/dev/null
if [ $? -ne 0 ];then
echo "FAIL: can't add fou port 7777, skipping test"
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCHv4] selftests: rtnetlink: load fou module for kci_test_encap_fou() test
2020-10-16 4:12 [PATCHv4] selftests: rtnetlink: load fou module for kci_test_encap_fou() test Po-Hsu Lin
@ 2020-10-16 23:32 ` Jakub Kicinski
2020-10-19 2:50 ` Po-Hsu Lin
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2020-10-16 23:32 UTC (permalink / raw)
To: Po-Hsu Lin; +Cc: davem, skhan, linux-kernel, netdev, linux-kselftest
On Fri, 16 Oct 2020 12:12:11 +0800 Po-Hsu Lin wrote:
> The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh
> needs the fou module to work. Otherwise it will fail with:
>
> $ ip netns exec "$testns" ip fou add port 7777 ipproto 47
> RTNETLINK answers: No such file or directory
> Error talking to the kernel
>
> Add the CONFIG_NET_FOU into the config file as well. Which needs at
> least to be set as a loadable module.
>
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Doesn't apply :( Could you rebase on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv4] selftests: rtnetlink: load fou module for kci_test_encap_fou() test
2020-10-16 23:32 ` Jakub Kicinski
@ 2020-10-19 2:50 ` Po-Hsu Lin
0 siblings, 0 replies; 3+ messages in thread
From: Po-Hsu Lin @ 2020-10-19 2:50 UTC (permalink / raw)
To: Jakub Kicinski
Cc: David Miller, Shuah Khan, linux-kernel, netdev, linux-kselftest
On Sat, Oct 17, 2020 at 7:32 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Fri, 16 Oct 2020 12:12:11 +0800 Po-Hsu Lin wrote:
> > The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh
> > needs the fou module to work. Otherwise it will fail with:
> >
> > $ ip netns exec "$testns" ip fou add port 7777 ipproto 47
> > RTNETLINK answers: No such file or directory
> > Error talking to the kernel
> >
> > Add the CONFIG_NET_FOU into the config file as well. Which needs at
> > least to be set as a loadable module.
> >
> > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
>
> Doesn't apply :( Could you rebase on top of:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
Ah OK, I was using the next branch in kselftest, will resend another one.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-19 2:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 4:12 [PATCHv4] selftests: rtnetlink: load fou module for kci_test_encap_fou() test Po-Hsu Lin
2020-10-16 23:32 ` Jakub Kicinski
2020-10-19 2:50 ` Po-Hsu Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).