LKML Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] iio: light: vcnl4035 add i2c_device_id
@ 2020-10-16 18:44 Vaishnav M A
  2020-10-18 11:21 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Vaishnav M A @ 2020-10-16 18:44 UTC (permalink / raw)
  To: jic23, knaack.h, lars, pmeerw, alexandru.ardelean, linux-iio,
	linux-kernel
  Cc: jkridner, drew, robertcnelson, rajkovic


This patch aims to add i2c_device_id for the
vcnl4035 driver, while going through the initial driver
submission patches, noticed that the i2c_device_id was removed
on suggestion (https://lore.kernel.org/patchwork/patch/970970/),
will it be possible to consider this patch add the i2c_device_id,
so that the device can be instantiated using i2c_new_client_device
or say from the userspace?.This will be really helpful in cases
where the device tree based description is not possible now(Eg. 
a device on a gbphy i2c adapter created by greybus).

The particular usecase here is described over this RFC Patch
for the mikroBUS driver:
https://lore.kernel.org/patchwork/patch/1290148/

Thanks and Regards,

Vaishnav M A

Signed-off-by: Vaishnav M A <vaishnav@beagleboard.org>
---
 drivers/iio/light/vcnl4035.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
index 765c44adac57..73a28e30dddc 100644
--- a/drivers/iio/light/vcnl4035.c
+++ b/drivers/iio/light/vcnl4035.c
@@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
 			   vcnl4035_runtime_resume, NULL)
 };
 
+static const struct i2c_device_id vcnl4035_id[] = {
+	{ "vcnl4035", 0},
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
+
 static const struct of_device_id vcnl4035_of_match[] = {
 	{ .compatible = "vishay,vcnl4035", },
 	{ }
@@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
 	},
 	.probe  = vcnl4035_probe,
 	.remove	= vcnl4035_remove,
+	.id_table = vcnl4035_id,
 };
 
 module_i2c_driver(vcnl4035_driver);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio: light: vcnl4035 add i2c_device_id
  2020-10-16 18:44 [PATCH] iio: light: vcnl4035 add i2c_device_id Vaishnav M A
@ 2020-10-18 11:21 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-10-18 11:21 UTC (permalink / raw)
  To: Vaishnav M A
  Cc: knaack.h, lars, pmeerw, alexandru.ardelean, linux-iio,
	linux-kernel, jkridner, drew, robertcnelson, rajkovic

On Sat, 17 Oct 2020 00:14:59 +0530
Vaishnav M A <vaishnav@beagleboard.org> wrote:

> This patch aims to add i2c_device_id for the
> vcnl4035 driver, while going through the initial driver
> submission patches, noticed that the i2c_device_id was removed
> on suggestion (https://lore.kernel.org/patchwork/patch/970970/),
> will it be possible to consider this patch add the i2c_device_id,
> so that the device can be instantiated using i2c_new_client_device
> or say from the userspace?.This will be really helpful in cases
> where the device tree based description is not possible now(Eg. 
> a device on a gbphy i2c adapter created by greybus).
> 
> The particular usecase here is described over this RFC Patch
> for the mikroBUS driver:
> https://lore.kernel.org/patchwork/patch/1290148/
> 
> Thanks and Regards,
> 
> Vaishnav M A
If you send out a v2 of a patch without there having been any replies
please reply your self to say you have done so.

That avoids reviewers looking at the wrong version!

Thanks

Jonathan



> 
> Signed-off-by: Vaishnav M A <vaishnav@beagleboard.org>
> ---
>  drivers/iio/light/vcnl4035.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
> index 765c44adac57..73a28e30dddc 100644
> --- a/drivers/iio/light/vcnl4035.c
> +++ b/drivers/iio/light/vcnl4035.c
> @@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
>  			   vcnl4035_runtime_resume, NULL)
>  };
>  
> +static const struct i2c_device_id vcnl4035_id[] = {
> +	{ "vcnl4035", 0},
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
> +
>  static const struct of_device_id vcnl4035_of_match[] = {
>  	{ .compatible = "vishay,vcnl4035", },
>  	{ }
> @@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
>  	},
>  	.probe  = vcnl4035_probe,
>  	.remove	= vcnl4035_remove,
> +	.id_table = vcnl4035_id,
>  };
>  
>  module_i2c_driver(vcnl4035_driver);


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 18:44 [PATCH] iio: light: vcnl4035 add i2c_device_id Vaishnav M A
2020-10-18 11:21 ` Jonathan Cameron

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git