* [PATCH] drivers/thermal: optimize the for circle to run a bit fast
@ 2020-10-19 8:22 Bernard Zhao
0 siblings, 0 replies; only message in thread
From: Bernard Zhao @ 2020-10-19 8:22 UTC (permalink / raw)
To: Zhang Rui, Daniel Lezcano, Amit Kucheria, linux-pm, linux-kernel
Cc: opensource.kernel, Bernard Zhao
Function thermal_zone_device_register, in the for circle, if the
first if branch set the count bit in tz->trips_disabled, there is
no need to set in the other if branch again.
This change is to make the code run a bit fast and readable.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/thermal/thermal_core.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index c6d74bc1c90b..03577794eea3 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1446,10 +1446,14 @@ thermal_zone_device_register(const char *type, int trips, int mask,
goto release_device;
for (count = 0; count < trips; count++) {
- if (tz->ops->get_trip_type(tz, count, &trip_type))
+ if (tz->ops->get_trip_type(tz, count, &trip_type)) {
set_bit(count, &tz->trips_disabled);
- if (tz->ops->get_trip_temp(tz, count, &trip_temp))
+ continue;
+ }
+ if (tz->ops->get_trip_temp(tz, count, &trip_temp)) {
set_bit(count, &tz->trips_disabled);
+ continue;
+ }
/* Check for bogus trip points */
if (trip_temp == 0)
set_bit(count, &tz->trips_disabled);
--
2.28.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-19 8:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 8:22 [PATCH] drivers/thermal: optimize the for circle to run a bit fast Bernard Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).