* [PATCH] tty: remove unneeded break
@ 2020-10-19 17:59 trix
2020-10-19 19:00 ` Greg KH
2020-10-20 7:37 ` Uwe Kleine-König
0 siblings, 2 replies; 3+ messages in thread
From: trix @ 2020-10-19 17:59 UTC (permalink / raw)
To: gregkh, jirislaby, shawnguo, s.hauer, kernel, festevam, linux-imx
Cc: linux-serial, linux-arm-kernel, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/tty/serial/imx.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 1731d9728865..09703079db7b 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -320,7 +320,6 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset)
switch (offset) {
case UCR1:
return sport->ucr1;
- break;
case UCR2:
/*
* UCR2_SRST is the only bit in the cached registers that might
@@ -331,16 +330,12 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset)
if (!(sport->ucr2 & UCR2_SRST))
sport->ucr2 = readl(sport->port.membase + offset);
return sport->ucr2;
- break;
case UCR3:
return sport->ucr3;
- break;
case UCR4:
return sport->ucr4;
- break;
case UFCR:
return sport->ufcr;
- break;
default:
return readl(sport->port.membase + offset);
}
--
2.18.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tty: remove unneeded break
2020-10-19 17:59 [PATCH] tty: remove unneeded break trix
@ 2020-10-19 19:00 ` Greg KH
2020-10-20 7:37 ` Uwe Kleine-König
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-10-19 19:00 UTC (permalink / raw)
To: trix
Cc: jirislaby, shawnguo, s.hauer, kernel, festevam, linux-imx,
linux-serial, linux-arm-kernel, linux-kernel
On Mon, Oct 19, 2020 at 10:59:15AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/tty/serial/imx.c | 5 -----
This is the imx driver, you should say that in the subject line like you
did for the other tty change you just sent out.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tty: remove unneeded break
2020-10-19 17:59 [PATCH] tty: remove unneeded break trix
2020-10-19 19:00 ` Greg KH
@ 2020-10-20 7:37 ` Uwe Kleine-König
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2020-10-20 7:37 UTC (permalink / raw)
To: trix
Cc: gregkh, jirislaby, shawnguo, s.hauer, kernel, festevam,
linux-imx, linux-arm-kernel, linux-serial, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1550 bytes --]
On Mon, Oct 19, 2020 at 10:59:15AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/tty/serial/imx.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 1731d9728865..09703079db7b 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -320,7 +320,6 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset)
> switch (offset) {
> case UCR1:
> return sport->ucr1;
> - break;
> case UCR2:
> /*
> * UCR2_SRST is the only bit in the cached registers that might
> @@ -331,16 +330,12 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset)
> if (!(sport->ucr2 & UCR2_SRST))
> sport->ucr2 = readl(sport->port.membase + offset);
> return sport->ucr2;
> - break;
> case UCR3:
> return sport->ucr3;
> - break;
> case UCR4:
> return sport->ucr4;
> - break;
> case UFCR:
> return sport->ufcr;
> - break;
> default:
> return readl(sport->port.membase + offset);
> }
this might be subjective, but I like the break being there for clearity.
So I object to make a patch to remove them. In case I'm outvoted I'd at
least want empty lines instead.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-20 7:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 17:59 [PATCH] tty: remove unneeded break trix
2020-10-19 19:00 ` Greg KH
2020-10-20 7:37 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).