From: kernel test robot <lkp@intel.com>
To: Prashant Malani <pmalani@chromium.org>, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, heikki.krogerus@linux.intel.com,
Prashant Malani <pmalani@chromium.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH 5/7] platform/chrome: cros_ec_typec: Introduce TYPEC_STATUS
Date: Thu, 22 Oct 2020 06:54:05 +0800 [thread overview]
Message-ID: <202010220607.vNb380XI-lkp@intel.com> (raw)
In-Reply-To: <20201021205317.708008-6-pmalani@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 2645 bytes --]
Hi Prashant,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on chrome-platform-linux/for-next]
[also build test WARNING on linus/master v5.9 next-20201021]
[cannot apply to linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Prashant-Malani/platform-chrome-cros_ec_typec-Register-partner-PD-information/20201022-045552
base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
config: microblaze-allyesconfig (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/d95c360f8dc525bd78c299a987c1287867f766a2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Prashant-Malani/platform-chrome-cros_ec_typec-Register-partner-PD-information/20201022-045552
git checkout d95c360f8dc525bd78c299a987c1287867f766a2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/platform/chrome/cros_ec_typec.c:698:5: warning: no previous prototype for 'cros_typec_cmds_supported' [-Wmissing-prototypes]
698 | int cros_typec_cmds_supported(struct cros_typec_data *typec)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/cros_typec_cmds_supported +698 drivers/platform/chrome/cros_ec_typec.c
696
697 /* Check the EC feature flags to see if TYPEC_* commands are supported. */
> 698 int cros_typec_cmds_supported(struct cros_typec_data *typec)
699 {
700 struct ec_response_get_features resp = {};
701 int ret;
702
703 ret = cros_typec_ec_command(typec, 0, EC_CMD_GET_FEATURES, NULL, 0,
704 &resp, sizeof(resp));
705 if (ret < 0) {
706 dev_warn(typec->dev,
707 "Failed to get features, assuming typec commands unsupported.\n");
708 return 0;
709 }
710
711 return resp.flags[EC_FEATURE_TYPEC_CMD / 32] & EC_FEATURE_MASK_1(EC_FEATURE_TYPEC_CMD);
712 }
713
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64896 bytes --]
next prev parent reply other threads:[~2020-10-21 22:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 20:53 [PATCH 0/7] platform/chrome: cros_ec_typec: Register partner PD information Prashant Malani
2020-10-21 20:53 ` [PATCH 1/7] platform/chrome: cros_ec_typec: Relocate set_port_params_v*() functions Prashant Malani
2020-10-21 20:53 ` [PATCH 2/7] platform/chrome: cros_ec_typec: Fix remove partner logic Prashant Malani
2020-10-21 20:53 ` [PATCH 3/7] platform/chrome: cros_ec_typec: Clear partner identity on device removal Prashant Malani
2020-10-21 20:53 ` [PATCH 4/7] platform/chrome: cros_ec: Import Type C host commands Prashant Malani
2020-10-21 20:53 ` [PATCH 5/7] platform/chrome: cros_ec_typec: Introduce TYPEC_STATUS Prashant Malani
2020-10-21 22:54 ` kernel test robot [this message]
2020-10-21 23:50 ` Prashant Malani
2020-10-27 14:27 ` kernel test robot
2020-10-27 14:27 ` [RFC PATCH] platform/chrome: cros_ec_typec: cros_typec_cmds_supported() can be static kernel test robot
2020-10-27 17:52 ` [PATCH 5/7] platform/chrome: cros_ec_typec: Introduce TYPEC_STATUS kernel test robot
2020-10-21 20:53 ` [PATCH 6/7] platform/chrome: cros_ec_typec: Parse partner PD ID VDOs Prashant Malani
[not found] ` <20201028131633.GA2026875@kuha.fi.intel.com>
2020-10-28 20:11 ` Prashant Malani
2020-10-30 13:25 ` Heikki Krogerus
2020-10-21 20:53 ` [PATCH 7/7] platform/chrome: cros_ec_typec: Register partner altmodes Prashant Malani
[not found] ` <20201028131732.GB2026875@kuha.fi.intel.com>
2020-10-29 22:11 ` Prashant Malani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010220607.vNb380XI-lkp@intel.com \
--to=lkp@intel.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).