From: Prashant Malani <pmalani@chromium.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH 7/7] platform/chrome: cros_ec_typec: Register partner altmodes
Date: Thu, 29 Oct 2020 15:11:54 -0700 [thread overview]
Message-ID: <20201029221154.GB3913249@google.com> (raw)
In-Reply-To: <20201028131732.GB2026875@kuha.fi.intel.com>
Hi Heikki,
Thank you for reviewing the patch!
On Wed, Oct 28, 2020 at 03:17:32PM +0200, Heikki Krogerus wrote:
> Hi,
>
> On Wed, Oct 21, 2020 at 01:53:16PM -0700, Prashant Malani wrote:
> > +static void cros_typec_unregister_altmodes(struct cros_typec_data *typec, int port_num)
> > +{
> > + struct cros_typec_port *port = typec->ports[port_num];
> > + struct cros_typec_altmode_node *node;
> > +
> > + while (!list_empty(&port->partner_mode_list)) {
> > + node = list_first_entry(&port->partner_mode_list, struct cros_typec_altmode_node,
> > + list);
>
> ...
> struct cros_typec_altmode_node *node, *tmp;
>
> list_for_each_entry_safe(node, tmp, &port->partner_mode_list, list) {
>
Nice; I will make this update in v2. Thanks!
Best regards,
-Prashant
prev parent reply other threads:[~2020-10-29 22:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 20:53 [PATCH 0/7] platform/chrome: cros_ec_typec: Register partner PD information Prashant Malani
2020-10-21 20:53 ` [PATCH 1/7] platform/chrome: cros_ec_typec: Relocate set_port_params_v*() functions Prashant Malani
2020-10-21 20:53 ` [PATCH 2/7] platform/chrome: cros_ec_typec: Fix remove partner logic Prashant Malani
2020-10-21 20:53 ` [PATCH 3/7] platform/chrome: cros_ec_typec: Clear partner identity on device removal Prashant Malani
2020-10-21 20:53 ` [PATCH 4/7] platform/chrome: cros_ec: Import Type C host commands Prashant Malani
2020-10-21 20:53 ` [PATCH 5/7] platform/chrome: cros_ec_typec: Introduce TYPEC_STATUS Prashant Malani
2020-10-21 22:54 ` kernel test robot
2020-10-21 23:50 ` Prashant Malani
2020-10-27 14:27 ` kernel test robot
2020-10-27 14:27 ` [RFC PATCH] platform/chrome: cros_ec_typec: cros_typec_cmds_supported() can be static kernel test robot
2020-10-27 17:52 ` [PATCH 5/7] platform/chrome: cros_ec_typec: Introduce TYPEC_STATUS kernel test robot
2020-10-21 20:53 ` [PATCH 6/7] platform/chrome: cros_ec_typec: Parse partner PD ID VDOs Prashant Malani
[not found] ` <20201028131633.GA2026875@kuha.fi.intel.com>
2020-10-28 20:11 ` Prashant Malani
2020-10-30 13:25 ` Heikki Krogerus
2020-10-21 20:53 ` [PATCH 7/7] platform/chrome: cros_ec_typec: Register partner altmodes Prashant Malani
[not found] ` <20201028131732.GB2026875@kuha.fi.intel.com>
2020-10-29 22:11 ` Prashant Malani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029221154.GB3913249@google.com \
--to=pmalani@chromium.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).