* [PATCH] arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm
@ 2020-10-23 9:41 Jerome Brunet
2020-10-23 12:28 ` Neil Armstrong
2020-10-23 22:22 ` Kevin Hilman
0 siblings, 2 replies; 3+ messages in thread
From: Jerome Brunet @ 2020-10-23 9:41 UTC (permalink / raw)
To: Kevin Hilman; +Cc: Jerome Brunet, linux-amlogic, devicetree, linux-kernel
On the odroid N2 plus, cpufreq is not available due to an error on the cpu
regulators. vddcpu a and b get the same PWM. The one provided to vddcpu A
is incorrect. Because vddcpu B PWM is busy the regulator cannot register:
> pwm-regulator regulator-vddcpu-b: Failed to get PWM: -16
Like on the odroid n2, use PWM A out of GPIOE_2 for vddcpu A to fix the
problem
Fixes: 98d24896ee11 ("arm64: dts: meson: add support for the ODROID-N2+")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
index 5de2815ba99d..ce1198ad34e4 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
@@ -19,7 +19,7 @@ &vddcpu_a {
regulator-min-microvolt = <680000>;
regulator-max-microvolt = <1040000>;
- pwms = <&pwm_AO_cd 1 1500 0>;
+ pwms = <&pwm_ab 0 1500 0>;
};
&vddcpu_b {
--
2.25.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm
2020-10-23 9:41 [PATCH] arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm Jerome Brunet
@ 2020-10-23 12:28 ` Neil Armstrong
2020-10-23 22:22 ` Kevin Hilman
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2020-10-23 12:28 UTC (permalink / raw)
To: Jerome Brunet, Kevin Hilman; +Cc: linux-amlogic, devicetree, linux-kernel
On 23/10/2020 11:41, Jerome Brunet wrote:
> On the odroid N2 plus, cpufreq is not available due to an error on the cpu
> regulators. vddcpu a and b get the same PWM. The one provided to vddcpu A
> is incorrect. Because vddcpu B PWM is busy the regulator cannot register:
>
>> pwm-regulator regulator-vddcpu-b: Failed to get PWM: -16
>
> Like on the odroid n2, use PWM A out of GPIOE_2 for vddcpu A to fix the
> problem
>
> Fixes: 98d24896ee11 ("arm64: dts: meson: add support for the ODROID-N2+")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
> index 5de2815ba99d..ce1198ad34e4 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts
> @@ -19,7 +19,7 @@ &vddcpu_a {
> regulator-min-microvolt = <680000>;
> regulator-max-microvolt = <1040000>;
>
> - pwms = <&pwm_AO_cd 1 1500 0>;
> + pwms = <&pwm_ab 0 1500 0>;
> };
>
> &vddcpu_b {
>
Nice catch, thanks
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm
2020-10-23 9:41 [PATCH] arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm Jerome Brunet
2020-10-23 12:28 ` Neil Armstrong
@ 2020-10-23 22:22 ` Kevin Hilman
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2020-10-23 22:22 UTC (permalink / raw)
To: Jerome Brunet; +Cc: linux-amlogic, devicetree, linux-kernel
On Fri, 23 Oct 2020 11:41:39 +0200, Jerome Brunet wrote:
> On the odroid N2 plus, cpufreq is not available due to an error on the cpu
> regulators. vddcpu a and b get the same PWM. The one provided to vddcpu A
> is incorrect. Because vddcpu B PWM is busy the regulator cannot register:
>
> > pwm-regulator regulator-vddcpu-b: Failed to get PWM: -16
>
> Like on the odroid n2, use PWM A out of GPIOE_2 for vddcpu A to fix the
> problem
Applied, thanks!
[1/1] arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm
(no commit info)
Best regards,
--
Kevin Hilman <khilman@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-23 22:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-23 9:41 [PATCH] arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm Jerome Brunet
2020-10-23 12:28 ` Neil Armstrong
2020-10-23 22:22 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).