* [PATCH] power: remove unneeded break
@ 2020-10-19 18:59 trix
2020-10-26 10:20 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-10-19 18:59 UTC (permalink / raw)
To: sre; +Cc: patches, linux-pm, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a goto
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/power/supply/wm831x_power.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/power/supply/wm831x_power.c b/drivers/power/supply/wm831x_power.c
index 18b33f14dfee..4cd2dd870039 100644
--- a/drivers/power/supply/wm831x_power.c
+++ b/drivers/power/supply/wm831x_power.c
@@ -668,7 +668,6 @@ static int wm831x_power_probe(struct platform_device *pdev)
fallthrough;
case -EPROBE_DEFER:
goto err_bat_irq;
- break;
}
return ret;
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: remove unneeded break
2020-10-19 18:59 [PATCH] power: remove unneeded break trix
@ 2020-10-26 10:20 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2020-10-26 10:20 UTC (permalink / raw)
To: trix; +Cc: sre, patches, linux-pm, linux-kernel
On Mon, Oct 19, 2020 at 11:59:37AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a goto
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-26 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 18:59 [PATCH] power: remove unneeded break trix
2020-10-26 10:20 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).