* [PATCH] net/atm: use list_is_singular() in br2684_setfilt()
@ 2020-10-26 16:57 Hui Su
2020-10-28 0:47 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Hui Su @ 2020-10-26 16:57 UTC (permalink / raw)
To: davem, kuba, netdev, linux-kernel
list_is_singular() can tell whether a list has just one entry.
So we use list_is_singular（) here.
Signed-off-by: Hui Su <sh_def@163.com>
---
net/atm/br2684.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/atm/br2684.c b/net/atm/br2684.c
index 3e17a5ecaa94..398f7e086cf4 100644
--- a/net/atm/br2684.c
+++ b/net/atm/br2684.c
@@ -372,8 +372,7 @@ static int br2684_setfilt(struct atm_vcc *atmvcc, void __user * arg)
struct br2684_dev *brdev;
read_lock(&devs_lock);
brdev = BRPRIV(br2684_find_dev(&fs.ifspec));
- if (brdev == NULL || list_empty(&brdev->brvccs) ||
- brdev->brvccs.next != brdev->brvccs.prev) /* >1 VCC */
+ if (brdev == NULL || !list_is_singular(&brdev->brvccs)) /* >1 VCC */
brvcc = NULL;
else
brvcc = list_entry_brvcc(brdev->brvccs.next);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/atm: use list_is_singular() in br2684_setfilt()
2020-10-26 16:57 [PATCH] net/atm: use list_is_singular() in br2684_setfilt() Hui Su
@ 2020-10-28 0:47 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-10-28 0:47 UTC (permalink / raw)
To: Hui Su; +Cc: davem, netdev, linux-kernel
On Tue, 27 Oct 2020 00:57:00 +0800 Hui Su wrote:
> list_is_singular() can tell whether a list has just one entry.
> So we use list_is_singular（) here.
>
> Signed-off-by: Hui Su <sh_def@163.com>
> ---
> net/atm/br2684.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/atm/br2684.c b/net/atm/br2684.c
> index 3e17a5ecaa94..398f7e086cf4 100644
> --- a/net/atm/br2684.c
> +++ b/net/atm/br2684.c
> @@ -372,8 +372,7 @@ static int br2684_setfilt(struct atm_vcc *atmvcc, void __user * arg)
> struct br2684_dev *brdev;
> read_lock(&devs_lock);
> brdev = BRPRIV(br2684_find_dev(&fs.ifspec));
> - if (brdev == NULL || list_empty(&brdev->brvccs) ||
> - brdev->brvccs.next != brdev->brvccs.prev) /* >1 VCC */
> + if (brdev == NULL || !list_is_singular(&brdev->brvccs)) /* >1 VCC */
You can drop the /* >1 VCC */ comment now, the code is clear enough
> brvcc = NULL;
> else
> brvcc = list_entry_brvcc(brdev->brvccs.next);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-29 0:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-26 16:57 [PATCH] net/atm: use list_is_singular() in br2684_setfilt() Hui Su
2020-10-28 0:47 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).