* [PATCH v2] pinctrl: samsung: pinctrl-s3c24xx: remove unneeded break
@ 2020-10-20 13:15 trix
2020-10-26 19:18 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-10-20 13:15 UTC (permalink / raw)
To: kgene, krzk, tomasz.figa, s.nawrocki, linus.walleij
Cc: linux-arm-kernel, linux-samsung-soc, linux-gpio, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return.
Signed-off-by: Tom Rix <trix@redhat.com>
---
v2: Improve commit log
---
drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
index 5e24838a582f..2223ead5bd72 100644
--- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
+++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
@@ -108,19 +108,14 @@ static int s3c24xx_eint_get_trigger(unsigned int type)
switch (type) {
case IRQ_TYPE_EDGE_RISING:
return EINT_EDGE_RISING;
- break;
case IRQ_TYPE_EDGE_FALLING:
return EINT_EDGE_FALLING;
- break;
case IRQ_TYPE_EDGE_BOTH:
return EINT_EDGE_BOTH;
- break;
case IRQ_TYPE_LEVEL_HIGH:
return EINT_LEVEL_HIGH;
- break;
case IRQ_TYPE_LEVEL_LOW:
return EINT_LEVEL_LOW;
- break;
default:
return -EINVAL;
}
--
2.18.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] pinctrl: samsung: pinctrl-s3c24xx: remove unneeded break
2020-10-20 13:15 [PATCH v2] pinctrl: samsung: pinctrl-s3c24xx: remove unneeded break trix
@ 2020-10-26 19:18 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-26 19:18 UTC (permalink / raw)
To: trix
Cc: kgene, tomasz.figa, s.nawrocki, linus.walleij, linux-arm-kernel,
linux-samsung-soc, linux-gpio, linux-kernel
On Tue, Oct 20, 2020 at 06:15:20AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>
> v2: Improve commit log
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-26 19:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-20 13:15 [PATCH v2] pinctrl: samsung: pinctrl-s3c24xx: remove unneeded break trix
2020-10-26 19:18 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).