[PATCH] ibmveth: Fix use of ibmveth in a bridge.

* [PATCH] ibmveth: Fix use of ibmveth in a bridge.
@ 2020-10-26 10:42 Michal Suchanek
  2020-10-26 18:52 ` Jakub Kicinski
  0 siblings, 1 reply; 4+ messages in thread
From: Michal Suchanek @ 2020-10-26 10:42 UTC (permalink / raw)
  To: Thomas Bogendoerfer, netdev
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Cristobal Forno, David S. Miller, Jakub Kicinski, Cris Forno,
	linuxppc-dev, linux-kernel, Michal Suchanek

From: Thomas Bogendoerfer <tbogendoerfer@suse.de>

The check for src mac address in ibmveth_is_packet_unsupported is wrong.
Commit 6f2275433a2f wanted to shut down messages for loopback packets,
but now suppresses bridged frames, which are accepted by the hypervisor
otherwise bridging won't work at all.

Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
ms: added commit message
---
 drivers/net/ethernet/ibm/ibmveth.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 7ef3369953b6..c3ec9ceed833 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1031,12 +1031,6 @@ static int ibmveth_is_packet_unsupported(struct sk_buff *skb,
 		ret = -EOPNOTSUPP;
 	}
 
-	if (!ether_addr_equal(ether_header->h_source, netdev->dev_addr)) {
-		netdev_dbg(netdev, "source packet MAC address does not match veth device's, dropping packet.\n");
-		netdev->stats.tx_dropped++;
-		ret = -EOPNOTSUPP;
-	}
-
 	return ret;
 }
 
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread