* [PATCH] crypto: atmel-sha: remove unneeded break
@ 2020-10-19 19:36 trix
2020-10-26 20:43 ` Alexandre Belloni
2020-11-06 6:59 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: trix @ 2020-10-19 19:36 UTC (permalink / raw)
To: herbert, davem, nicolas.ferre, alexandre.belloni, ludovic.desroches
Cc: linux-crypto, linux-arm-kernel, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/crypto/atmel-sha.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index 75ccf41a7cb9..0eb6f54e3b66 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -459,7 +459,6 @@ static int atmel_sha_init(struct ahash_request *req)
break;
default:
return -EINVAL;
- break;
}
ctx->bufcnt = 0;
--
2.18.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: atmel-sha: remove unneeded break
2020-10-19 19:36 [PATCH] crypto: atmel-sha: remove unneeded break trix
@ 2020-10-26 20:43 ` Alexandre Belloni
2020-11-06 6:59 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2020-10-26 20:43 UTC (permalink / raw)
To: trix
Cc: herbert, davem, nicolas.ferre, ludovic.desroches, linux-crypto,
linux-arm-kernel, linux-kernel
On 19/10/2020 12:36:53-0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/crypto/atmel-sha.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
> index 75ccf41a7cb9..0eb6f54e3b66 100644
> --- a/drivers/crypto/atmel-sha.c
> +++ b/drivers/crypto/atmel-sha.c
> @@ -459,7 +459,6 @@ static int atmel_sha_init(struct ahash_request *req)
> break;
> default:
> return -EINVAL;
> - break;
> }
>
> ctx->bufcnt = 0;
> --
> 2.18.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: atmel-sha: remove unneeded break
2020-10-19 19:36 [PATCH] crypto: atmel-sha: remove unneeded break trix
2020-10-26 20:43 ` Alexandre Belloni
@ 2020-11-06 6:59 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2020-11-06 6:59 UTC (permalink / raw)
To: trix
Cc: davem, nicolas.ferre, alexandre.belloni, ludovic.desroches,
linux-crypto, linux-arm-kernel, linux-kernel
On Mon, Oct 19, 2020 at 12:36:53PM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/crypto/atmel-sha.c | 1 -
> 1 file changed, 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-06 7:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 19:36 [PATCH] crypto: atmel-sha: remove unneeded break trix
2020-10-26 20:43 ` Alexandre Belloni
2020-11-06 6:59 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).