* [PATCH] ARM: kprobes: fix arch_init_kprobes() prototype
@ 2020-10-26 22:12 Arnd Bergmann
2020-10-27 0:30 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2020-10-26 22:12 UTC (permalink / raw)
To: Russell King
Cc: Arnd Bergmann, Masami Hiramatsu, linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
With extra warnings enabled, gcc complains about this function
definition:
arch/arm/probes/kprobes/core.c: In function 'arch_init_kprobes':
arch/arm/probes/kprobes/core.c:465:12: warning: old-style function definition [-Wold-style-definition]
465 | int __init arch_init_kprobes()
Fixes: 24ba613c9d6c ("ARM kprobes: core code")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/probes/kprobes/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/probes/kprobes/core.c b/arch/arm/probes/kprobes/core.c
index a9653117ca0d..e513d8a46776 100644
--- a/arch/arm/probes/kprobes/core.c
+++ b/arch/arm/probes/kprobes/core.c
@@ -462,7 +462,7 @@ static struct undef_hook kprobes_arm_break_hook = {
#endif /* !CONFIG_THUMB2_KERNEL */
-int __init arch_init_kprobes()
+int __init arch_init_kprobes(void)
{
arm_probes_decode_init();
#ifdef CONFIG_THUMB2_KERNEL
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: kprobes: fix arch_init_kprobes() prototype
2020-10-26 22:12 [PATCH] ARM: kprobes: fix arch_init_kprobes() prototype Arnd Bergmann
@ 2020-10-27 0:30 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2020-10-27 0:30 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Russell King, Arnd Bergmann, Masami Hiramatsu, linux-arm-kernel,
linux-kernel
On Mon, 26 Oct 2020 23:12:00 +0100
Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With extra warnings enabled, gcc complains about this function
> definition:
>
> arch/arm/probes/kprobes/core.c: In function 'arch_init_kprobes':
> arch/arm/probes/kprobes/core.c:465:12: warning: old-style function definition [-Wold-style-definition]
> 465 | int __init arch_init_kprobes()
>
> Fixes: 24ba613c9d6c ("ARM kprobes: core code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks Arnd!
> ---
> arch/arm/probes/kprobes/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/probes/kprobes/core.c b/arch/arm/probes/kprobes/core.c
> index a9653117ca0d..e513d8a46776 100644
> --- a/arch/arm/probes/kprobes/core.c
> +++ b/arch/arm/probes/kprobes/core.c
> @@ -462,7 +462,7 @@ static struct undef_hook kprobes_arm_break_hook = {
>
> #endif /* !CONFIG_THUMB2_KERNEL */
>
> -int __init arch_init_kprobes()
> +int __init arch_init_kprobes(void)
> {
> arm_probes_decode_init();
> #ifdef CONFIG_THUMB2_KERNEL
> --
> 2.27.0
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-27 0:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-26 22:12 [PATCH] ARM: kprobes: fix arch_init_kprobes() prototype Arnd Bergmann
2020-10-27 0:30 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).