* [PATCH] net: microchip: Remove unneeded variable ret
@ 2020-10-23 9:21 Xu Wang
2020-10-27 23:10 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2020-10-23 9:21 UTC (permalink / raw)
To: bryan.whitehead, UNGLinuxDriver, davem, kuba, netdev; +Cc: linux-kernel
Remove unneeded variable ret used to store return value.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/net/ethernet/microchip/lan743x_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
index a1938842f828..8ea0b4eec19c 100644
--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -834,14 +834,13 @@ static int lan743x_mac_init(struct lan743x_adapter *adapter)
static int lan743x_mac_open(struct lan743x_adapter *adapter)
{
- int ret = 0;
u32 temp;
temp = lan743x_csr_read(adapter, MAC_RX);
lan743x_csr_write(adapter, MAC_RX, temp | MAC_RX_RXEN_);
temp = lan743x_csr_read(adapter, MAC_TX);
lan743x_csr_write(adapter, MAC_TX, temp | MAC_TX_TXEN_);
- return ret;
+ return 0;
}
static void lan743x_mac_close(struct lan743x_adapter *adapter)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: microchip: Remove unneeded variable ret
2020-10-23 9:21 [PATCH] net: microchip: Remove unneeded variable ret Xu Wang
@ 2020-10-27 23:10 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-10-27 23:10 UTC (permalink / raw)
To: Xu Wang; +Cc: bryan.whitehead, UNGLinuxDriver, davem, netdev, linux-kernel
On Fri, 23 Oct 2020 09:21:07 +0000 Xu Wang wrote:
> Remove unneeded variable ret used to store return value.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-27 23:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-23 9:21 [PATCH] net: microchip: Remove unneeded variable ret Xu Wang
2020-10-27 23:10 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).