linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ASoC: codecs: wcd934x: Set digital gain range correctly
@ 2020-10-28 15:43 Srinivas Kandagatla
  2020-10-28 15:43 ` [PATCH 2/2] ASoc: codecs: wcd9335: " Srinivas Kandagatla
  2020-10-28 21:22 ` [PATCH 1/2] ASoC: codecs: wcd934x: " Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2020-10-28 15:43 UTC (permalink / raw)
  To: broonie; +Cc: perex, alsa-devel, linux-kernel, lgirdwood, Srinivas Kandagatla

digital gain range is -84dB min to 40dB max, however this was not
correctly specified in the range.

Fix this by with correct range!

Fixes: 1cde8b822332 ("ASoC: wcd934x: add basic controls")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 sound/soc/codecs/wcd934x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c
index 35697b072367..40f682f5dab8 100644
--- a/sound/soc/codecs/wcd934x.c
+++ b/sound/soc/codecs/wcd934x.c
@@ -551,7 +551,7 @@ struct wcd_iir_filter_ctl {
 	struct soc_bytes_ext bytes_ext;
 };
 
-static const DECLARE_TLV_DB_SCALE(digital_gain, 0, 1, 0);
+static const DECLARE_TLV_DB_SCALE(digital_gain, -8400, 100, -8400);
 static const DECLARE_TLV_DB_SCALE(line_gain, 0, 7, 1);
 static const DECLARE_TLV_DB_SCALE(analog_gain, 0, 25, 1);
 static const DECLARE_TLV_DB_SCALE(ear_pa_gain, 0, 150, 0);
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ASoc: codecs: wcd9335: Set digital gain range correctly
  2020-10-28 15:43 [PATCH 1/2] ASoC: codecs: wcd934x: Set digital gain range correctly Srinivas Kandagatla
@ 2020-10-28 15:43 ` Srinivas Kandagatla
  2020-10-28 21:22 ` [PATCH 1/2] ASoC: codecs: wcd934x: " Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2020-10-28 15:43 UTC (permalink / raw)
  To: broonie; +Cc: perex, alsa-devel, linux-kernel, lgirdwood, Srinivas Kandagatla

digital gain range is -84dB min to 40dB max, however this was not
correctly specified in the range.

Fix this by with correct range!

Fixes: 8c4f021d806a ("ASoC: wcd9335: add basic controls")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 sound/soc/codecs/wcd9335.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
index f2d9d52ee171..4d2b1ec7c03b 100644
--- a/sound/soc/codecs/wcd9335.c
+++ b/sound/soc/codecs/wcd9335.c
@@ -618,7 +618,7 @@ static const char * const sb_tx8_mux_text[] = {
 	"ZERO", "RX_MIX_TX8", "DEC8", "DEC8_192"
 };
 
-static const DECLARE_TLV_DB_SCALE(digital_gain, 0, 1, 0);
+static const DECLARE_TLV_DB_SCALE(digital_gain, -8400, 100, -8400);
 static const DECLARE_TLV_DB_SCALE(line_gain, 0, 7, 1);
 static const DECLARE_TLV_DB_SCALE(analog_gain, 0, 25, 1);
 static const DECLARE_TLV_DB_SCALE(ear_pa_gain, 0, 150, 0);
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ASoC: codecs: wcd934x: Set digital gain range correctly
  2020-10-28 15:43 [PATCH 1/2] ASoC: codecs: wcd934x: Set digital gain range correctly Srinivas Kandagatla
  2020-10-28 15:43 ` [PATCH 2/2] ASoc: codecs: wcd9335: " Srinivas Kandagatla
@ 2020-10-28 21:22 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-10-28 21:22 UTC (permalink / raw)
  To: Srinivas Kandagatla; +Cc: alsa-devel, linux-kernel, lgirdwood

On Wed, 28 Oct 2020 15:43:39 +0000, Srinivas Kandagatla wrote:
> digital gain range is -84dB min to 40dB max, however this was not
> correctly specified in the range.
> 
> Fix this by with correct range!

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: codecs: wcd934x: Set digital gain range correctly
      commit: fc0522bbe02fa4beb95c0514ace66b585616f111
[2/2] ASoC: codecs: wcd9335: Set digital gain range correctly
      commit: 6d6bc54ab4f2404d46078abc04bf4dee4db01def

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-29  2:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-28 15:43 [PATCH 1/2] ASoC: codecs: wcd934x: Set digital gain range correctly Srinivas Kandagatla
2020-10-28 15:43 ` [PATCH 2/2] ASoc: codecs: wcd9335: " Srinivas Kandagatla
2020-10-28 21:22 ` [PATCH 1/2] ASoC: codecs: wcd934x: " Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).