* [PATCH -next] phy: cpcap-usb: Use IRQF_ONESHOT
@ 2020-10-28 8:59 Zou Wei
2020-10-28 16:23 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2020-10-28 8:59 UTC (permalink / raw)
To: kishon, vkoul; +Cc: linux-kernel, Zou Wei
Fixes coccicheck error:
./drivers/phy/motorola/phy-cpcap-usb.c:365:9-34: ERROR:
Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/phy/motorola/phy-cpcap-usb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c
index 089db0d..442522b 100644
--- a/drivers/phy/motorola/phy-cpcap-usb.c
+++ b/drivers/phy/motorola/phy-cpcap-usb.c
@@ -364,7 +364,8 @@ static int cpcap_usb_init_irq(struct platform_device *pdev,
error = devm_request_threaded_irq(ddata->dev, irq, NULL,
cpcap_phy_irq_thread,
- IRQF_SHARED,
+ IRQF_SHARED |
+ IRQF_ONESHOT,
name, ddata);
if (error) {
dev_err(ddata->dev, "could not get irq %s: %i\n",
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] phy: cpcap-usb: Use IRQF_ONESHOT
2020-10-28 8:59 [PATCH -next] phy: cpcap-usb: Use IRQF_ONESHOT Zou Wei
@ 2020-10-28 16:23 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-10-28 16:23 UTC (permalink / raw)
To: Zou Wei; +Cc: kishon, linux-kernel
On 28-10-20, 16:59, Zou Wei wrote:
> Fixes coccicheck error:
>
> ./drivers/phy/motorola/phy-cpcap-usb.c:365:9-34: ERROR:
> Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-29 1:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-28 8:59 [PATCH -next] phy: cpcap-usb: Use IRQF_ONESHOT Zou Wei
2020-10-28 16:23 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).