* [PATCH] Staging: rtl8723bs: core: rtw_cmd: Fixed two if-statement coding style issues
@ 2020-10-28 21:28 Manuel Palenzuela
2020-10-29 5:22 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Manuel Palenzuela @ 2020-10-28 21:28 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Manuel Palenzuela
Fixed two cases where the if-statement coding style wasn't following the guidelines. (rtw_cmd.c)
Signed-off-by: Manuel Palenzuela <manuelpalenzuelamerino@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 4cf09d947d32..1723473005e7 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -344,7 +344,7 @@ int rtw_enqueue_cmd(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
cmd_obj->padapter = padapter;
res = rtw_cmd_filter(pcmdpriv, cmd_obj);
- if (_FAIL == res) {
+ if (res == _FAIL) {
rtw_free_cmd_obj(cmd_obj);
goto exit;
}
@@ -460,7 +460,7 @@ int rtw_cmd_thread(void *context)
cmd_start_time = jiffies;
- if (_FAIL == rtw_cmd_filter(pcmdpriv, pcmd)) {
+ if (rtw_cmd_filter(pcmdpriv, pcmd) == _FAIL) {
pcmd->res = H2C_DROPPED;
goto post_process;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: rtl8723bs: core: rtw_cmd: Fixed two if-statement coding style issues
2020-10-28 21:28 [PATCH] Staging: rtl8723bs: core: rtw_cmd: Fixed two if-statement coding style issues Manuel Palenzuela
@ 2020-10-29 5:22 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-10-29 5:22 UTC (permalink / raw)
To: Manuel Palenzuela; +Cc: devel, linux-kernel
On Wed, Oct 28, 2020 at 09:28:37PM +0000, Manuel Palenzuela wrote:
> Fixed two cases where the if-statement coding style wasn't following the guidelines. (rtw_cmd.c)
>
Please properly wrap your changelog comments at 72 columns like your
editor asked you to :)
And what is with the file name in ()?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-29 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-28 21:28 [PATCH] Staging: rtl8723bs: core: rtw_cmd: Fixed two if-statement coding style issues Manuel Palenzuela
2020-10-29 5:22 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).