From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 2/5] net: mscc: ocelot: use ether_addr_copy
Date: Thu, 29 Oct 2020 04:27:35 +0200 [thread overview]
Message-ID: <20201029022738.722794-3-vladimir.oltean@nxp.com> (raw)
In-Reply-To: <20201029022738.722794-1-vladimir.oltean@nxp.com>
Since a helper is available for copying Ethernet addresses, let's use it.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/net/ethernet/mscc/ocelot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
index 25152f1f2939..763d0277eeae 100644
--- a/drivers/net/ethernet/mscc/ocelot.c
+++ b/drivers/net/ethernet/mscc/ocelot.c
@@ -997,7 +997,7 @@ static void ocelot_encode_ports_to_mdb(unsigned char *addr,
struct ocelot_multicast *mc,
enum macaccess_entry_type entry_type)
{
- memcpy(addr, mc->addr, ETH_ALEN);
+ ether_addr_copy(addr, mc->addr);
if (entry_type == ENTRYTYPE_MACv4) {
addr[0] = 0;
@@ -1042,7 +1042,7 @@ int ocelot_port_mdb_add(struct ocelot *ocelot, int port,
if (!mc)
return -ENOMEM;
- memcpy(mc->addr, mdb->addr, ETH_ALEN);
+ ether_addr_copy(mc->addr, mdb->addr);
mc->vid = vid;
mc->pgid = pgid;
--
2.25.1
next prev parent reply other threads:[~2020-10-29 2:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 2:27 [PATCH net-next 0/5] L2 multicast forwarding for Ocelot switch Vladimir Oltean
2020-10-29 2:27 ` [PATCH net-next 1/5] net: mscc: ocelot: classify L2 mdb entries as LOCKED Vladimir Oltean
2020-10-29 2:31 ` Florian Fainelli
2020-10-29 2:27 ` Vladimir Oltean [this message]
2020-10-29 2:32 ` [PATCH net-next 2/5] net: mscc: ocelot: use ether_addr_copy Florian Fainelli
2020-10-29 2:27 ` [PATCH net-next 3/5] net: mscc: ocelot: remove the "new" variable in ocelot_port_mdb_add Vladimir Oltean
2020-10-29 2:32 ` Florian Fainelli
2020-10-29 2:27 ` [PATCH net-next 4/5] net: mscc: ocelot: make entry_type a member of struct ocelot_multicast Vladimir Oltean
2020-10-29 2:37 ` Florian Fainelli
2020-10-29 11:06 ` Vladimir Oltean
2020-10-31 1:16 ` Jakub Kicinski
2020-10-31 9:07 ` Vladimir Oltean
2020-10-29 2:27 ` [PATCH net-next 5/5] net: mscc: ocelot: support L2 multicast entries Vladimir Oltean
2020-10-29 2:41 ` Florian Fainelli
2020-10-31 1:27 ` [PATCH net-next 0/5] L2 multicast forwarding for Ocelot switch Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029022738.722794-3-vladimir.oltean@nxp.com \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).