[PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/accel/da311.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/accel/da311.c b/drivers/iio/accel/da311.c
index 3b3df620ba27..55d4891556ca 100644
--- a/drivers/iio/accel/da311.c
+++ b/drivers/iio/accel/da311.c
@@ -263,7 +263,6 @@ static int da311_remove(struct i2c_client *client)
 	return da311_enable(client, false);
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int da311_suspend(struct device *dev)
 {
 	return da311_enable(to_i2c_client(dev), false);
@@ -273,7 +272,6 @@ static int da311_resume(struct device *dev)
 {
 	return da311_enable(to_i2c_client(dev), true);
 }
-#endif
 
 static SIMPLE_DEV_PM_OPS(da311_pm_ops, da311_suspend, da311_resume);
 
-- 
2.28.0

[PATCH 02/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/accel/da280.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/accel/da280.c b/drivers/iio/accel/da280.c
index 4472dde6899e..c82d241491dd 100644
--- a/drivers/iio/accel/da280.c
+++ b/drivers/iio/accel/da280.c
@@ -160,7 +160,6 @@ static int da280_remove(struct i2c_client *client)
 	return da280_enable(client, false);
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int da280_suspend(struct device *dev)
 {
 	return da280_enable(to_i2c_client(dev), false);
@@ -170,7 +169,6 @@ static int da280_resume(struct device *dev)
 {
 	return da280_enable(to_i2c_client(dev), true);
 }
-#endif
 
 static SIMPLE_DEV_PM_OPS(da280_pm_ops, da280_suspend, da280_resume);
 
-- 
2.28.0

[PATCH 03/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/accel/mma9553.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c
index c15908faa381..1d2e57158b31 100644
--- a/drivers/iio/accel/mma9553.c
+++ b/drivers/iio/accel/mma9553.c
@@ -1197,7 +1197,6 @@ static int mma9553_runtime_resume(struct device *dev)
 }
 #endif
 
-#ifdef CONFIG_PM_SLEEP
 static int mma9553_suspend(struct device *dev)
 {
 	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
@@ -1223,7 +1222,6 @@ static int mma9553_resume(struct device *dev)
 
 	return ret;
 }
-#endif
 
 static const struct dev_pm_ops mma9553_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(mma9553_suspend, mma9553_resume)
-- 
2.28.0

[PATCH 04/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/accel/mc3230.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/accel/mc3230.c b/drivers/iio/accel/mc3230.c
index 46e4283fc037..b966922b9899 100644
--- a/drivers/iio/accel/mc3230.c
+++ b/drivers/iio/accel/mc3230.c
@@ -160,7 +160,6 @@ static int mc3230_remove(struct i2c_client *client)
 	return mc3230_set_opcon(iio_priv(indio_dev), MC3230_MODE_OPCON_STANDBY);
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int mc3230_suspend(struct device *dev)
 {
 	struct mc3230_data *data;
@@ -178,7 +177,6 @@ static int mc3230_resume(struct device *dev)
 
 	return mc3230_set_opcon(data, MC3230_MODE_OPCON_WAKE);
 }
-#endif
 
 static SIMPLE_DEV_PM_OPS(mc3230_pm_ops, mc3230_suspend, mc3230_resume);
 
-- 
2.28.0

[PATCH 05/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/accel/mma9551.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c
index 08a2303cc9df..c3b7a1633907 100644
--- a/drivers/iio/accel/mma9551.c
+++ b/drivers/iio/accel/mma9551.c
@@ -558,7 +558,6 @@ static int mma9551_runtime_resume(struct device *dev)
 }
 #endif
 
-#ifdef CONFIG_PM_SLEEP
 static int mma9551_suspend(struct device *dev)
 {
 	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
@@ -584,7 +583,6 @@ static int mma9551_resume(struct device *dev)
 
 	return ret;
 }
-#endif
 
 static const struct dev_pm_ops mma9551_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(mma9551_suspend, mma9551_resume)
-- 
2.28.0

Re: [PATCH 05/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Andy Shevchenko]

On Thu, Oct 29, 2020 at 11:05 AM Coiby Xu <coiby.xu@gmail.com> wrote:
>
> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Correct grammar and rethink about them.

NAK for all of them.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 05/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

On Thu, Oct 29, 2020 at 01:57:25PM +0200, Andy Shevchenko wrote:
>On Thu, Oct 29, 2020 at 11:05 AM Coiby Xu <coiby.xu@gmail.com> wrote:
>>
>> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
>
>Correct grammar and rethink about them.
>
>NAK for all of them.
>

I'll add __maybe_unused, do the compiling testing for each changed
driver and also correct the typo in v2. Thank you for the feedback!

>--
>With Best Regards,
>Andy Shevchenko

--
Best regards,
Coiby

[PATCH 06/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/accel/dmard10.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/accel/dmard10.c b/drivers/iio/accel/dmard10.c
index 90206f015857..64a15dea2a82 100644
--- a/drivers/iio/accel/dmard10.c
+++ b/drivers/iio/accel/dmard10.c
@@ -224,7 +224,6 @@ static int dmard10_remove(struct i2c_client *client)
 	return dmard10_shutdown(client);
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int dmard10_suspend(struct device *dev)
 {
 	return dmard10_shutdown(to_i2c_client(dev));
@@ -234,7 +233,6 @@ static int dmard10_resume(struct device *dev)
 {
 	return dmard10_reset(to_i2c_client(dev));
 }
-#endif
 
 static SIMPLE_DEV_PM_OPS(dmard10_pm_ops, dmard10_suspend, dmard10_resume);
 
-- 
2.28.0

[PATCH 07/15] iio: ssp: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/common/ssp_sensors/ssp_dev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
index 1aee87100038..e284ff702280 100644
--- a/drivers/iio/common/ssp_sensors/ssp_dev.c
+++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
@@ -612,7 +612,6 @@ static int ssp_remove(struct spi_device *spi)
 	return 0;
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int ssp_suspend(struct device *dev)
 {
 	int ret;
@@ -661,7 +660,6 @@ static int ssp_resume(struct device *dev)
 
 	return 0;
 }
-#endif /* CONFIG_PM_SLEEP */
 
 static const struct dev_pm_ops ssp_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(ssp_suspend, ssp_resume)
-- 
2.28.0

[PATCH 08/15] iio: magnetometer: mmc35240: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/magnetometer/mmc35240.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c
index 65f3d1ed0d59..37d330220433 100644
--- a/drivers/iio/magnetometer/mmc35240.c
+++ b/drivers/iio/magnetometer/mmc35240.c
@@ -521,7 +521,6 @@ static int mmc35240_probe(struct i2c_client *client,
 	return devm_iio_device_register(&client->dev, indio_dev);
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int mmc35240_suspend(struct device *dev)
 {
 	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
@@ -548,7 +547,6 @@ static int mmc35240_resume(struct device *dev)
 
 	return 0;
 }
-#endif
 
 static const struct dev_pm_ops mmc35240_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(mmc35240_suspend, mmc35240_resume)
-- 
2.28.0

[PATCH 09/15] iio: adc: palmas_gpadc: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/adc/palmas_gpadc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c
index 889b88768b63..76bafa5a4bf3 100644
--- a/drivers/iio/adc/palmas_gpadc.c
+++ b/drivers/iio/adc/palmas_gpadc.c
@@ -643,7 +643,6 @@ static int palmas_gpadc_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int palmas_adc_wakeup_configure(struct palmas_gpadc *adc)
 {
 	int adc_period, conv;
@@ -812,7 +811,6 @@ static int palmas_gpadc_resume(struct device *dev)
 
 	return 0;
 };
-#endif
 
 static const struct dev_pm_ops palmas_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(palmas_gpadc_suspend,
-- 
2.28.0

[PATCH 10/15] iio: adc: stm32: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/adc/stm32-adc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
index b3f31f147347..42f9013730f8 100644
--- a/drivers/iio/adc/stm32-adc.c
+++ b/drivers/iio/adc/stm32-adc.c
@@ -1988,7 +1988,6 @@ static int stm32_adc_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#if defined(CONFIG_PM_SLEEP)
 static int stm32_adc_suspend(struct device *dev)
 {
 	struct iio_dev *indio_dev = dev_get_drvdata(dev);
@@ -2018,7 +2017,6 @@ static int stm32_adc_resume(struct device *dev)
 
 	return stm32_adc_buffer_postenable(indio_dev);
 }
-#endif
 
 #if defined(CONFIG_PM)
 static int stm32_adc_runtime_suspend(struct device *dev)
-- 
2.28.0

Re: [PATCH 10/15] iio: adc: stm32: remove unnecessary CONFIG_PM_SLEEP

[Fabrice Gasnier]

On 10/29/20 8:49 AM, Coiby Xu wrote:
> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
> 
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
> ---
>  drivers/iio/adc/stm32-adc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
> index b3f31f147347..42f9013730f8 100644
> --- a/drivers/iio/adc/stm32-adc.c
> +++ b/drivers/iio/adc/stm32-adc.c
> @@ -1988,7 +1988,6 @@ static int stm32_adc_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -#if defined(CONFIG_PM_SLEEP)

Hi Coiby,

This generates warnings when building with W=1 and CONFIG_PM_SLEEP=n.
Could you please add also "__maybe_unused" attribute in suspend / resume
routines below.

>  static int stm32_adc_suspend(struct device *dev)
             ^
e.g. like: static int __maybe_unused stm32_adc_...

>  {
>  	struct iio_dev *indio_dev = dev_get_drvdata(dev);
> @@ -2018,7 +2017,6 @@ static int stm32_adc_resume(struct device *dev)
>  
>  	return stm32_adc_buffer_postenable(indio_dev);
>  }
> -#endif
>  
>  #if defined(CONFIG_PM)

Same could be done also for runtime PM routines. For my own curiosity,
do you plan to do this as well ?

Best regards,
Fabrice
>  static int stm32_adc_runtime_suspend(struct device *dev)
> 

[PATCH 11/15] iio: adc: at91_adc: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/adc/at91_adc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
index 9b2c548fae95..445072b239a6 100644
--- a/drivers/iio/adc/at91_adc.c
+++ b/drivers/iio/adc/at91_adc.c
@@ -1350,7 +1350,6 @@ static int at91_adc_remove(struct platform_device *pdev)
 	return 0;
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int at91_adc_suspend(struct device *dev)
 {
 	struct iio_dev *idev = dev_get_drvdata(dev);
@@ -1372,7 +1371,6 @@ static int at91_adc_resume(struct device *dev)
 
 	return 0;
 }
-#endif
 
 static SIMPLE_DEV_PM_OPS(at91_adc_pm_ops, at91_adc_suspend, at91_adc_resume);
 
-- 
2.28.0

[PATCH 12/15] iio: imu: kmx61: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/imu/kmx61.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
index 61885e99d3fc..3b3d44ea8d24 100644
--- a/drivers/iio/imu/kmx61.c
+++ b/drivers/iio/imu/kmx61.c
@@ -1448,7 +1448,6 @@ static int kmx61_remove(struct i2c_client *client)
 	return 0;
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int kmx61_suspend(struct device *dev)
 {
 	int ret;
@@ -1474,7 +1473,6 @@ static int kmx61_resume(struct device *dev)
 
 	return kmx61_set_mode(data, stby, KMX61_ACC | KMX61_MAG, true);
 }
-#endif
 
 #ifdef CONFIG_PM
 static int kmx61_runtime_suspend(struct device *dev)
-- 
2.28.0

[PATCH 13/15] iio: light: us5182d: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/light/us5182d.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c
index 393f27b75c75..15c6f8db3fdc 100644
--- a/drivers/iio/light/us5182d.c
+++ b/drivers/iio/light/us5182d.c
@@ -918,7 +918,7 @@ static int us5182d_remove(struct i2c_client *client)
 	return us5182d_shutdown_en(data, US5182D_CFG0_SHUTDOWN_EN);
 }
 
-#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM)
+#if defined(CONFIG_PM)
 static int us5182d_suspend(struct device *dev)
 {
 	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
-- 
2.28.0

[PATCH 14/15] iio: light: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/light/pa12203001.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/light/pa12203001.c b/drivers/iio/light/pa12203001.c
index bfade6577a38..7737d2c8f0d5 100644
--- a/drivers/iio/light/pa12203001.c
+++ b/drivers/iio/light/pa12203001.c
@@ -417,14 +417,12 @@ static int pa12203001_suspend(struct device *dev)
 }
 #endif
 
-#ifdef CONFIG_PM_SLEEP
 static int pa12203001_resume(struct device *dev)
 {
 	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
 
 	return pa12203001_power_chip(indio_dev, PA12203001_CHIP_ENABLE);
 }
-#endif
 
 #ifdef CONFIG_PM
 static int pa12203001_runtime_resume(struct device *dev)
-- 
2.28.0

[PATCH 15/15] iio: proximity: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
---
 drivers/iio/proximity/sx9500.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/proximity/sx9500.c b/drivers/iio/proximity/sx9500.c
index acb821cbad46..f4d55d217582 100644
--- a/drivers/iio/proximity/sx9500.c
+++ b/drivers/iio/proximity/sx9500.c
@@ -994,7 +994,6 @@ static int sx9500_remove(struct i2c_client *client)
 	return 0;
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int sx9500_suspend(struct device *dev)
 {
 	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
@@ -1031,7 +1030,6 @@ static int sx9500_resume(struct device *dev)
 
 	return ret;
 }
-#endif /* CONFIG_PM_SLEEP */
 
 static const struct dev_pm_ops sx9500_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(sx9500_suspend, sx9500_resume)
-- 
2.28.0

Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Jonathan Cameron]

On Thu, 29 Oct 2020 15:48:56 +0800
Coiby Xu <coiby.xu@gmail.com> wrote:

> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
> 
> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
Hi Coiby, 

Please put a cover letter on your next series explaining the context.
In this particular case some of the replies you have gotten are
general at it is a lot easier to find these sorts of things via
replying to the cover letter.

Jonathan

> ---
>  drivers/iio/accel/da311.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/da311.c b/drivers/iio/accel/da311.c
> index 3b3df620ba27..55d4891556ca 100644
> --- a/drivers/iio/accel/da311.c
> +++ b/drivers/iio/accel/da311.c
> @@ -263,7 +263,6 @@ static int da311_remove(struct i2c_client *client)
>  	return da311_enable(client, false);
>  }
>  
> -#ifdef CONFIG_PM_SLEEP
>  static int da311_suspend(struct device *dev)
>  {
>  	return da311_enable(to_i2c_client(dev), false);
> @@ -273,7 +272,6 @@ static int da311_resume(struct device *dev)
>  {
>  	return da311_enable(to_i2c_client(dev), true);
>  }
> -#endif
>  
>  static SIMPLE_DEV_PM_OPS(da311_pm_ops, da311_suspend, da311_resume);
>  

Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

HI Jonathan,

On Thu, Oct 29, 2020 at 02:40:07PM +0000, Jonathan Cameron wrote:
>On Thu, 29 Oct 2020 15:48:56 +0800
>Coiby Xu <coiby.xu@gmail.com> wrote:
>
>> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
>>
>> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
>Hi Coiby,
>
>Please put a cover letter on your next series explaining the context.
>In this particular case some of the replies you have gotten are
>general at it is a lot easier to find these sorts of things via
>replying to the cover letter.
>

I will do it in v2. Thank you for the suggestion!

>Jonathan
>
>> ---
>>  drivers/iio/accel/da311.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/iio/accel/da311.c b/drivers/iio/accel/da311.c
>> index 3b3df620ba27..55d4891556ca 100644
>> --- a/drivers/iio/accel/da311.c
>> +++ b/drivers/iio/accel/da311.c
>> @@ -263,7 +263,6 @@ static int da311_remove(struct i2c_client *client)
>>  	return da311_enable(client, false);
>>  }
>>
>> -#ifdef CONFIG_PM_SLEEP
>>  static int da311_suspend(struct device *dev)
>>  {
>>  	return da311_enable(to_i2c_client(dev), false);
>> @@ -273,7 +272,6 @@ static int da311_resume(struct device *dev)
>>  {
>>  	return da311_enable(to_i2c_client(dev), true);
>>  }
>> -#endif
>>
>>  static SIMPLE_DEV_PM_OPS(da311_pm_ops, da311_suspend, da311_resume);
>>
>

--
Best regards,
Coiby

Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Andy Shevchenko]

On Thu, Oct 29, 2020 at 4:42 PM Jonathan Cameron <jic23@kernel.org> wrote:
> On Thu, 29 Oct 2020 15:48:56 +0800
> Coiby Xu <coiby.xu@gmail.com> wrote:

> Please put a cover letter on your next series explaining the context.
> In this particular case some of the replies you have gotten are
> general at it is a lot easier to find these sorts of things via
> replying to the cover letter.

Looking at the number of duplicate messages I would suggest that one
needs to go through documentation on how to use git format-patch and
git send-email.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

On Thu, Oct 29, 2020 at 07:06:40PM +0200, Andy Shevchenko wrote:
>On Thu, Oct 29, 2020 at 4:42 PM Jonathan Cameron <jic23@kernel.org> wrote:
>> On Thu, 29 Oct 2020 15:48:56 +0800
>> Coiby Xu <coiby.xu@gmail.com> wrote:
>
>> Please put a cover letter on your next series explaining the context.
>> In this particular case some of the replies you have gotten are
>> general at it is a lot easier to find these sorts of things via
>> replying to the cover letter.
>
>Looking at the number of duplicate messages I would suggest that one
>needs to go through documentation on how to use git format-patch and
>git send-email.
>

Thank you for the suggestion! Actually it's a tree-wide change and it
seems the kernel community prefer individual patches or series for
subsystems having the same maintainer over a huge patch set so I wrote
some scripts to automate the process. That's why you see ~50 emails
with almost the same commit message. The only difference of these
commit messages is the name of PM macro.

>--
>With Best Regards,
>Andy Shevchenko

--
Best regards,
Coiby

Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Jonathan Cameron]

On Fri, 30 Oct 2020 22:34:10 +0800
Coiby Xu <coiby.xu@gmail.com> wrote:

> On Thu, Oct 29, 2020 at 07:06:40PM +0200, Andy Shevchenko wrote:
> >On Thu, Oct 29, 2020 at 4:42 PM Jonathan Cameron <jic23@kernel.org> wrote:  
> >> On Thu, 29 Oct 2020 15:48:56 +0800
> >> Coiby Xu <coiby.xu@gmail.com> wrote:  
> >  
> >> Please put a cover letter on your next series explaining the context.
> >> In this particular case some of the replies you have gotten are
> >> general at it is a lot easier to find these sorts of things via
> >> replying to the cover letter.  
> >
> >Looking at the number of duplicate messages I would suggest that one
> >needs to go through documentation on how to use git format-patch and
> >git send-email.
> >  
> 
> Thank you for the suggestion! Actually it's a tree-wide change and it
> seems the kernel community prefer individual patches or series for
> subsystems having the same maintainer over a huge patch set so I wrote
> some scripts to automate the process. That's why you see ~50 emails
> with almost the same commit message. The only difference of these
> commit messages is the name of PM macro.

When doing a bit set like this, it's worth sending out a small subset
first to shake out issue like those seen here.

Once those get merged then send out out the reset.

Thanks,

Jonathan

> 
> >--
> >With Best Regards,
> >Andy Shevchenko  
> 
> --
> Best regards,
> Coiby

Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

On Sat, Oct 31, 2020 at 11:05:11AM +0000, Jonathan Cameron wrote:
>On Fri, 30 Oct 2020 22:34:10 +0800
>Coiby Xu <coiby.xu@gmail.com> wrote:
>
>> On Thu, Oct 29, 2020 at 07:06:40PM +0200, Andy Shevchenko wrote:
>> >On Thu, Oct 29, 2020 at 4:42 PM Jonathan Cameron <jic23@kernel.org> wrote:
>> >> On Thu, 29 Oct 2020 15:48:56 +0800
>> >> Coiby Xu <coiby.xu@gmail.com> wrote:
>> >
>> >> Please put a cover letter on your next series explaining the context.
>> >> In this particular case some of the replies you have gotten are
>> >> general at it is a lot easier to find these sorts of things via
>> >> replying to the cover letter.
>> >
>> >Looking at the number of duplicate messages I would suggest that one
>> >needs to go through documentation on how to use git format-patch and
>> >git send-email.
>> >
>>
>> Thank you for the suggestion! Actually it's a tree-wide change and it
>> seems the kernel community prefer individual patches or series for
>> subsystems having the same maintainer over a huge patch set so I wrote
>> some scripts to automate the process. That's why you see ~50 emails
>> with almost the same commit message. The only difference of these
>> commit messages is the name of PM macro.
>
>When doing a bit set like this, it's worth sending out a small subset
>first to shake out issue like those seen here.
>
>Once those get merged then send out out the reset.
>
Thank you for the suggestion! Actually I've held off another ~150
emails and these ~200 emails were only part of work. I thought it's
better to reach 4 or 5 subsystem to collect sufficient feedbacks
considering some subsystems may respond slow. But I didn't realize a
better way is to cut down the size of patch set sent to a subsystem.
>Thanks,
>
>Jonathan
>
>>
>> >--
>> >With Best Regards,
>> >Andy Shevchenko
>>
>> --
>> Best regards,
>> Coiby
>

--
Best regards,
Coiby

Re: [PATCH 01/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Jonathan Cameron]

On Sun, 1 Nov 2020 06:47:35 +0800
Coiby Xu <coiby.xu@gmail.com> wrote:

> On Sat, Oct 31, 2020 at 11:05:11AM +0000, Jonathan Cameron wrote:
> >On Fri, 30 Oct 2020 22:34:10 +0800
> >Coiby Xu <coiby.xu@gmail.com> wrote:
> >  
> >> On Thu, Oct 29, 2020 at 07:06:40PM +0200, Andy Shevchenko wrote:  
> >> >On Thu, Oct 29, 2020 at 4:42 PM Jonathan Cameron <jic23@kernel.org> wrote:  
> >> >> On Thu, 29 Oct 2020 15:48:56 +0800
> >> >> Coiby Xu <coiby.xu@gmail.com> wrote:  
> >> >  
> >> >> Please put a cover letter on your next series explaining the context.
> >> >> In this particular case some of the replies you have gotten are
> >> >> general at it is a lot easier to find these sorts of things via
> >> >> replying to the cover letter.  
> >> >
> >> >Looking at the number of duplicate messages I would suggest that one
> >> >needs to go through documentation on how to use git format-patch and
> >> >git send-email.
> >> >  
> >>
> >> Thank you for the suggestion! Actually it's a tree-wide change and it
> >> seems the kernel community prefer individual patches or series for
> >> subsystems having the same maintainer over a huge patch set so I wrote
> >> some scripts to automate the process. That's why you see ~50 emails
> >> with almost the same commit message. The only difference of these
> >> commit messages is the name of PM macro.  
> >
> >When doing a bit set like this, it's worth sending out a small subset
> >first to shake out issue like those seen here.
> >
> >Once those get merged then send out out the reset.
> >  
> Thank you for the suggestion! Actually I've held off another ~150
> emails and these ~200 emails were only part of work. I thought it's
> better to reach 4 or 5 subsystem to collect sufficient feedbacks
> considering some subsystems may respond slow. But I didn't realize a
> better way is to cut down the size of patch set sent to a subsystem.

Keep it sub 20 per subsystem and it shouldn't matter too much, but perhaps
always send to just one subsystem first as you may get very fast responses!

Then if it looks good after a few days, your approach of targeting a few
more subsystems would make sense.

Jonathan

> >Thanks,
> >
> >Jonathan
> >  
> >>  
> >> >--
> >> >With Best Regards,
> >> >Andy Shevchenko  
> >>
> >> --
> >> Best regards,
> >> Coiby  
> >  
> 
> --
> Best regards,
> Coiby