From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1] pinctrl: intel: Add Intel Alder Lake pin controller support
Date: Thu, 29 Oct 2020 10:08:27 +0200 [thread overview]
Message-ID: <20201029080827.GN2495@lahna.fi.intel.com> (raw)
In-Reply-To: <20201026192552.20903-1-andriy.shevchenko@linux.intel.com>
Hi,
I think the $subject should say "Alder Lake-S" as this is for -S
variant.
On Mon, Oct 26, 2020 at 09:25:52PM +0200, Andy Shevchenko wrote:
> This driver adds pinctrl/GPIO support for Intel Alder Lake SoC. The
> GPIO controller is based on the next generation GPIO hardware but still
> compatible with the one supported by the Intel core pinctrl/GPIO driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pinctrl/intel/Kconfig | 9 +
> drivers/pinctrl/intel/Makefile | 1 +
> drivers/pinctrl/intel/pinctrl-alderlake.c | 437 ++++++++++++++++++++++
> 3 files changed, 447 insertions(+)
> create mode 100644 drivers/pinctrl/intel/pinctrl-alderlake.c
>
> diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig
> index b9d78a4187e0..98494c8fdaf8 100644
> --- a/drivers/pinctrl/intel/Kconfig
> +++ b/drivers/pinctrl/intel/Kconfig
> @@ -70,6 +70,14 @@ config PINCTRL_INTEL
> select GPIOLIB
> select GPIOLIB_IRQCHIP
>
> +config PINCTRL_ALDERLAKE
> + tristate "Intel Alder Lake pinctrl and GPIO driver"
> + depends on ACPI
> + select PINCTRL_INTEL
> + help
> + This pinctrl driver provides an interface that allows configuring
> + of Intel Alder Lake PCH pins and using them as GPIOs.
> +
> config PINCTRL_BROXTON
> tristate "Intel Broxton pinctrl and GPIO driver"
> depends on ACPI
> @@ -158,4 +166,5 @@ config PINCTRL_TIGERLAKE
> help
> This pinctrl driver provides an interface that allows configuring
> of Intel Tiger Lake PCH pins and using them as GPIOs.
> +
Is this intentional ws change?
> endif
Otherwise looks good to me.
next prev parent reply other threads:[~2020-10-29 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 19:25 [PATCH v1] pinctrl: intel: Add Intel Alder Lake pin controller support Andy Shevchenko
2020-10-29 8:08 ` Mika Westerberg [this message]
2020-10-29 10:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029080827.GN2495@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).