From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1] pinctrl: intel: Add Intel Alder Lake pin controller support
Date: Thu, 29 Oct 2020 12:00:38 +0200 [thread overview]
Message-ID: <20201029100038.GE4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201029080827.GN2495@lahna.fi.intel.com>
On Thu, Oct 29, 2020 at 10:08:27AM +0200, Mika Westerberg wrote:
> I think the $subject should say "Alder Lake-S" as this is for -S
> variant.
OK!
...
> > @@ -158,4 +166,5 @@ config PINCTRL_TIGERLAKE
> > help
> > This pinctrl driver provides an interface that allows configuring
> > of Intel Tiger Lake PCH pins and using them as GPIOs.
> > +
>
> Is this intentional ws change?
I guess it was intentional at some point, but not strictly related to this new
driver. I can split it out.
> > endif
>
> Otherwise looks good to me.
I'll send v2 soon.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-10-29 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 19:25 [PATCH v1] pinctrl: intel: Add Intel Alder Lake pin controller support Andy Shevchenko
2020-10-29 8:08 ` Mika Westerberg
2020-10-29 10:00 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029100038.GE4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).