* Re: [PATCH 02/17] phy: amlogic: convert to devm_platform_ioremap_resource
[not found] ` <1603940079-8131-2-git-send-email-chunfeng.yun@mediatek.com>
@ 2020-10-29 8:24 ` Remi Pommarel
2020-10-30 3:46 ` Chunfeng Yun
0 siblings, 1 reply; 7+ messages in thread
From: Remi Pommarel @ 2020-10-29 8:24 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Kishon Vijay Abraham I, Vinod Koul, Maxime Ripard, Chen-Yu Tsai,
Kevin Hilman, Neil Armstrong, Jerome Brunet, Martin Blumenstingl,
Ray Jui, Scott Branden, bcm-kernel-feedback-list,
Florian Fainelli, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Lubomir Rintel, Matthias Brugger, Randy Dunlap,
Krzysztof Kozlowski, Colin Ian King, Ondrej Jirman,
Rikard Falkeborn, Icenowy Zheng, Lorenzo Pieralisi, Yue Wang,
Hanjie Lin, Joe Perches, Bharat Gooty, Rayagonda Kokatanur,
Peter Chen, Roger Quadros, Jyri Sarha, Sanket Parmar,
Anil Varughese, Li Jun, Ma Feng, Wei Yongjun, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek
Hi,
On Thu, Oct 29, 2020 at 10:54:24AM +0800, Chunfeng Yun wrote:
> Use devm_platform_ioremap_resource to simplify code
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c | 4 +---
> drivers/phy/amlogic/phy-meson-axg-pcie.c | 4 +---
> drivers/phy/amlogic/phy-meson-g12a-usb2.c | 4 +---
> drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c | 4 +---
> drivers/phy/amlogic/phy-meson-gxl-usb2.c | 4 +---
> 5 files changed, 5 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
> index 1431cbf885e1..7d06cda329fb 100644
> --- a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
> +++ b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
> @@ -126,7 +126,6 @@ static int phy_axg_mipi_pcie_analog_probe(struct platform_device *pdev)
> struct phy_axg_mipi_pcie_analog_priv *priv;
> struct device_node *np = dev->of_node;
> struct regmap *map;
> - struct resource *res;
> void __iomem *base;
> int ret;
>
> @@ -134,8 +133,7 @@ static int phy_axg_mipi_pcie_analog_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base)) {
> dev_err(dev, "failed to get regmap base\n");
> return PTR_ERR(base);
This patch will conflict with [0] that uses syscon to map those shared
resources instead and that is hopefully going to be merged soon.
So I think you can skip this file.
> diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c
> index 377ed0dcd0d9..58a7507a8422 100644
> --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c
> +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c
> @@ -129,7 +129,6 @@ static int phy_axg_pcie_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct phy_axg_pcie_priv *priv;
> struct device_node *np = dev->of_node;
> - struct resource *res;
> void __iomem *base;
> int ret;
>
> @@ -145,8 +144,7 @@ static int phy_axg_pcie_probe(struct platform_device *pdev)
> return ret;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
> diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c b/drivers/phy/amlogic/phy-meson-g12a-usb2.c
> index b26e30e1afaf..9d1efa0d9394 100644
> --- a/drivers/phy/amlogic/phy-meson-g12a-usb2.c
> +++ b/drivers/phy/amlogic/phy-meson-g12a-usb2.c
> @@ -292,7 +292,6 @@ static int phy_meson_g12a_usb2_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct phy_provider *phy_provider;
> - struct resource *res;
> struct phy_meson_g12a_usb2_priv *priv;
> struct phy *phy;
> void __iomem *base;
> @@ -305,8 +304,7 @@ static int phy_meson_g12a_usb2_probe(struct platform_device *pdev)
> priv->dev = dev;
> platform_set_drvdata(pdev, priv);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
> diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> index 08e322789e59..ebe3d0ddd304 100644
> --- a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> +++ b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> @@ -386,7 +386,6 @@ static int phy_g12a_usb3_pcie_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct device_node *np = dev->of_node;
> struct phy_g12a_usb3_pcie_priv *priv;
> - struct resource *res;
> struct phy_provider *phy_provider;
> void __iomem *base;
> int ret;
> @@ -395,8 +394,7 @@ static int phy_g12a_usb3_pcie_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
> diff --git a/drivers/phy/amlogic/phy-meson-gxl-usb2.c b/drivers/phy/amlogic/phy-meson-gxl-usb2.c
> index 43ec9bf24abf..875afb2672c7 100644
> --- a/drivers/phy/amlogic/phy-meson-gxl-usb2.c
> +++ b/drivers/phy/amlogic/phy-meson-gxl-usb2.c
> @@ -230,7 +230,6 @@ static int phy_meson_gxl_usb2_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct phy_provider *phy_provider;
> - struct resource *res;
> struct phy_meson_gxl_usb2_priv *priv;
> struct phy *phy;
> void __iomem *base;
> @@ -242,8 +241,7 @@ static int phy_meson_gxl_usb2_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, priv);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
So without the modification on phy-meson-axg-mipi-pcie-analog.c and
FWIW,
Reviewed-by: Remi Pommarel <repk@triplefau.lt>
Thanks,
[0] https://patchwork.kernel.org/project/linux-amlogic/patch/20200915130339.11079-4-narmstrong@baylibre.com/
--
Remi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 15/17] phy: phy-stm32-usbphyc: convert to devm_platform_ioremap_resource
[not found] ` <1603940079-8131-15-git-send-email-chunfeng.yun@mediatek.com>
@ 2020-10-29 10:20 ` Amelie DELAUNAY
0 siblings, 0 replies; 7+ messages in thread
From: Amelie DELAUNAY @ 2020-10-29 10:20 UTC (permalink / raw)
To: Chunfeng Yun, Kishon Vijay Abraham I, Vinod Koul
Cc: Ondrej Jirman, Peter Chen, Neil Armstrong, Anil Varughese,
Wei Yongjun, Lorenzo Pieralisi, Fabio Estevam, Jerome Brunet,
Florian Fainelli, Kevin Hilman, Krzysztof Kozlowski,
Rayagonda Kokatanur, Chen-Yu Tsai, bcm-kernel-feedback-list,
NXP Linux Team, Icenowy Zheng, Bharat Gooty, Martin Blumenstingl,
Ray Jui, Sascha Hauer, Maxime Ripard, Yue Wang, Lubomir Rintel,
Remi Pommarel, linux-mediatek, Rikard Falkeborn,
Matthias Brugger, linux-amlogic, linux-arm-kernel, Roger Quadros,
Hanjie Lin, Ma Feng, Scott Branden, Randy Dunlap, Jyri Sarha,
linux-kernel, Sanket Parmar, Pengutronix Kernel Team,
Joe Perches, Colin Ian King, Shawn Guo, Li Jun
On 10/29/20 3:54 AM, Chunfeng Yun wrote:
> Use devm_platform_ioremap_resource to simplify code
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Reviewed-by: Amelie Delaunay <amelie.delaunay@st.com>
> ---
> drivers/phy/st/phy-stm32-usbphyc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
> index 2b3639cba51a..0ab18f2078db 100644
> --- a/drivers/phy/st/phy-stm32-usbphyc.c
> +++ b/drivers/phy/st/phy-stm32-usbphyc.c
> @@ -311,7 +311,6 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
> struct stm32_usbphyc *usbphyc;
> struct device *dev = &pdev->dev;
> struct device_node *child, *np = dev->of_node;
> - struct resource *res;
> struct phy_provider *phy_provider;
> u32 version;
> int ret, port = 0;
> @@ -322,8 +321,7 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
> usbphyc->dev = dev;
> dev_set_drvdata(dev, usbphyc);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - usbphyc->base = devm_ioremap_resource(dev, res);
> + usbphyc->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(usbphyc->base))
> return PTR_ERR(usbphyc->base);
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 04/17] phy: cadence: convert to devm_platform_ioremap_resource
[not found] ` <1603940079-8131-4-git-send-email-chunfeng.yun@mediatek.com>
@ 2020-10-29 10:50 ` Peter Chen
0 siblings, 0 replies; 7+ messages in thread
From: Peter Chen @ 2020-10-29 10:50 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Kishon Vijay Abraham I, Vinod Koul, Maxime Ripard, Chen-Yu Tsai,
Kevin Hilman, Neil Armstrong, Jerome Brunet, Martin Blumenstingl,
Ray Jui, Scott Branden, bcm-kernel-feedback-list,
Florian Fainelli, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, dl-linux-imx,
Lubomir Rintel, Matthias Brugger, Randy Dunlap,
Krzysztof Kozlowski, Colin Ian King, Ondrej Jirman,
Rikard Falkeborn, Icenowy Zheng, Remi Pommarel,
Lorenzo Pieralisi, Yue Wang, Hanjie Lin, Joe Perches,
Bharat Gooty, Rayagonda Kokatanur, Roger Quadros, Jyri Sarha,
Sanket Parmar, Anil Varughese, Jun Li, Ma Feng, Wei Yongjun,
linux-kernel, linux-arm-kernel, linux-amlogic, linux-mediatek
On 20-10-29 10:54:26, Chunfeng Yun wrote:
> Use devm_platform_ioremap_resource to simplify code
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/phy/cadence/cdns-dphy.c | 4 +---
> drivers/phy/cadence/phy-cadence-salvo.c | 4 +---
> drivers/phy/cadence/phy-cadence-sierra.c | 4 +---
> 3 files changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dphy.c
> index 90c4e9b5aac8..ba042e39cfaf 100644
> --- a/drivers/phy/cadence/cdns-dphy.c
> +++ b/drivers/phy/cadence/cdns-dphy.c
> @@ -314,7 +314,6 @@ static int cdns_dphy_probe(struct platform_device *pdev)
> {
> struct phy_provider *phy_provider;
> struct cdns_dphy *dphy;
> - struct resource *res;
> int ret;
>
> dphy = devm_kzalloc(&pdev->dev, sizeof(*dphy), GFP_KERNEL);
> @@ -326,8 +325,7 @@ static int cdns_dphy_probe(struct platform_device *pdev)
> if (!dphy->ops)
> return -EINVAL;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - dphy->regs = devm_ioremap_resource(&pdev->dev, res);
> + dphy->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(dphy->regs))
> return PTR_ERR(dphy->regs);
>
> diff --git a/drivers/phy/cadence/phy-cadence-salvo.c b/drivers/phy/cadence/phy-cadence-salvo.c
> index 88e239adc3b8..51c0b98f5fd7 100644
> --- a/drivers/phy/cadence/phy-cadence-salvo.c
> +++ b/drivers/phy/cadence/phy-cadence-salvo.c
> @@ -263,7 +263,6 @@ static int cdns_salvo_phy_probe(struct platform_device *pdev)
> struct phy_provider *phy_provider;
> struct device *dev = &pdev->dev;
> struct cdns_salvo_phy *salvo_phy;
> - struct resource *res;
> const struct of_device_id *match;
> struct cdns_salvo_data *data;
>
> @@ -281,8 +280,7 @@ static int cdns_salvo_phy_probe(struct platform_device *pdev)
> if (IS_ERR(salvo_phy->clk))
> return PTR_ERR(salvo_phy->clk);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - salvo_phy->base = devm_ioremap_resource(dev, res);
> + salvo_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(salvo_phy->base))
> return PTR_ERR(salvo_phy->base);
>
> diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c
> index 453ef26fa1c7..26a0badabe38 100644
> --- a/drivers/phy/cadence/phy-cadence-sierra.c
> +++ b/drivers/phy/cadence/phy-cadence-sierra.c
> @@ -479,7 +479,6 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev)
> const struct of_device_id *match;
> struct cdns_sierra_data *data;
> unsigned int id_value;
> - struct resource *res;
> int i, ret, node = 0;
> void __iomem *base;
> struct clk *clk;
> @@ -502,8 +501,7 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev)
> sp->dev = dev;
> sp->init_data = data;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base)) {
> dev_err(dev, "missing \"reg\"\n");
> return PTR_ERR(base);
> --
> 2.18.0
Acked-by: Peter Chen <peter.chen@nxp.com> for phy-cadence-salvo.c.
--
Thanks,
Peter Chen
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 05/17] phy: freescale: convert to devm_platform_ioremap_resource
[not found] ` <1603940079-8131-5-git-send-email-chunfeng.yun@mediatek.com>
@ 2020-10-29 10:51 ` Peter Chen
0 siblings, 0 replies; 7+ messages in thread
From: Peter Chen @ 2020-10-29 10:51 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Kishon Vijay Abraham I, Vinod Koul, Maxime Ripard, Chen-Yu Tsai,
Kevin Hilman, Neil Armstrong, Jerome Brunet, Martin Blumenstingl,
Ray Jui, Scott Branden, bcm-kernel-feedback-list,
Florian Fainelli, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, dl-linux-imx,
Lubomir Rintel, Matthias Brugger, Randy Dunlap,
Krzysztof Kozlowski, Colin Ian King, Ondrej Jirman,
Rikard Falkeborn, Icenowy Zheng, Remi Pommarel,
Lorenzo Pieralisi, Yue Wang, Hanjie Lin, Joe Perches,
Bharat Gooty, Rayagonda Kokatanur, Roger Quadros, Jyri Sarha,
Sanket Parmar, Anil Varughese, Jun Li, Ma Feng, Wei Yongjun,
linux-kernel, linux-arm-kernel, linux-amlogic, linux-mediatek
On 20-10-29 10:54:27, Chunfeng Yun wrote:
> Use devm_platform_ioremap_resource to simplify code
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 4 +---
> drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> index 9f2c1da14f5a..a95572b397ca 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> @@ -434,7 +434,6 @@ static int mixel_dphy_probe(struct platform_device *pdev)
> struct device_node *np = dev->of_node;
> struct phy_provider *phy_provider;
> struct mixel_dphy_priv *priv;
> - struct resource *res;
> struct phy *phy;
> void __iomem *base;
>
> @@ -449,8 +448,7 @@ static int mixel_dphy_probe(struct platform_device *pdev)
> if (!priv->devdata)
> return -EINVAL;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(dev, res);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
> diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> index 62d6d6849ad6..0b9ee2b1716f 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> @@ -152,7 +152,6 @@ static int imx8mq_usb_phy_probe(struct platform_device *pdev)
> struct phy_provider *phy_provider;
> struct device *dev = &pdev->dev;
> struct imx8mq_usb_phy *imx_phy;
> - struct resource *res;
> const struct phy_ops *phy_ops;
>
> imx_phy = devm_kzalloc(dev, sizeof(*imx_phy), GFP_KERNEL);
> @@ -165,8 +164,7 @@ static int imx8mq_usb_phy_probe(struct platform_device *pdev)
> return PTR_ERR(imx_phy->clk);
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - imx_phy->base = devm_ioremap_resource(dev, res);
> + imx_phy->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(imx_phy->base))
> return PTR_ERR(imx_phy->base);
>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
--
Thanks,
Peter Chen
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 14/17] phy: samsung: convert to devm_platform_ioremap_resource
[not found] ` <1603940079-8131-14-git-send-email-chunfeng.yun@mediatek.com>
@ 2020-10-29 16:50 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-29 16:50 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Kishon Vijay Abraham I, Vinod Koul, Maxime Ripard, Chen-Yu Tsai,
Kevin Hilman, Neil Armstrong, Jerome Brunet, Martin Blumenstingl,
Ray Jui, Scott Branden, bcm-kernel-feedback-list,
Florian Fainelli, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Lubomir Rintel, Matthias Brugger, Randy Dunlap, Colin Ian King,
Ondrej Jirman, Rikard Falkeborn, Icenowy Zheng, Remi Pommarel,
Lorenzo Pieralisi, Yue Wang, Hanjie Lin, Joe Perches,
Bharat Gooty, Rayagonda Kokatanur, Peter Chen, Roger Quadros,
Jyri Sarha, Sanket Parmar, Anil Varughese, Li Jun, Ma Feng,
Wei Yongjun, linux-kernel, linux-arm-kernel, linux-amlogic,
linux-mediatek
On Thu, Oct 29, 2020 at 10:54:36AM +0800, Chunfeng Yun wrote:
> Use devm_platform_ioremap_resource to simplify code
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
> drivers/phy/samsung/phy-exynos-pcie.c | 7 ++-----
> drivers/phy/samsung/phy-exynos5-usbdrd.c | 4 +---
> drivers/phy/samsung/phy-exynos5250-sata.c | 5 +----
> drivers/phy/samsung/phy-samsung-usb2.c | 4 +---
> 4 files changed, 5 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/phy/samsung/phy-exynos-pcie.c b/drivers/phy/samsung/phy-exynos-pcie.c
> index 7e28b1aea0d1..c98fff5c1ac8 100644
> --- a/drivers/phy/samsung/phy-exynos-pcie.c
> +++ b/drivers/phy/samsung/phy-exynos-pcie.c
> @@ -232,7 +232,6 @@ static int exynos_pcie_phy_probe(struct platform_device *pdev)
> struct exynos_pcie_phy *exynos_phy;
> struct phy *generic_phy;
> struct phy_provider *phy_provider;
> - struct resource *res;
> const struct exynos_pcie_phy_data *drv_data;
>
> drv_data = of_device_get_match_data(dev);
> @@ -243,13 +242,11 @@ static int exynos_pcie_phy_probe(struct platform_device *pdev)
> if (!exynos_phy)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - exynos_phy->phy_base = devm_ioremap_resource(dev, res);
> + exynos_phy->phy_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(exynos_phy->phy_base))
> return PTR_ERR(exynos_phy->phy_base);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> - exynos_phy->blk_base = devm_ioremap_resource(dev, res);
> + exynos_phy->blk_base = devm_platform_ioremap_resource(pdev, 1);
> if (IS_ERR(exynos_phy->blk_base))
> return PTR_ERR(exynos_phy->blk_base);
>
> diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> index cfa9b8b7e5ac..ee0848fe8432 100644
> --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> @@ -829,7 +829,6 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
> struct device_node *node = dev->of_node;
> struct exynos5_usbdrd_phy *phy_drd;
> struct phy_provider *phy_provider;
> - struct resource *res;
> const struct exynos5_usbdrd_phy_drvdata *drv_data;
> struct regmap *reg_pmu;
> u32 pmu_offset;
> @@ -843,8 +842,7 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
> dev_set_drvdata(dev, phy_drd);
> phy_drd->dev = dev;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - phy_drd->reg_phy = devm_ioremap_resource(dev, res);
> + phy_drd->reg_phy = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(phy_drd->reg_phy))
> return PTR_ERR(phy_drd->reg_phy);
>
> diff --git a/drivers/phy/samsung/phy-exynos5250-sata.c b/drivers/phy/samsung/phy-exynos5250-sata.c
> index 4dd7324d91b2..9ec234243f7c 100644
> --- a/drivers/phy/samsung/phy-exynos5250-sata.c
> +++ b/drivers/phy/samsung/phy-exynos5250-sata.c
> @@ -162,7 +162,6 @@ static int exynos_sata_phy_probe(struct platform_device *pdev)
> {
> struct exynos_sata_phy *sata_phy;
> struct device *dev = &pdev->dev;
> - struct resource *res;
> struct phy_provider *phy_provider;
> struct device_node *node;
> int ret = 0;
> @@ -171,9 +170,7 @@ static int exynos_sata_phy_probe(struct platform_device *pdev)
> if (!sata_phy)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> - sata_phy->regs = devm_ioremap_resource(dev, res);
> + sata_phy->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(sata_phy->regs))
> return PTR_ERR(sata_phy->regs);
>
> diff --git a/drivers/phy/samsung/phy-samsung-usb2.c b/drivers/phy/samsung/phy-samsung-usb2.c
> index a3ed3ff04690..f79f605cff79 100644
> --- a/drivers/phy/samsung/phy-samsung-usb2.c
> +++ b/drivers/phy/samsung/phy-samsung-usb2.c
> @@ -143,7 +143,6 @@ static int samsung_usb2_phy_probe(struct platform_device *pdev)
> const struct samsung_usb2_phy_config *cfg;
> struct device *dev = &pdev->dev;
> struct phy_provider *phy_provider;
> - struct resource *mem;
> struct samsung_usb2_phy_driver *drv;
> int i, ret;
>
> @@ -167,8 +166,7 @@ static int samsung_usb2_phy_probe(struct platform_device *pdev)
> drv->cfg = cfg;
> drv->dev = dev;
>
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - drv->reg_phy = devm_ioremap_resource(dev, mem);
> + drv->reg_phy = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(drv->reg_phy)) {
> dev_err(dev, "Failed to map register memory (phy)\n");
> return PTR_ERR(drv->reg_phy);
> --
> 2.18.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 02/17] phy: amlogic: convert to devm_platform_ioremap_resource
2020-10-29 8:24 ` [PATCH 02/17] phy: amlogic: convert to devm_platform_ioremap_resource Remi Pommarel
@ 2020-10-30 3:46 ` Chunfeng Yun
0 siblings, 0 replies; 7+ messages in thread
From: Chunfeng Yun @ 2020-10-30 3:46 UTC (permalink / raw)
To: Remi Pommarel
Cc: Kishon Vijay Abraham I, Vinod Koul, Maxime Ripard, Chen-Yu Tsai,
Kevin Hilman, Neil Armstrong, Jerome Brunet, Martin Blumenstingl,
Ray Jui, Scott Branden, bcm-kernel-feedback-list,
Florian Fainelli, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Lubomir Rintel, Matthias Brugger, Randy Dunlap,
Krzysztof Kozlowski, Colin Ian King, Ondrej Jirman,
Rikard Falkeborn, Icenowy Zheng, Lorenzo Pieralisi, Yue Wang,
Hanjie Lin, Joe Perches, Bharat Gooty, Rayagonda Kokatanur,
Peter Chen, Roger Quadros, Jyri Sarha, Sanket Parmar,
Anil Varughese, Li Jun, Ma Feng, Wei Yongjun, linux-kernel,
linux-arm-kernel, linux-amlogic, linux-mediatek
On Thu, 2020-10-29 at 09:24 +0100, Remi Pommarel wrote:
> Hi,
>
> On Thu, Oct 29, 2020 at 10:54:24AM +0800, Chunfeng Yun wrote:
> > Use devm_platform_ioremap_resource to simplify code
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c | 4 +---
> > drivers/phy/amlogic/phy-meson-axg-pcie.c | 4 +---
> > drivers/phy/amlogic/phy-meson-g12a-usb2.c | 4 +---
> > drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c | 4 +---
> > drivers/phy/amlogic/phy-meson-gxl-usb2.c | 4 +---
> > 5 files changed, 5 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
> > index 1431cbf885e1..7d06cda329fb 100644
> > --- a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
> > +++ b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
> > @@ -126,7 +126,6 @@ static int phy_axg_mipi_pcie_analog_probe(struct platform_device *pdev)
> > struct phy_axg_mipi_pcie_analog_priv *priv;
> > struct device_node *np = dev->of_node;
> > struct regmap *map;
> > - struct resource *res;
> > void __iomem *base;
> > int ret;
> >
> > @@ -134,8 +133,7 @@ static int phy_axg_mipi_pcie_analog_probe(struct platform_device *pdev)
> > if (!priv)
> > return -ENOMEM;
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - base = devm_ioremap_resource(dev, res);
> > + base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(base)) {
> > dev_err(dev, "failed to get regmap base\n");
> > return PTR_ERR(base);
>
> This patch will conflict with [0] that uses syscon to map those shared
> resources instead and that is hopefully going to be merged soon.
>
> So I think you can skip this file.
Ok, will drop it, thanks
>
> > diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c
> > index 377ed0dcd0d9..58a7507a8422 100644
> > --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c
> > +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c
> > @@ -129,7 +129,6 @@ static int phy_axg_pcie_probe(struct platform_device *pdev)
> > struct device *dev = &pdev->dev;
> > struct phy_axg_pcie_priv *priv;
> > struct device_node *np = dev->of_node;
> > - struct resource *res;
> > void __iomem *base;
> > int ret;
> >
> > @@ -145,8 +144,7 @@ static int phy_axg_pcie_probe(struct platform_device *pdev)
> > return ret;
> > }
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - base = devm_ioremap_resource(dev, res);
> > + base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(base))
> > return PTR_ERR(base);
> >
> > diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c b/drivers/phy/amlogic/phy-meson-g12a-usb2.c
> > index b26e30e1afaf..9d1efa0d9394 100644
> > --- a/drivers/phy/amlogic/phy-meson-g12a-usb2.c
> > +++ b/drivers/phy/amlogic/phy-meson-g12a-usb2.c
> > @@ -292,7 +292,6 @@ static int phy_meson_g12a_usb2_probe(struct platform_device *pdev)
> > {
> > struct device *dev = &pdev->dev;
> > struct phy_provider *phy_provider;
> > - struct resource *res;
> > struct phy_meson_g12a_usb2_priv *priv;
> > struct phy *phy;
> > void __iomem *base;
> > @@ -305,8 +304,7 @@ static int phy_meson_g12a_usb2_probe(struct platform_device *pdev)
> > priv->dev = dev;
> > platform_set_drvdata(pdev, priv);
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - base = devm_ioremap_resource(dev, res);
> > + base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(base))
> > return PTR_ERR(base);
> >
> > diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> > index 08e322789e59..ebe3d0ddd304 100644
> > --- a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> > +++ b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> > @@ -386,7 +386,6 @@ static int phy_g12a_usb3_pcie_probe(struct platform_device *pdev)
> > struct device *dev = &pdev->dev;
> > struct device_node *np = dev->of_node;
> > struct phy_g12a_usb3_pcie_priv *priv;
> > - struct resource *res;
> > struct phy_provider *phy_provider;
> > void __iomem *base;
> > int ret;
> > @@ -395,8 +394,7 @@ static int phy_g12a_usb3_pcie_probe(struct platform_device *pdev)
> > if (!priv)
> > return -ENOMEM;
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - base = devm_ioremap_resource(dev, res);
> > + base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(base))
> > return PTR_ERR(base);
> >
> > diff --git a/drivers/phy/amlogic/phy-meson-gxl-usb2.c b/drivers/phy/amlogic/phy-meson-gxl-usb2.c
> > index 43ec9bf24abf..875afb2672c7 100644
> > --- a/drivers/phy/amlogic/phy-meson-gxl-usb2.c
> > +++ b/drivers/phy/amlogic/phy-meson-gxl-usb2.c
> > @@ -230,7 +230,6 @@ static int phy_meson_gxl_usb2_probe(struct platform_device *pdev)
> > {
> > struct device *dev = &pdev->dev;
> > struct phy_provider *phy_provider;
> > - struct resource *res;
> > struct phy_meson_gxl_usb2_priv *priv;
> > struct phy *phy;
> > void __iomem *base;
> > @@ -242,8 +241,7 @@ static int phy_meson_gxl_usb2_probe(struct platform_device *pdev)
> >
> > platform_set_drvdata(pdev, priv);
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - base = devm_ioremap_resource(dev, res);
> > + base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(base))
> > return PTR_ERR(base);
> >
>
> So without the modification on phy-meson-axg-mipi-pcie-analog.c and
> FWIW,
>
> Reviewed-by: Remi Pommarel <repk@triplefau.lt>
>
> Thanks,
>
> [0] https://patchwork.kernel.org/project/linux-amlogic/patch/20200915130339.11079-4-narmstrong@baylibre.com/
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 03/17] phy: broadcom: convert to devm_platform_ioremap_resource(_byname)
[not found] ` <1603940079-8131-3-git-send-email-chunfeng.yun@mediatek.com>
@ 2020-10-30 3:49 ` Florian Fainelli
0 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2020-10-30 3:49 UTC (permalink / raw)
To: Chunfeng Yun, Kishon Vijay Abraham I, Vinod Koul
Cc: Maxime Ripard, Chen-Yu Tsai, Kevin Hilman, Neil Armstrong,
Jerome Brunet, Martin Blumenstingl, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Florian Fainelli, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Lubomir Rintel, Matthias Brugger, Randy Dunlap,
Krzysztof Kozlowski, Colin Ian King, Ondrej Jirman,
Rikard Falkeborn, Icenowy Zheng, Remi Pommarel,
Lorenzo Pieralisi, Yue Wang, Hanjie Lin, Joe Perches,
Bharat Gooty, Rayagonda Kokatanur, Peter Chen, Roger Quadros,
Jyri Sarha, Sanket Parmar, Anil Varughese, Li Jun, Ma Feng,
Wei Yongjun, linux-kernel, linux-arm-kernel, linux-amlogic,
linux-mediatek, Al Cooper
On 10/28/2020 7:54 PM, Chunfeng Yun wrote:
> Use devm_platform_ioremap_resource(_byname) to simplify code
>
> Cc: Al Cooper <alcooperx@gmail.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-30 3:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1603940079-8131-1-git-send-email-chunfeng.yun@mediatek.com>
[not found] ` <1603940079-8131-2-git-send-email-chunfeng.yun@mediatek.com>
2020-10-29 8:24 ` [PATCH 02/17] phy: amlogic: convert to devm_platform_ioremap_resource Remi Pommarel
2020-10-30 3:46 ` Chunfeng Yun
[not found] ` <1603940079-8131-15-git-send-email-chunfeng.yun@mediatek.com>
2020-10-29 10:20 ` [PATCH 15/17] phy: phy-stm32-usbphyc: " Amelie DELAUNAY
[not found] ` <1603940079-8131-4-git-send-email-chunfeng.yun@mediatek.com>
2020-10-29 10:50 ` [PATCH 04/17] phy: cadence: " Peter Chen
[not found] ` <1603940079-8131-5-git-send-email-chunfeng.yun@mediatek.com>
2020-10-29 10:51 ` [PATCH 05/17] phy: freescale: " Peter Chen
[not found] ` <1603940079-8131-14-git-send-email-chunfeng.yun@mediatek.com>
2020-10-29 16:50 ` [PATCH 14/17] phy: samsung: " Krzysztof Kozlowski
[not found] ` <1603940079-8131-3-git-send-email-chunfeng.yun@mediatek.com>
2020-10-30 3:49 ` [PATCH 03/17] phy: broadcom: convert to devm_platform_ioremap_resource(_byname) Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).