* [PATCH] ubifs: Remove the redundant return in dbg_check_nondata_nodes_order
@ 2020-11-02 8:27 Chengsong Ke
2020-12-11 3:34 ` Chengsong Ke
0 siblings, 1 reply; 2+ messages in thread
From: Chengsong Ke @ 2020-11-02 8:27 UTC (permalink / raw)
To: richard, s.hauer; +Cc: linux-mtd, linux-kernel, wangfangpeng1
There is a redundant return in dbg_check_nondata_nodes_order,
which will be never reached. In addition, error code should be
returned instead of zero in this branch.
Signed-off-by: Chengsong Ke <kechengsong@huawei.com>
---
fs/ubifs/debug.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index ebff43f8009c..b2db518056cb 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -2442,7 +2442,6 @@ int dbg_check_nondata_nodes_order(struct ubifs_info *c, struct list_head *head)
ubifs_msg(c, "dumping second node");
ubifs_dump_node(c, sb->node);
return -EINVAL;
- return 0;
}
static inline int chance(unsigned int n, unsigned int out_of)
--
2.12.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* ubifs: Remove the redundant return in dbg_check_nondata_nodes_order
2020-11-02 8:27 [PATCH] ubifs: Remove the redundant return in dbg_check_nondata_nodes_order Chengsong Ke
@ 2020-12-11 3:34 ` Chengsong Ke
0 siblings, 0 replies; 2+ messages in thread
From: Chengsong Ke @ 2020-12-11 3:34 UTC (permalink / raw)
To: richard; +Cc: linux-mtd, linux-kernel
ping
//Chengsong Ke
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-11 3:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02 8:27 [PATCH] ubifs: Remove the redundant return in dbg_check_nondata_nodes_order Chengsong Ke
2020-12-11 3:34 ` Chengsong Ke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).